https://github.com/swaywm/sway
Revision 1f8dbb320a9fdff9e59fb7641c4b5af56abc7074 authored by Johan Bjäreholt on 24 June 2020, 05:55:42 UTC, committed by Simon Ser on 01 July 2020, 15:21:57 UTC
It is not a part of the foreign-toplevel-management protocol to get the
class of a toplevel, only for getting the app_id.
For xwayland clients this is an issue because that means that you cannot
identify what application the toplevel refers to which is the point of
the app_id property.

By falling back to class when an app_id does not exist solves this problem.

Phoc also uses app_id and class interchangeably in their implementation
of foreign-toplevel-management, in fact they always do that and not only
for just this protocol.
https://source.puri.sm/Librem5/phoc/-/blob/c8d8a4c5440a6c1647b09dbd3bba7999f9cd433c/src/xwayland.c#L236
1 parent 76adcc3
History
Tip revision: 1f8dbb320a9fdff9e59fb7641c4b5af56abc7074 authored by Johan Bjäreholt on 24 June 2020, 05:55:42 UTC
tree/view: Make foreign-toplevel app_id fallback to class
Tip revision: 1f8dbb3
File Mode Size
.builds
.github
assets
client
common
completions
contrib
include
protocols
sway
swaybar
swaymsg
swaynag
.clang-format -rw-r--r-- 405 bytes
.editorconfig -rw-r--r-- 315 bytes
.gitignore -rw-r--r-- 137 bytes
CONTRIBUTING.md -rw-r--r-- 7.9 KB
ISSUE_TEMPLATE.md -rw-r--r-- 2.3 KB
LICENSE -rw-r--r-- 1.0 KB
README.de.md -rw-r--r-- 2.4 KB
README.dk.md -rw-r--r-- 2.2 KB
README.es.md -rw-r--r-- 2.2 KB
README.fr.md -rw-r--r-- 2.4 KB
README.ja.md -rw-r--r-- 3.1 KB
README.ko.md -rw-r--r-- 2.3 KB
README.md -rw-r--r-- 3.1 KB
README.nl.md -rw-r--r-- 2.2 KB
README.pl.md -rw-r--r-- 2.2 KB
README.pt.md -rw-r--r-- 2.3 KB
README.ro.md -rw-r--r-- 2.3 KB
README.ru.md -rw-r--r-- 3.1 KB
README.uk.md -rw-r--r-- 3.8 KB
README.zh-CN.md -rw-r--r-- 1.8 KB
README.zh-TW.md -rw-r--r-- 2.0 KB
config.in -rw-r--r-- 6.7 KB
meson.build -rw-r--r-- 8.3 KB
meson_options.txt -rw-r--r-- 832 bytes
sway.desktop -rw-r--r-- 97 bytes

README.md

back to top