Skip to main content

Browse the archive

Revision 1fdfb4292c2c31dc333b57b6a8e7b8c029efa597 authored by Benjamin Wang on 14 December 2022, 18:12:49 UTC, committed by Benjamin Wang on 14 December 2022, 18:12:49 UTC 
clientv3: revert the client side change in 14547
 
In order to fix https://github.com/etcd-io/etcd/issues/12385,
PR https://github.com/etcd-io/etcd/pull/14322 introduced a change
in which the client side may retry based on the error message
returned from server side.

This is not good, as it's too fragile and it's also changed the
protocol between client and server. Please see the discussion
in https://github.com/kubernetes/kubernetes/pull/114403

Note: The issue https://github.com/etcd-io/etcd/issues/12385 only
happens when auth is enabled, and client side reuse the same client
to watch.

So we decided to rollback the change on 3.5, reasons:
1.K8s doesn't enable auth at all. It has no any impact on K8s.
2.It's very easy for client application to workaround the issue.
  The client just needs to create a new client each time before watching.

Signed-off-by: Benjamin Wang <wachao@vmware.com>
1 parent 127e9c0
Raw File
codecov.yml 
codecov:
  token: "6040de41-c073-4d6f-bbf8-d89256ef31e1"
  disable_default_path_fixes: true

fixes:
  - "go.etcd.io/etcd/api/v3/::api/"
  - "go.etcd.io/etcd/client/v3/::client/v3/"
  - "go.etcd.io/etcd/client/v2/::client/v2/"
  - "go.etcd.io/etcd/etcdctl/v3/::etcdctl/"
  - "go.etcd.io/etcd/pkg/v3/::pkg/"
  - "go.etcd.io/etcd/raft/v3/::raft/"
  - "go.etcd.io/etcd/server/v3/::server/"

ignore:
  - "**/*.pb.go"
  - "**/*.pb.gw.go"
  - "tests/**/*"
  - "go.etcd.io/etcd/tests/**/*"
back to top