Revision 208cfc11c0a61d6d44ec395699ff32c6dcf6ab52 authored by Manuel Rego Casasnovas on 19 March 2018, 16:01:26 UTC, committed by Chromium WPT Sync on 19 March 2018, 16:01:26 UTC
LayoutBox::FillAvailableMeasure() was not considering the case of orthogonal elements when computing the margins. The margins ended up being properly calculated but the size of the orthogonal elements was wrong, as they considered to have more or less space than the available one. The method is modified in order to use the containing block inline size in order to resolve the percentages: https://www.w3.org/TR/css-writing-modes-3/#dimension-mapping BUG=808758 TEST=external/wpt/css/css-writing-modes/sizing-orthogonal-percentage-margin-00*.html Change-Id: Ib8c81dcd14589b3fefe806de3f8f75c000b1cac9 Reviewed-on: https://chromium-review.googlesource.com/968522 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#544047}
1 parent 5dee619
transaction-lifetime-empty.html
<!DOCTYPE html>
<title>IndexedDB: Commit ordering of empty transactions</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="support.js"></script>
<script>
// Call with a test object and array of expected values. Returns a
// function to call with each actual value. Once the expected number
// of values is seen, asserts that the value orders match and completes
// the test.
function expect(t, expected) {
var results = [];
return result => {
results.push(result);
if (results.length === expected.length) {
assert_array_equals(results, expected);
t.done();
}
};
}
indexeddb_test(
(t, db) => {
db.createObjectStore('store');
},
(t, db) => {
var saw = expect(t, ['rq1.onsuccess',
'rq2.onsuccess',
'tx1.oncomplete',
'tx2.oncomplete']);
var tx1 = db.transaction('store', 'readwrite');
tx1.onabort = t.unreached_func('transaction should commit');
tx1.oncomplete = t.step_func(() => saw('tx1.oncomplete'));
var store = tx1.objectStore('store');
var rq1 = store.put('a', 1);
rq1.onerror = t.unreached_func('put should succeed');
rq1.onsuccess = t.step_func(() => {
saw('rq1.onsuccess');
var tx2 = db.transaction('store', 'readonly');
tx2.onabort = t.unreached_func('transaction should commit');
tx2.oncomplete = t.step_func(() => saw('tx2.oncomplete'));
var rq2 = store.put('b', 2);
rq2.onsuccess = t.step_func(() => saw('rq2.onsuccess'));
rq2.onerror = t.unreached_func('request should succeed');
});
},
'Transactions without requests complete in the expected order');
indexeddb_test(
(t, db) => {
db.createObjectStore('store');
},
(t, db) => {
var saw = expect(t, ['rq1.onsuccess',
'rq2.onsuccess',
'tx1.oncomplete',
'tx2.oncomplete',
'tx3.oncomplete']);
var tx1 = db.transaction('store', 'readwrite');
tx1.onabort = t.unreached_func('transaction should commit');
tx1.oncomplete = t.step_func(() => saw('tx1.oncomplete'));
var store = tx1.objectStore('store');
var rq1 = store.put('a', 1);
rq1.onerror = t.unreached_func('put should succeed');
rq1.onsuccess = t.step_func(() => {
saw('rq1.onsuccess');
var tx2 = db.transaction('store', 'readonly');
tx2.onabort = t.unreached_func('transaction should commit');
tx2.oncomplete = t.step_func(() => saw('tx2.oncomplete'));
var tx3 = db.transaction('store', 'readonly');
tx3.onabort = t.unreached_func('transaction should commit');
tx3.oncomplete = t.step_func(() => saw('tx3.oncomplete'));
var rq2 = store.put('b', 2);
rq2.onsuccess = t.step_func(() => saw('rq2.onsuccess'));
rq2.onerror = t.unreached_func('request should succeed');
});
},
'Multiple transactions without requests complete in the expected order');
</script>
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...