Revision 20cd0c86553e14c495451ce7d1e2e4efd81041f0 authored by Manos Pitsidianakis on 24 March 2024, 10:04:59 UTC, committed by Michael Tokarev on 09 April 2024, 18:15:05 UTC
The current handling of invalid virtqueue elements inside the TX/RX virt queue handlers is wrong. They are added in a per-stream invalid queue to be processed after the handler is done examining each message, but the invalid message might not be specifying any stream_id; which means it's invalid to add it to any stream->invalid queue since stream could be NULL at this point. This commit moves the invalid queue to the VirtIOSound struct which guarantees there will always be a valid temporary place to store them inside the tx/rx handlers. The queue will be emptied before the handler returns, so the queue must be empty at any other point of the device's lifetime. Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org> Message-Id: <virtio-snd-rewrite-invalid-tx-rx-message-handling-v1.manos.pitsidianakis@linaro.org> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> (cherry picked from commit 731655f87f319fd06f27282c6cafbc2467ac8045) Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
1 parent 627aa46
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 584 bytes |
| allwinner-i2c.c | -rw-r--r-- | 14.2 KB |
| arm_sbcon_i2c.c | -rw-r--r-- | 3.1 KB |
| aspeed_i2c.c | -rw-r--r-- | 47.0 KB |
| bitbang_i2c.c | -rw-r--r-- | 6.4 KB |
| core.c | -rw-r--r-- | 10.6 KB |
| exynos4210_i2c.c | -rw-r--r-- | 9.8 KB |
| i2c_mux_pca954x.c | -rw-r--r-- | 6.7 KB |
| imx_i2c.c | -rw-r--r-- | 9.6 KB |
| meson.build | -rw-r--r-- | 1.3 KB |
| microbit_i2c.c | -rw-r--r-- | 3.6 KB |
| mpc_i2c.c | -rw-r--r-- | 9.0 KB |
| npcm7xx_smbus.c | -rw-r--r-- | 32.2 KB |
| omap_i2c.c | -rw-r--r-- | 14.7 KB |
| pm_smbus.c | -rw-r--r-- | 13.9 KB |
| pmbus_device.c | -rw-r--r-- | 61.2 KB |
| ppc4xx_i2c.c | -rw-r--r-- | 11.1 KB |
| smbus_eeprom.c | -rw-r--r-- | 9.1 KB |
| smbus_ich9.c | -rw-r--r-- | 4.6 KB |
| smbus_master.c | -rw-r--r-- | 3.4 KB |
| smbus_slave.c | -rw-r--r-- | 5.8 KB |
| trace-events | -rw-r--r-- | 2.9 KB |
| trace.h | -rw-r--r-- | 32 bytes |
Computing file changes ...
