Revision 20cd0c86553e14c495451ce7d1e2e4efd81041f0 authored by Manos Pitsidianakis on 24 March 2024, 10:04:59 UTC, committed by Michael Tokarev on 09 April 2024, 18:15:05 UTC
The current handling of invalid virtqueue elements inside the TX/RX virt
queue handlers is wrong.

They are added in a per-stream invalid queue to be processed after the
handler is done examining each message, but the invalid message might
not be specifying any stream_id; which means it's invalid to add it to
any stream->invalid queue since stream could be NULL at this point.

This commit moves the invalid queue to the VirtIOSound struct which
guarantees there will always be a valid temporary place to store them
inside the tx/rx handlers. The queue will be emptied before the handler
returns, so the queue must be empty at any other point of the device's
lifetime.

Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Message-Id: <virtio-snd-rewrite-invalid-tx-rx-message-handling-v1.manos.pitsidianakis@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
(cherry picked from commit 731655f87f319fd06f27282c6cafbc2467ac8045)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
1 parent 627aa46
History
File Mode Size
Kconfig -rw-r--r-- 561 bytes
an5206.c -rw-r--r-- 2.9 KB
bootinfo.h -rw-r--r-- 2.0 KB
mcf5206.c -rw-r--r-- 16.5 KB
mcf5208.c -rw-r--r-- 10.0 KB
mcf_intc.c -rw-r--r-- 5.5 KB
meson.build -rw-r--r-- 431 bytes
next-cube.c -rw-r--r-- 32.2 KB
next-kbd.c -rw-r--r-- 7.7 KB
q800-glue.c -rw-r--r-- 6.8 KB
q800.c -rw-r--r-- 27.0 KB
virt.c -rw-r--r-- 13.2 KB

back to top