Revision 20cd0c86553e14c495451ce7d1e2e4efd81041f0 authored by Manos Pitsidianakis on 24 March 2024, 10:04:59 UTC, committed by Michael Tokarev on 09 April 2024, 18:15:05 UTC
The current handling of invalid virtqueue elements inside the TX/RX virt queue handlers is wrong. They are added in a per-stream invalid queue to be processed after the handler is done examining each message, but the invalid message might not be specifying any stream_id; which means it's invalid to add it to any stream->invalid queue since stream could be NULL at this point. This commit moves the invalid queue to the VirtIOSound struct which guarantees there will always be a valid temporary place to store them inside the tx/rx handlers. The queue will be emptied before the handler returns, so the queue must be empty at any other point of the device's lifetime. Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org> Message-Id: <virtio-snd-rewrite-invalid-tx-rx-message-handling-v1.manos.pitsidianakis@linaro.org> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> (cherry picked from commit 731655f87f319fd06f27282c6cafbc2467ac8045) Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
1 parent 627aa46
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 330 bytes |
meson.build | -rw-r--r-- | 710 bytes |
msi.c | -rw-r--r-- | 15.3 KB |
msix.c | -rw-r--r-- | 20.3 KB |
pci-hmp-cmds.c | -rw-r--r-- | 8.0 KB |
pci-internal.h | -rw-r--r-- | 614 bytes |
pci-qmp-cmds.c | -rw-r--r-- | 6.6 KB |
pci-stub.c | -rw-r--r-- | 2.1 KB |
pci.c | -rw-r--r-- | 87.4 KB |
pci_bridge.c | -rw-r--r-- | 18.1 KB |
pci_host.c | -rw-r--r-- | 7.9 KB |
pcie.c | -rw-r--r-- | 39.4 KB |
pcie_aer.c | -rw-r--r-- | 29.4 KB |
pcie_doe.c | -rw-r--r-- | 10.0 KB |
pcie_host.c | -rw-r--r-- | 4.1 KB |
pcie_port.c | -rw-r--r-- | 6.9 KB |
pcie_sriov.c | -rw-r--r-- | 9.2 KB |
shpc.c | -rw-r--r-- | 25.2 KB |
slotid_cap.c | -rw-r--r-- | 1.5 KB |
trace-events | -rw-r--r-- | 1.3 KB |
trace.h | -rw-r--r-- | 32 bytes |
Computing file changes ...