https://github.com/web-platform-tests/wpt
Revision 22354d237b5a89a7771d4329d02f3f7c8af17796 authored by François Doray on 29 March 2018, 16:39:25 UTC, committed by Chromium WPT Sync on 29 March 2018, 16:39:25 UTC
This reverts commit 6a337f19713e049cd42969b0c909c59aff4146cd.

Reason for revert: https://crbug.com/824704

These tests are failing:

external/wpt/bluetooth/server/getPrimaryServices/blocklisted-services-with-uuid.https.html
external/wpt/bluetooth/server/getPrimaryServices/blocklisted-services.https.html
external/wpt/bluetooth/service/getCharacteristic/gen-blocklisted-characteristic.https.html
external/wpt/bluetooth/service/getCharacteristics/blocklisted-characteristics.https.html
external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html

Original change's description:
> bluetooth: FakeBluetoothChooser impl.
>
> Implements the interfaces that FakeBluetoothChooser overrides. The
> mojom::FakeBluetoothChooser overrides are implemented by running
> |event_handler_| with the appropriate arguments. The BluetoothChooser
> overrides do nothing at the moment, since the base class is only meant
> to update the chooser user interface.
>
> This change also begins to partially convert a Bluetooth chooser test to test
> the interface and deletes the temporary tests that were created to test this
> API.
>
> This change reverts commit 42624492cd5e80855f1dd3a5a8146b258def2c2a, which
> reverted the original change. The original change caused the
> new-scan-device-added.html test to fail because of a Mojo validation error
> resulting from not updating the
> third_party/.../external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js
> file needed by the test.
>
> Bug: 719827, 719826, 824704, 826787
> Change-Id: I5e5cce7e809b4d71216c2d074a417ea822d5e527
> Reviewed-on: https://chromium-review.googlesource.com/985195
> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#546729}

TBR=dcheng@chromium.org,cco3@chromium.org,ortuno@chromium.org,odejesush@chromium.org

Change-Id: Ie2ef2af1ae74e8dd5ca01441027adaa59e6e0c0f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 719827, 719826, 824704, 826787
Reviewed-on: https://chromium-review.googlesource.com/986592
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546851}
1 parent afcd47b
History
Tip revision: 22354d237b5a89a7771d4329d02f3f7c8af17796 authored by François Doray on 29 March 2018, 16:39:25 UTC
Revert "bluetooth: FakeBluetoothChooser impl."
Tip revision: 22354d2

back to top