https://github.com/torvalds/linux
Revision 227a3a2fc31d8e4bb9c88d4804e19530af245b1b authored by Eliav Farber on 08 September 2022, 15:24:32 UTC, committed by Guenter Roeck on 08 September 2022, 18:55:24 UTC
According to Moortec Embedded Voltage Monitor (MEVM) series 3 data sheet, the minimum input signal is -100mv and maximum input signal is +1000mv. The equation used to convert the digital word to voltage uses mixed types (*val signed and n unsigned), and on 64 bit machines also has different size, since sizeof(u32) = 4 and sizeof(long) = 8. So when measuring a negative input, n will be small enough, such that PVT_N_CONST * n < PVT_R_CONST, and the result of (PVT_N_CONST * n - PVT_R_CONST) will overflow to a very big positive 32 bit number. Then when storing the result in *val it will be the same value just in 64 bit (instead of it representing a negative number which will what happen when sizeof(long) = 4). When -1023 <= (PVT_N_CONST * n - PVT_R_CONST) <= -1 dividing the number by 1024 should result of in 0, but because ">> 10" is used, and the sign bit is used to fill the vacated bit positions, it results in -1 (0xf...fffff) which is wrong. This change fixes the sign problem and supports negative values by casting n to long and replacing the shift right with div operation. Fixes: 9d823351a337 ("hwmon: Add hardware monitoring driver for Moortec MR75203 PVT controller") Signed-off-by: Eliav Farber <farbere@amazon.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20220908152449.35457-5-farbere@amazon.com Signed-off-by: Guenter Roeck <linux@roeck-us.net>
1 parent bb9195b
Tip revision: 227a3a2fc31d8e4bb9c88d4804e19530af245b1b authored by Eliav Farber on 08 September 2022, 15:24:32 UTC
hwmon: (mr75203) fix voltage equation for negative source input
hwmon: (mr75203) fix voltage equation for negative source input
Tip revision: 227a3a2
File | Mode | Size |
---|---|---|
9p | ||
adfs | ||
affs | ||
afs | ||
autofs | ||
befs | ||
bfs | ||
btrfs | ||
cachefiles | ||
ceph | ||
cifs | ||
coda | ||
configfs | ||
cramfs | ||
crypto | ||
debugfs | ||
devpts | ||
dlm | ||
ecryptfs | ||
efivarfs | ||
efs | ||
erofs | ||
exfat | ||
exportfs | ||
ext2 | ||
ext4 | ||
f2fs | ||
fat | ||
freevxfs | ||
fscache | ||
fuse | ||
gfs2 | ||
hfs | ||
hfsplus | ||
hostfs | ||
hpfs | ||
hugetlbfs | ||
iomap | ||
isofs | ||
jbd2 | ||
jffs2 | ||
jfs | ||
kernfs | ||
ksmbd | ||
lockd | ||
minix | ||
netfs | ||
nfs | ||
nfs_common | ||
nfsd | ||
nilfs2 | ||
nls | ||
notify | ||
ntfs | ||
ntfs3 | ||
ocfs2 | ||
omfs | ||
openpromfs | ||
orangefs | ||
overlayfs | ||
proc | ||
pstore | ||
qnx4 | ||
qnx6 | ||
quota | ||
ramfs | ||
reiserfs | ||
romfs | ||
smbfs_common | ||
squashfs | ||
sysfs | ||
sysv | ||
tracefs | ||
ubifs | ||
udf | ||
ufs | ||
unicode | ||
vboxsf | ||
verity | ||
xfs | ||
zonefs | ||
Kconfig | -rw-r--r-- | 9.8 KB |
Kconfig.binfmt | -rw-r--r-- | 7.4 KB |
Makefile | -rw-r--r-- | 4.5 KB |
aio.c | -rw-r--r-- | 61.0 KB |
anon_inodes.c | -rw-r--r-- | 8.1 KB |
attr.c | -rw-r--r-- | 13.3 KB |
bad_inode.c | -rw-r--r-- | 5.8 KB |
binfmt_aout.c | -rw-r--r-- | 8.2 KB |
binfmt_elf.c | -rw-r--r-- | 61.6 KB |
binfmt_elf_fdpic.c | -rw-r--r-- | 43.4 KB |
binfmt_elf_test.c | -rw-r--r-- | 2.7 KB |
binfmt_flat.c | -rw-r--r-- | 25.8 KB |
binfmt_misc.c | -rw-r--r-- | 17.4 KB |
binfmt_script.c | -rw-r--r-- | 4.2 KB |
buffer.c | -rw-r--r-- | 80.1 KB |
char_dev.c | -rw-r--r-- | 16.5 KB |
compat_binfmt_elf.c | -rw-r--r-- | 3.8 KB |
coredump.c | -rw-r--r-- | 28.8 KB |
d_path.c | -rw-r--r-- | 11.5 KB |
dax.c | -rw-r--r-- | 52.4 KB |
dcache.c | -rw-r--r-- | 88.0 KB |
direct-io.c | -rw-r--r-- | 39.0 KB |
drop_caches.c | -rw-r--r-- | 1.9 KB |
eventfd.c | -rw-r--r-- | 12.0 KB |
eventpoll.c | -rw-r--r-- | 64.9 KB |
exec.c | -rw-r--r-- | 51.1 KB |
fcntl.c | -rw-r--r-- | 23.3 KB |
fhandle.c | -rw-r--r-- | 6.8 KB |
file.c | -rw-r--r-- | 31.6 KB |
file_table.c | -rw-r--r-- | 11.0 KB |
filesystems.c | -rw-r--r-- | 6.5 KB |
fs-writeback.c | -rw-r--r-- | 78.8 KB |
fs_context.c | -rw-r--r-- | 17.7 KB |
fs_parser.c | -rw-r--r-- | 10.7 KB |
fs_pin.c | -rw-r--r-- | 1.9 KB |
fs_struct.c | -rw-r--r-- | 3.4 KB |
fs_types.c | -rw-r--r-- | 2.5 KB |
fsopen.c | -rw-r--r-- | 10.9 KB |
init.c | -rw-r--r-- | 6.1 KB |
inode.c | -rw-r--r-- | 67.3 KB |
internal.h | -rw-r--r-- | 5.8 KB |
ioctl.c | -rw-r--r-- | 23.9 KB |
kernel_read_file.c | -rw-r--r-- | 4.4 KB |
libfs.c | -rw-r--r-- | 39.7 KB |
locks.c | -rw-r--r-- | 75.1 KB |
mbcache.c | -rw-r--r-- | 12.3 KB |
mount.h | -rw-r--r-- | 4.0 KB |
mpage.c | -rw-r--r-- | 18.8 KB |
namei.c | -rw-r--r-- | 136.5 KB |
namespace.c | -rw-r--r-- | 113.9 KB |
no-block.c | -rw-r--r-- | 478 bytes |
nsfs.c | -rw-r--r-- | 6.6 KB |
open.c | -rw-r--r-- | 37.4 KB |
pipe.c | -rw-r--r-- | 36.0 KB |
pnode.c | -rw-r--r-- | 15.1 KB |
pnode.h | -rw-r--r-- | 2.0 KB |
posix_acl.c | -rw-r--r-- | 25.8 KB |
proc_namespace.c | -rw-r--r-- | 8.1 KB |
read_write.c | -rw-r--r-- | 40.0 KB |
readdir.c | -rw-r--r-- | 13.9 KB |
remap_range.c | -rw-r--r-- | 14.1 KB |
select.c | -rw-r--r-- | 34.7 KB |
seq_file.c | -rw-r--r-- | 25.7 KB |
signalfd.c | -rw-r--r-- | 8.7 KB |
splice.c | -rw-r--r-- | 38.7 KB |
stack.c | -rw-r--r-- | 2.5 KB |
stat.c | -rw-r--r-- | 21.7 KB |
statfs.c | -rw-r--r-- | 9.7 KB |
super.c | -rw-r--r-- | 46.7 KB |
sync.c | -rw-r--r-- | 10.4 KB |
sysctls.c | -rw-r--r-- | 809 bytes |
timerfd.c | -rw-r--r-- | 13.9 KB |
userfaultfd.c | -rw-r--r-- | 54.6 KB |
utimes.c | -rw-r--r-- | 7.6 KB |
xattr.c | -rw-r--r-- | 28.9 KB |
Computing file changes ...