Skip to main content

Browse the archive

Revision 230f0b9b7cb4885864d457c82e312489c0a0d3d7 authored by Paul Chaignon on 21 May 2021, 21:10:24 UTC, committed by Nathan Sweet on 04 June 2021, 16:46:12 UTC 
.github: Fix scheduled end-to-end tests
 
[ upstream commit 802d25447fa1d325d3713220f8ad08e7938f6dd4 ]

Commit 50df544 added a new job in the end-to-end workflows to checkout
the tested code and run paths-filter on it. That first job fails when
the workflows are scheduled (vs. triggered by PR comment) because we try
to grab the pull request URL, which doesn't exist:

    curl ${{ github.event.issue.pull_request.url }} > pr.json

results in error:

    Run curl  > pr.json
    curl: try 'curl --help' or 'curl --manual' for more information

We can avoid this by skipping steps in the first job when triggered by
schedule. We can't skip the entire first job because the second job has
a dependency on the first and would fail if we skipped the first.

Fixes: 50df544 (".github: Skip unnecessary ci-xxx tests")
Signed-off-by: Paul Chaignon <paul@cilium.io>
Signed-off-by: Quentin Monnet <quentin@isovalent.com>
1 parent e942366
Raw File
provider_alibabacloud_flags.go 
// Copyright 2021 Authors of Cilium
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
//     http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

//+build ipam_provider_alibabacloud

package main

import (
	operatorOption "github.com/cilium/cilium/operator/option"
	"github.com/cilium/cilium/pkg/option"

	"github.com/spf13/viper"
)

func init() {
	flags := rootCmd.Flags()

	flags.String(operatorOption.AlibabaCloudVPCID, "", "Specific VPC ID for AlibabaCloud ENI. If not set use same VPC as operator")
	option.BindEnv(operatorOption.AlibabaCloudVPCID)

	viper.BindPFlags(flags)
}
back to top