https://github.com/Kitware/CMake
Revision 23409f50f13a337333021b458a42273464100eae authored by Brad King on 09 May 2014, 14:50:29 UTC, committed by Brad King on 09 May 2014, 15:12:48 UTC
This policy should be checked at the call site that tries to access the LOCATION property, not the directory scope containing the target. Thread the caller context through cmTarget::GetProperty to use for checking the policy setting and emitting a diagnostic with proper backtrace. Extend the RunCMake.CMP0026 test with a cross-directory case.
1 parent 2e75bf6
Tip revision: 23409f50f13a337333021b458a42273464100eae authored by Brad King on 09 May 2014, 14:50:29 UTC
cmTarget: Evaluate CMP0026 in calling context
cmTarget: Evaluate CMP0026 in calling context
Tip revision: 23409f5
cmMarkAsAdvancedCommand.cxx
/*============================================================================
CMake - Cross Platform Makefile Generator
Copyright 2000-2009 Kitware, Inc., Insight Software Consortium
Distributed under the OSI-approved BSD License (the "License");
see accompanying file Copyright.txt for details.
This software is distributed WITHOUT ANY WARRANTY; without even the
implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
See the License for more information.
============================================================================*/
#include "cmMarkAsAdvancedCommand.h"
// cmMarkAsAdvancedCommand
bool cmMarkAsAdvancedCommand
::InitialPass(std::vector<std::string> const& args, cmExecutionStatus &)
{
if(args.size() < 1 )
{
this->SetError("called with incorrect number of arguments");
return false;
}
unsigned int i =0;
const char* value = "1";
bool overwrite = false;
if(args[0] == "CLEAR" || args[0] == "FORCE")
{
overwrite = true;
if(args[0] == "CLEAR")
{
value = "0";
}
i = 1;
}
for(; i < args.size(); ++i)
{
std::string variable = args[i];
cmCacheManager* manager = this->Makefile->GetCacheManager();
cmCacheManager::CacheIterator it =
manager->GetCacheIterator(variable.c_str());
if ( it.IsAtEnd() )
{
this->Makefile->GetCacheManager()
->AddCacheEntry(variable.c_str(), 0, 0,
cmCacheManager::UNINITIALIZED);
overwrite = true;
}
it.Find(variable.c_str());
if ( it.IsAtEnd() )
{
cmSystemTools::Error("This should never happen...");
return false;
}
if ( !it.PropertyExists("ADVANCED") || overwrite )
{
it.SetProperty("ADVANCED", value);
}
}
return true;
}
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...