https://github.com/torvalds/linux
Revision 2359a47671fc4fb0fe5e9945f76c2cb10792c0f8 authored by Eric Dumazet on 29 July 2012, 20:52:21 UTC, committed by David S. Miller on 10 August 2012, 23:52:54 UTC
One condition before codel_Newton_step() was not good if we never left the dropping state for a flow. As a result rec_inv_sqrt was 0, instead of the ~0 initial value. codel control law was then set to a very aggressive mode, dropping many packets before reaching 'target' and recovering from this problem. To keep codel_vars_init() as efficient as possible, refine the condition to make sure rec_inv_sqrt initial value is correct Many thanks to Anton Mich for discovering the issue and suggesting a fix. Reported-by: Anton Mich <lp2s1h@gmail.com> Signed-off-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 55461dd
Tip revision: 2359a47671fc4fb0fe5e9945f76c2cb10792c0f8 authored by Eric Dumazet on 29 July 2012, 20:52:21 UTC
codel: refine one condition to avoid a nul rec_inv_sqrt
codel: refine one condition to avoid a nul rec_inv_sqrt
Tip revision: 2359a47
| File | Mode | Size |
|---|---|---|
| 9p | ||
| adfs | ||
| affs | ||
| afs | ||
| autofs4 | ||
| befs | ||
| bfs | ||
| btrfs | ||
| cachefiles | ||
| ceph | ||
| cifs | ||
| coda | ||
| configfs | ||
| cramfs | ||
| debugfs | ||
| devpts | ||
| dlm | ||
| ecryptfs | ||
| efs | ||
| exofs | ||
| exportfs | ||
| ext2 | ||
| ext3 | ||
| ext4 | ||
| fat | ||
| freevxfs | ||
| fscache | ||
| fuse | ||
| gfs2 | ||
| hfs | ||
| hfsplus | ||
| hostfs | ||
| hpfs | ||
| hppfs | ||
| hugetlbfs | ||
| isofs | ||
| jbd | ||
| jbd2 | ||
| jffs2 | ||
| jfs | ||
| lockd | ||
| logfs | ||
| minix | ||
| ncpfs | ||
| nfs | ||
| nfs_common | ||
| nfsd | ||
| nilfs2 | ||
| nls | ||
| notify | ||
| ntfs | ||
| ocfs2 | ||
| omfs | ||
| openpromfs | ||
| proc | ||
| pstore | ||
| qnx4 | ||
| qnx6 | ||
| quota | ||
| ramfs | ||
| reiserfs | ||
| romfs | ||
| squashfs | ||
| sysfs | ||
| sysv | ||
| ubifs | ||
| udf | ||
| ufs | ||
| xfs | ||
| Kconfig | -rw-r--r-- | 6.2 KB |
| Kconfig.binfmt | -rw-r--r-- | 6.4 KB |
| Makefile | -rw-r--r-- | 4.0 KB |
| aio.c | -rw-r--r-- | 45.7 KB |
| anon_inodes.c | -rw-r--r-- | 6.4 KB |
| attr.c | -rw-r--r-- | 6.9 KB |
| bad_inode.c | -rw-r--r-- | 7.7 KB |
| binfmt_aout.c | -rw-r--r-- | 11.7 KB |
| binfmt_elf.c | -rw-r--r-- | 54.7 KB |
| binfmt_elf_fdpic.c | -rw-r--r-- | 48.5 KB |
| binfmt_em86.c | -rw-r--r-- | 2.8 KB |
| binfmt_flat.c | -rw-r--r-- | 26.7 KB |
| binfmt_misc.c | -rw-r--r-- | 15.1 KB |
| binfmt_script.c | -rw-r--r-- | 2.8 KB |
| binfmt_som.c | -rw-r--r-- | 7.1 KB |
| bio-integrity.c | -rw-r--r-- | 21.2 KB |
| bio.c | -rw-r--r-- | 40.9 KB |
| block_dev.c | -rw-r--r-- | 42.7 KB |
| buffer.c | -rw-r--r-- | 85.2 KB |
| char_dev.c | -rw-r--r-- | 13.8 KB |
| compat.c | -rw-r--r-- | 44.5 KB |
| compat_binfmt_elf.c | -rw-r--r-- | 3.5 KB |
| compat_ioctl.c | -rw-r--r-- | 45.2 KB |
| dcache.c | -rw-r--r-- | 80.4 KB |
| dcookies.c | -rw-r--r-- | 6.8 KB |
| direct-io.c | -rw-r--r-- | 37.2 KB |
| drop_caches.c | -rw-r--r-- | 1.5 KB |
| eventfd.c | -rw-r--r-- | 10.9 KB |
| eventpoll.c | -rw-r--r-- | 53.4 KB |
| exec.c | -rw-r--r-- | 53.5 KB |
| fcntl.c | -rw-r--r-- | 19.4 KB |
| fhandle.c | -rw-r--r-- | 6.5 KB |
| fifo.c | -rw-r--r-- | 3.2 KB |
| file.c | -rw-r--r-- | 11.8 KB |
| file_table.c | -rw-r--r-- | 14.6 KB |
| filesystems.c | -rw-r--r-- | 6.3 KB |
| fs-writeback.c | -rw-r--r-- | 39.4 KB |
| fs_struct.c | -rw-r--r-- | 3.6 KB |
| generic_acl.c | -rw-r--r-- | 3.8 KB |
| inode.c | -rw-r--r-- | 48.5 KB |
| internal.h | -rw-r--r-- | 2.9 KB |
| ioctl.c | -rw-r--r-- | 15.7 KB |
| ioprio.c | -rw-r--r-- | 5.0 KB |
| libfs.c | -rw-r--r-- | 25.8 KB |
| locks.c | -rw-r--r-- | 58.8 KB |
| mbcache.c | -rw-r--r-- | 16.4 KB |
| mount.h | -rw-r--r-- | 2.2 KB |
| mpage.c | -rw-r--r-- | 20.0 KB |
| namei.c | -rw-r--r-- | 97.0 KB |
| namespace.c | -rw-r--r-- | 64.5 KB |
| no-block.c | -rw-r--r-- | 688 bytes |
| open.c | -rw-r--r-- | 25.4 KB |
| pipe.c | -rw-r--r-- | 28.6 KB |
| pnode.c | -rw-r--r-- | 8.8 KB |
| pnode.h | -rw-r--r-- | 1.4 KB |
| posix_acl.c | -rw-r--r-- | 9.2 KB |
| proc_namespace.c | -rw-r--r-- | 7.5 KB |
| read_write.c | -rw-r--r-- | 22.5 KB |
| read_write.h | -rw-r--r-- | 542 bytes |
| readdir.c | -rw-r--r-- | 7.0 KB |
| select.c | -rw-r--r-- | 24.1 KB |
| seq_file.c | -rw-r--r-- | 19.5 KB |
| signalfd.c | -rw-r--r-- | 8.1 KB |
| splice.c | -rw-r--r-- | 46.5 KB |
| stack.c | -rw-r--r-- | 2.5 KB |
| stat.c | -rw-r--r-- | 11.0 KB |
| statfs.c | -rw-r--r-- | 5.2 KB |
| super.c | -rw-r--r-- | 35.3 KB |
| sync.c | -rw-r--r-- | 10.8 KB |
| timerfd.c | -rw-r--r-- | 8.6 KB |
| utimes.c | -rw-r--r-- | 5.7 KB |
| xattr.c | -rw-r--r-- | 18.0 KB |
| xattr_acl.c | -rw-r--r-- | 2.3 KB |
Computing file changes ...
