Skip to main content

Browse the archive

https://github.com/torvalds/linux
13 June 2022, 11:31:42 UTC
Revision 2359a47671fc4fb0fe5e9945f76c2cb10792c0f8 authored by Eric Dumazet on 29 July 2012, 20:52:21 UTC, committed by David S. Miller on 10 August 2012, 23:52:54 UTC 
codel: refine one condition to avoid a nul rec_inv_sqrt
 
One condition before codel_Newton_step() was not good if
we never left the dropping state for a flow. As a result
rec_inv_sqrt was 0, instead of the ~0 initial value.

codel control law was then set to a very aggressive mode, dropping
many packets before reaching 'target' and recovering from this problem.

To keep codel_vars_init() as efficient as possible, refine
the condition to make sure rec_inv_sqrt initial value is correct

Many thanks to Anton Mich for discovering the issue and suggesting
a fix.

Reported-by: Anton Mich <lp2s1h@gmail.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 55461dd
History
Tip revision: 2359a47671fc4fb0fe5e9945f76c2cb10792c0f8 authored by Eric Dumazet on 29 July 2012, 20:52:21 UTC
codel: refine one condition to avoid a nul rec_inv_sqrt
Tip revision: 2359a47
File Mode Size
Kconfig -rw-r--r-- 51.4 KB
Makefile -rw-r--r-- 1.1 KB
calibrate.c -rw-r--r-- 8.3 KB
do_mounts.c -rw-r--r-- 12.8 KB
do_mounts.h -rw-r--r-- 1.4 KB
do_mounts_initrd.c -rw-r--r-- 3.4 KB
do_mounts_md.c -rw-r--r-- 8.2 KB
do_mounts_rd.c -rw-r--r-- 8.4 KB
init_task.c -rw-r--r-- 668 bytes
initramfs.c -rw-r--r-- 12.9 KB
main.c -rw-r--r-- 21.5 KB
noinitramfs.c -rw-r--r-- 1.5 KB
version.c -rw-r--r-- 1.1 KB
back to top