Skip to main content

Browse the archive

Revision 2413a06c7bf2a1f3e86680ceb041e75c729f44f1 authored by Igor Canadi on 24 April 2014, 13:22:58 UTC, committed by Igor Canadi on 24 April 2014, 13:22:58 UTC 
Improve stability of db_stress
 
Summary:
Currently, whenever DB Verification fails we bail out by calling `exit(1)`. This is kind of bad since it causes unclean shutdown and spew of error log messages like:

    05:03:27 pthread lock: Invalid argument
    05:03:27 pthread lock: Invalid argument
    05:03:27 pthread lock: Invalid argument
    05:03:27 pthread lock: Invalid argument
    05:03:27 pthread lock: Invalid argument
    05:03:27 pthread lock: Invalid argument
    05:03:27 pthread lock: Invalid argument
    05:03:27 pthread lock: Invalid argument
    05:03:27 pthread lock: Invalid argument

This diff adds a new parameter that is set to true when verification fails. It can then use the parameter to bail out safely.

Test Plan: Casued artificail failure. Verified that exit was clean.

Reviewers: dhruba, haobo, ljin

Reviewed By: haobo

CC: leveldb

Differential Revision: https://reviews.facebook.net/D18243
1 parent d8fe006
History
File Mode Size
build_detect_platform -rwxr-xr-x 10.6 KB
build_detect_version -rwxr-xr-x 810 bytes
fbcode.clang31.sh -rw-r--r-- 3.9 KB
fbcode.gcc471.sh -rw-r--r-- 3.2 KB
fbcode.gcc481.sh -rw-r--r-- 3.5 KB
format-diff.sh -rwxr-xr-x 3.3 KB
mac-install-gflags.sh -rwxr-xr-x 731 bytes
make_new_version.sh -rwxr-xr-x 1.2 KB
regression_build_test.sh -rwxr-xr-x 8.7 KB
valgrind_test.sh -rwxr-xr-x 440 bytes
back to top