https://github.com/torvalds/linux
Revision 243cd55e021baf28babdd88112ac03ae5cd4bb9c authored by Michael Ellerman on 09 June 2005, 19:36:33 UTC, committed by Linus Torvalds on 09 June 2005, 22:39:52 UTC
My patch from a few weeks back (now in mainline), called "Cleanup skbs to prevent unregister_netdevice() hanging", can cause our TX timeout code to fire on machines with lots of VLANs (because it takes > 2 seconds between when we stop the queues and when we're finished stopping the connections). When that happens the TX timeout code freaks out and does a WARN_ON() because as far as it's concerned there shouldn't be a TX timeout happening, which is fair enough. I have a "proper" fix for this, which is to a) do refcounting on connections and b) implement a proper ack timer so we don't keep unacked skbs lying around for ever. But for 2.6.12 I propose just supressing the WARN_ON(). Users will still see the "NETDEV WATCHDOG" warning, but that's not nearly as bad as a WARN_ON() which users interpret as an Oops. Signed-off-by: Michael Ellerman <michael@ellerman.id.au> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
1 parent 7fbdf1a
Tip revision: 243cd55e021baf28babdd88112ac03ae5cd4bb9c authored by Michael Ellerman on 09 June 2005, 19:36:33 UTC
[PATCH] iseries_veth: Supress spurious WARN_ON() at module unload
[PATCH] iseries_veth: Supress spurious WARN_ON() at module unload
Tip revision: 243cd55
last.c
/*
* Advanced Linux Sound Architecture
* Copyright (c) by Jaroslav Kysela <perex@suse.cz>
*
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
*
*/
#define SNDRV_MAIN_OBJECT_FILE
#include <sound/driver.h>
#include <linux/init.h>
#include <sound/core.h>
static int __init alsa_sound_last_init(void)
{
int idx, ok = 0;
printk(KERN_INFO "ALSA device list:\n");
for (idx = 0; idx < SNDRV_CARDS; idx++)
if (snd_cards[idx] != NULL) {
printk(KERN_INFO " #%i: %s\n", idx, snd_cards[idx]->longname);
ok++;
}
if (ok == 0)
printk(KERN_INFO " No soundcards found.\n");
return 0;
}
__initcall(alsa_sound_last_init);
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...