Skip to main content

Browse the archive

https://github.com/torvalds/linux
27 March 2024, 02:37:15 UTC
Revision 243cd55e021baf28babdd88112ac03ae5cd4bb9c authored by Michael Ellerman on 09 June 2005, 19:36:33 UTC, committed by Linus Torvalds on 09 June 2005, 22:39:52 UTC 
[PATCH] iseries_veth: Supress spurious WARN_ON() at module unload
 
My patch from a few weeks back (now in mainline), called "Cleanup skbs to
prevent unregister_netdevice() hanging", can cause our TX timeout code to
fire on machines with lots of VLANs (because it takes > 2 seconds between
when we stop the queues and when we're finished stopping the connections).

When that happens the TX timeout code freaks out and does a WARN_ON()
because as far as it's concerned there shouldn't be a TX timeout happening,
which is fair enough.

I have a "proper" fix for this, which is to a) do refcounting on
connections and b) implement a proper ack timer so we don't keep unacked
skbs lying around for ever.  But for 2.6.12 I propose just supressing the
WARN_ON().  Users will still see the "NETDEV WATCHDOG" warning, but that's
not nearly as bad as a WARN_ON() which users interpret as an Oops.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
1 parent 7fbdf1a
History
Tip revision: 243cd55e021baf28babdd88112ac03ae5cd4bb9c authored by Michael Ellerman on 09 June 2005, 19:36:33 UTC
[PATCH] iseries_veth: Supress spurious WARN_ON() at module unload
Tip revision: 243cd55
File Mode Size
usx2y
Kconfig -rw-r--r-- 770 bytes
Makefile -rw-r--r-- 264 bytes
usbaudio.c -rw-r--r-- 93.1 KB
usbaudio.h -rw-r--r-- 7.0 KB
usbmidi.c -rw-r--r-- 42.7 KB
usbmixer.c -rw-r--r-- 39.6 KB
usbmixer_maps.c -rw-r--r-- 5.0 KB
usbquirks.h -rw-r--r-- 28.8 KB
back to top