Skip to main content

Browse the archive

https://github.com/angular/angular
01 September 2024, 02:13:37 UTC
Revision 24fd1a18aa9f9c8fc7d240eadcdd4c95b7a411d3 authored by Pete Bacon Darwin on 01 July 2019, 13:05:55 UTC, committed by Jason Aden on 09 July 2019, 16:40:30 UTC 
fix(ivy): handle namespaced imports correctly (#31367)
 
The ngcc tool adds namespaced imports to files when compiling. The ngtsc
tooling was not processing types correctly when they were imported via
such namespaces. For example:

```
export declare class SomeModule {
    static withOptions(...): ModuleWithProviders<ɵngcc1.BaseModule>;
```

In this case the `BaseModule` was being incorrectly attributed to coming
from the current module rather than the imported module, represented by
`ɵngcc1`.

Fixes #31342

PR Close #31367
1 parent a3fc147
Raw File
Tip revision: 24fd1a18aa9f9c8fc7d240eadcdd4c95b7a411d3 authored by Pete Bacon Darwin on 01 July 2019, 13:05:55 UTC
fix(ivy): handle namespaced imports correctly (#31367)
Tip revision: 24fd1a1
LICENSE 
The MIT License

Copyright (c) 2010-2019 Google LLC. http://angular.io/license

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.
back to top