Skip to main content

Browse the archive

https://github.com/angular/angular
01 September 2024, 02:13:37 UTC
Revision 24fd1a18aa9f9c8fc7d240eadcdd4c95b7a411d3 authored by Pete Bacon Darwin on 01 July 2019, 13:05:55 UTC, committed by Jason Aden on 09 July 2019, 16:40:30 UTC 
fix(ivy): handle namespaced imports correctly (#31367)
 
The ngcc tool adds namespaced imports to files when compiling. The ngtsc
tooling was not processing types correctly when they were imported via
such namespaces. For example:

```
export declare class SomeModule {
    static withOptions(...): ModuleWithProviders<ɵngcc1.BaseModule>;
```

In this case the `BaseModule` was being incorrectly attributed to coming
from the current module rather than the imported module, represented by
`ɵngcc1`.

Fixes #31342

PR Close #31367
1 parent a3fc147
History
Tip revision: 24fd1a18aa9f9c8fc7d240eadcdd4c95b7a411d3 authored by Pete Bacon Darwin on 01 July 2019, 13:05:55 UTC
fix(ivy): handle namespaced imports correctly (#31367)
Tip revision: 24fd1a1
File Mode Size
angular1_router
benchmarks
benchmarks_external
e2e_util
payload_tests
playground
empty.ts -rw-r--r-- 389 bytes
system.d.ts -rw-r--r-- 64 bytes
tsconfig.json -rw-r--r-- 935 bytes
types.d.ts -rw-r--r-- 531 bytes
back to top