Revision 2548d546d40c0014efdde88a53bf7896e917dcce authored by Peter Zijlstra on 21 April 2016, 16:03:15 UTC, committed by Ingo Molnar on 28 April 2016, 08:28:55 UTC
Chris Metcalf reported a that sched_can_stop_tick() sometimes fails to re-enable the tick. His observed problem is that rq->cfs.nr_running can be 1 even though there are multiple runnable CFS tasks. This happens in the cgroup case, in which case cfs.nr_running is the number of runnable entities for that level. If there is a single runnable cgroup (which can have an arbitrary number of runnable child entries itself) rq->cfs.nr_running will be 1. However, looking at that function I think there's more problems with it. It seems to assume that if there's FIFO tasks, those will run. This is incorrect. The FIFO task can have a lower prio than an RR task, in which case the RR task will run. So the whole fifo_nr_running test seems misplaced, it should go after the rr_nr_running tests. That is, only if !rr_nr_running, can we use fifo_nr_running like this. Reported-by: Chris Metcalf <cmetcalf@mellanox.com> Tested-by: Chris Metcalf <cmetcalf@mellanox.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Christoph Lameter <cl@linux.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Luiz Capitulino <lcapitulino@redhat.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Rik van Riel <riel@redhat.com> Cc: Stephane Eranian <eranian@google.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Vince Weaver <vincent.weaver@maine.edu> Cc: Viresh Kumar <viresh.kumar@linaro.org> Cc: Wanpeng Li <kernellwp@gmail.com> Fixes: 76d92ac305f2 ("sched: Migrate sched to use new tick dependency mask model") Link: http://lkml.kernel.org/r/20160421160315.GK24771@twins.programming.kicks-ass.net Signed-off-by: Ingo Molnar <mingo@kernel.org>
1 parent 02da2d7
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 31.0 KB |
Makefile | -rw-r--r-- | 5.4 KB |
devres.c | -rw-r--r-- | 10.5 KB |
gpio-104-dio-48e.c | -rw-r--r-- | 11.2 KB |
gpio-104-idi-48.c | -rw-r--r-- | 8.1 KB |
gpio-104-idio-16.c | -rw-r--r-- | 7.7 KB |
gpio-74x164.c | -rw-r--r-- | 4.1 KB |
gpio-74xx-mmio.c | -rw-r--r-- | 3.7 KB |
gpio-adnp.c | -rw-r--r-- | 12.1 KB |
gpio-adp5520.c | -rw-r--r-- | 3.9 KB |
gpio-adp5588.c | -rw-r--r-- | 11.2 KB |
gpio-altera.c | -rw-r--r-- | 10.1 KB |
gpio-amd8111.c | -rw-r--r-- | 6.8 KB |
gpio-amdpt.c | -rw-r--r-- | 6.6 KB |
gpio-arizona.c | -rw-r--r-- | 4.0 KB |
gpio-ath79.c | -rw-r--r-- | 8.3 KB |
gpio-bcm-kona.c | -rw-r--r-- | 17.4 KB |
gpio-brcmstb.c | -rw-r--r-- | 14.8 KB |
gpio-bt8xx.c | -rw-r--r-- | 7.7 KB |
gpio-clps711x.c | -rw-r--r-- | 2.2 KB |
gpio-crystalcove.c | -rw-r--r-- | 9.6 KB |
gpio-cs5535.c | -rw-r--r-- | 9.2 KB |
gpio-da9052.c | -rw-r--r-- | 6.0 KB |
gpio-da9055.c | -rw-r--r-- | 4.4 KB |
gpio-davinci.c | -rw-r--r-- | 16.2 KB |
gpio-dln2.c | -rw-r--r-- | 12.7 KB |
gpio-dwapb.c | -rw-r--r-- | 16.9 KB |
gpio-em.c | -rw-r--r-- | 10.6 KB |
gpio-ep93xx.c | -rw-r--r-- | 10.4 KB |
gpio-etraxfs.c | -rw-r--r-- | 11.2 KB |
gpio-f7188x.c | -rw-r--r-- | 11.2 KB |
gpio-ge.c | -rw-r--r-- | 2.7 KB |
gpio-generic.c | -rw-r--r-- | 16.0 KB |
gpio-grgpio.c | -rw-r--r-- | 11.3 KB |
gpio-ich.c | -rw-r--r-- | 12.8 KB |
gpio-intel-mid.c | -rw-r--r-- | 11.1 KB |
gpio-iop.c | -rw-r--r-- | 2.9 KB |
gpio-it87.c | -rw-r--r-- | 9.0 KB |
gpio-janz-ttl.c | -rw-r--r-- | 4.6 KB |
gpio-kempld.c | -rw-r--r-- | 5.4 KB |
gpio-ks8695.c | -rw-r--r-- | 7.2 KB |
gpio-loongson.c | -rw-r--r-- | 2.6 KB |
gpio-lp3943.c | -rw-r--r-- | 5.5 KB |
gpio-lpc18xx.c | -rw-r--r-- | 4.0 KB |
gpio-lpc32xx.c | -rw-r--r-- | 14.8 KB |
gpio-lynxpoint.c | -rw-r--r-- | 12.4 KB |
gpio-max7300.c | -rw-r--r-- | 1.9 KB |
gpio-max7301.c | -rw-r--r-- | 2.6 KB |
gpio-max730x.c | -rw-r--r-- | 5.8 KB |
gpio-max732x.c | -rw-r--r-- | 18.3 KB |
gpio-mb86s7x.c | -rw-r--r-- | 5.5 KB |
gpio-mc33880.c | -rw-r--r-- | 4.0 KB |
gpio-mc9s08dz60.c | -rw-r--r-- | 3.2 KB |
gpio-mcp23s08.c | -rw-r--r-- | 24.9 KB |
gpio-menz127.c | -rw-r--r-- | 4.7 KB |
gpio-ml-ioh.c | -rw-r--r-- | 14.8 KB |
gpio-mm-lantiq.c | -rw-r--r-- | 4.0 KB |
gpio-moxart.c | -rw-r--r-- | 2.1 KB |
gpio-mpc5200.c | -rw-r--r-- | 9.5 KB |
gpio-mpc8xxx.c | -rw-r--r-- | 10.7 KB |
gpio-msic.c | -rw-r--r-- | 8.5 KB |
gpio-mvebu.c | -rw-r--r-- | 23.3 KB |
gpio-mxc.c | -rw-r--r-- | 13.3 KB |
gpio-mxs.c | -rw-r--r-- | 9.8 KB |
gpio-octeon.c | -rw-r--r-- | 3.5 KB |
gpio-omap.c | -rw-r--r-- | 43.7 KB |
gpio-palmas.c | -rw-r--r-- | 6.4 KB |
gpio-pca953x.c | -rw-r--r-- | 21.1 KB |
gpio-pcf857x.c | -rw-r--r-- | 12.2 KB |
gpio-pch.c | -rw-r--r-- | 13.6 KB |
gpio-pisosr.c | -rw-r--r-- | 4.4 KB |
gpio-pl061.c | -rw-r--r-- | 11.1 KB |
gpio-pxa.c | -rw-r--r-- | 20.2 KB |
gpio-rc5t583.c | -rw-r--r-- | 4.8 KB |
gpio-rcar.c | -rw-r--r-- | 14.1 KB |
gpio-rdc321x.c | -rw-r--r-- | 5.7 KB |
gpio-sa1100.c | -rw-r--r-- | 5.9 KB |
gpio-sch.c | -rw-r--r-- | 5.6 KB |
gpio-sch311x.c | -rw-r--r-- | 10.3 KB |
gpio-sodaville.c | -rw-r--r-- | 6.4 KB |
gpio-spear-spics.c | -rw-r--r-- | 5.5 KB |
gpio-sta2x11.c | -rw-r--r-- | 11.1 KB |
gpio-stmpe.c | -rw-r--r-- | 11.4 KB |
gpio-stp-xway.c | -rw-r--r-- | 8.1 KB |
gpio-sx150x.c | -rw-r--r-- | 17.0 KB |
gpio-syscon.c | -rw-r--r-- | 6.7 KB |
gpio-tb10x.c | -rw-r--r-- | 7.9 KB |
gpio-tc3589x.c | -rw-r--r-- | 8.2 KB |
gpio-tegra.c | -rw-r--r-- | 14.4 KB |
gpio-timberdale.c | -rw-r--r-- | 8.1 KB |
gpio-tpic2810.c | -rw-r--r-- | 4.0 KB |
gpio-tps65086.c | -rw-r--r-- | 3.4 KB |
gpio-tps65218.c | -rw-r--r-- | 5.4 KB |
gpio-tps6586x.c | -rw-r--r-- | 4.2 KB |
gpio-tps65910.c | -rw-r--r-- | 5.6 KB |
gpio-tps65912.c | -rw-r--r-- | 3.8 KB |
gpio-ts4800.c | -rw-r--r-- | 2.0 KB |
gpio-ts5500.c | -rw-r--r-- | 12.2 KB |
gpio-twl4030.c | -rw-r--r-- | 14.8 KB |
gpio-twl6040.c | -rw-r--r-- | 3.3 KB |
gpio-tz1090-pdc.c | -rw-r--r-- | 5.8 KB |
gpio-tz1090.c | -rw-r--r-- | 15.6 KB |
gpio-ucb1400.c | -rw-r--r-- | 2.4 KB |
gpio-vf610.c | -rw-r--r-- | 7.2 KB |
gpio-viperboard.c | -rw-r--r-- | 12.1 KB |
gpio-vr41xx.c | -rw-r--r-- | 13.1 KB |
gpio-vx855.c | -rw-r--r-- | 7.2 KB |
gpio-wm831x.c | -rw-r--r-- | 7.1 KB |
gpio-wm8350.c | -rw-r--r-- | 4.1 KB |
gpio-wm8994.c | -rw-r--r-- | 7.1 KB |
gpio-ws16c48.c | -rw-r--r-- | 11.3 KB |
gpio-xgene-sb.c | -rw-r--r-- | 10.1 KB |
gpio-xgene.c | -rw-r--r-- | 6.0 KB |
gpio-xilinx.c | -rw-r--r-- | 9.8 KB |
gpio-xlp.c | -rw-r--r-- | 11.4 KB |
gpio-xtensa.c | -rw-r--r-- | 4.7 KB |
gpio-zevio.c | -rw-r--r-- | 6.2 KB |
gpio-zx.c | -rw-r--r-- | 7.4 KB |
gpio-zynq.c | -rw-r--r-- | 24.2 KB |
gpiolib-acpi.c | -rw-r--r-- | 24.5 KB |
gpiolib-legacy.c | -rw-r--r-- | 2.4 KB |
gpiolib-of.c | -rw-r--r-- | 11.0 KB |
gpiolib-sysfs.c | -rw-r--r-- | 19.0 KB |
gpiolib.c | -rw-r--r-- | 81.2 KB |
gpiolib.h | -rw-r--r-- | 7.3 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...