Skip to main content

Browse the archive

https://github.com/angular/angular
19 April 2024, 08:24:33 UTC
sort by:
Revision Author Date Message Commit Date
257a30d Dylan Hunn 01 December 2021, 21:04:18 UTC release: cut the v13.0.3 release (#44332) PR Close #44332 01 December 2021, 21:05:16 UTC
0c9d33c George Kalpakas 30 November 2021, 22:08:01 UTC refactor(docs-infra): replace use of deprecated `Compiler` with `createNgModuleRef()` (#44293) Remove a use of the deprecated `Compiler` class in `ElementsLoader` and use the `createNgModuleRef()` function instead. PR Close #44293 01 December 2021, 19:56:47 UTC
98c1d91 George Kalpakas 30 November 2021, 22:08:01 UTC refactor(docs-infra): remove obsolete ViewEngine code path from `ElementsLoader` (#44293) Remove a code path that was only reached in ViewEngine mode and is now (with the removal of ViewEngine) obsolete. PR Close #44293 01 December 2021, 19:56:47 UTC
a18b117 Renovate Bot 01 December 2021, 06:00:33 UTC build: update dependency saucelabs to v7 (#44321) PR Close #44321 01 December 2021, 19:56:13 UTC
98430d6 Andrew Kushnir 24 November 2021, 19:24:05 UTC refactor(forms): minor refactoring of `SelectMultipleControlValueAccessor` (#44261) This commit updates the code of the `SelectMultipleControlValueAccessor` to: - improve typings to make them more precise - updates the note that refers to IE, but we still can not remove the branch since it's needed for Universal (that uses Domino) PR Close #44261 30 November 2021, 21:43:11 UTC
264aad9 Andrew Scott 30 November 2021, 17:55:05 UTC ci: Update availability for pullapprove (#44312) Follows the v3 pullapprove docs here: https://docs.pullapprove.com/config/availability/ PR Close #44312 30 November 2021, 21:41:53 UTC
53bdf11 Ramesh Thiruchelvam 29 November 2021, 08:42:00 UTC docs(forms): add an example for async validator token (#44301) to be consistent with the validator token, have the example code for the async validator token. PR Close #44301 30 November 2021, 19:24:27 UTC
277390e Ramesh Thiruchelvam 19 November 2021, 02:25:40 UTC refactor(core): make the error messages tree shakable (#44219) Long error messages can be tree-shaken in the production build. Doing this, we will keep the throw and remove the long error messages. See: https://github.com/angular/angular/pull/44210#pullrequestreview-810615849 PR Close #44219 30 November 2021, 19:17:39 UTC
66b73d4 Ruslan Usmanov 27 November 2021, 17:04:58 UTC refactor(forms): eagerly initialize data members (#44292) Data members in AbstractControl should be eagerly initialized to address issue/24571. This eliminates the need to constantly check for truthiness and makes code much more readable. More PRs to follow to address issue/24571. PR Close #44292 30 November 2021, 19:15:16 UTC
a297e87 Joey Perrott 30 November 2021, 18:42:57 UTC release: bump angular-in-web-memory-api package to 0.13.0 (#44313) PR Close #44313 30 November 2021, 19:12:51 UTC
c92095c Kristiyan Kostadinov 25 November 2021, 12:17:35 UTC refactor(docs-infra): clean up entryComponents usages (#44257) Cleans up some usages of `entryComponents` from AIO. PR Close #44257 30 November 2021, 18:49:46 UTC
df874b4 Joey Perrott 29 November 2021, 19:24:30 UTC ci: update owners for fw-benchmarks (#44304) Add alxhub and jelbourn to owners for fw-benchmarks group. PR Close #44304 30 November 2021, 18:45:59 UTC
f702c92 Paul Gschwendtner 30 November 2021, 17:14:01 UTC build: fix lint errors in build-saucelabs legacy script (#44311) Fixes lint errors in the build-saucelabs legacy script. Likely this only surfaces now after merge due to some other lint-affecting changes landing just before the script landed. PR Close #44311 30 November 2021, 17:23:24 UTC
2ee95b3 Paul Gschwendtner 27 November 2021, 13:51:25 UTC ci: increase jasmine default timeout for saucelabs legacy tests (#44281) Previously, when we did not bundle tests, we also had the jasmine default timeout increased to 15000ms. This commit re-introduces this increased timeout by also maintaining a custom test init file for the legacy saucelab jobs. This is desirable as all of the Saucelabs test code is local in the `tools/legacy-saucelabs` folder. PR Close #44281 30 November 2021, 16:56:06 UTC
e69025c Paul Gschwendtner 27 November 2021, 13:50:49 UTC test: remove unused router karma legacy setup (#44281) Removes unused router karma legacy test setup that just caused unnecessary confusion. PR Close #44281 30 November 2021, 16:56:06 UTC
6cdbfdb Paul Gschwendtner 26 November 2021, 20:33:35 UTC fix(compiler-cli): downlevel transform incorrectly extracting constructor parameters for nested classes (#44281) The downlevel decorator transform (commonly used in the CLI and other tooling of the ecosystem for enabling JIT ES2015+), is currently incorrectly dealing with nested classes. The transform will accidentally visit nested classes (in a constructor) multiple times and generate duplicated instances of the `ctorParameters` fields. This does not sound like an issue at first, but the duplicated `ctorParameters` fields will miss significant type information that has been elided by the first visit, resulting in generated code like the following: ```js let MyClass = /* @__PURE__ */ __name(class MyClass extends UpgradeNg1ComponentAdapter { constructor(scope, injector3, elementRef) { } }, "MyClass"); MyClass.ctorParameters = () => [ { type: void 0, decorators: [{ type: Inject, args: [$SCOPE] }] }, { type: Injector }, { type: ElementRef } ]; MyClass.ctorParameters = () => [ { type: void 0 }, // <---- NOTE! { type: Injector }, { type: ElementRef } ]; ``` PR Close #44281 30 November 2021, 16:56:06 UTC
108844d Paul Gschwendtner 26 November 2021, 20:12:55 UTC test: re-add downlevel decorator transform test (#44281) Re-adds the accidentally deleted downlevel decorator transform test. PR Close #44281 30 November 2021, 16:56:06 UTC
907da39 Paul Gschwendtner 26 November 2021, 18:28:39 UTC fix(core): destroy hooks not set up for `useClass` provider using `forwardRef` (#44281) Fixes an issue where destroy hooks are not set up for `useClass` providers that rely on `forwardRef` for passing the actual class reference. Currently the destroy hooks are not captured because forward refs are not resolved for class providers. In ES2015+ this issue becomes even more critical if arrow-functions are used for e.g. `useClass: () => forwardRef(..)`. This is because arrow functions do not have a prototype, unlike in ES5 where the function assigned to `useClass` would always have a prototype. In ES2015+ a runtime exception as followed is returned (and doesn't give any useful indication of the forwardRef issue): ``` TypeError: Cannot read properties of undefined (reading 'ngOnDestroy') at registerDestroyHooksIfSupported (dist/packages/core/src/render3/di_setup.ts:196:35 <- dist/legacy-test-bundle.spec.js:41508:37) at resolveProvider (dist/packages/core/src/render3/di_setup.ts:153:9 <- dist/legacy-test-bundle.spec.js:41485:11) at resolveProvider (dist/packages/core/src/render3/di_setup.ts:70:7 <- dist/legacy-test-bundle.spec.js:41445:9) at providersResolver (dist/packages/core/src/render3/di_setup.ts:54:5 <- dist/legacy-test-bundle.spec.js:41438:7) at Object.definition.providersResolver (dist/packages/core/src/render3/features/providers_feature.ts:48:18 <- dist/legacy-test-bundle.spec.js:41600:16) at resolveDirectives (dist/packages/core/src/render3/instructions/shared.ts:1179:40 <- dist/legacy-test-bundle.spec.js:35611:17) at elementStartFirstCreatePass (dist/packages/core/src/render3/instructions/element.ts:40:7 <- dist/legacy-test-bundle.spec.js:38432:27) at ɵɵelementStart (dist/packages/core/src/render3/instructions/element.ts:87:7 <- dist/legacy-test-bundle.spec.js:38453:43) at ɵɵelement (dist/packages/core/src/render3/instructions/element.ts:180:3 <- dist/legacy-test-bundle.spec.js:38510:5) at MultipleFormControls_Template (ng:///MultipleFormControls.js:9:9) ``` PR Close #44281 30 November 2021, 16:56:05 UTC
595d647 Paul Gschwendtner 26 November 2021, 14:24:04 UTC build: bundle spec files for saucelabs legacy job (#44281) Bundle spec files similar to how it is done within the Angular Components repo. This should simplify the setup and also speed up the Saucelab job as only a single spec bundle would need to be downloaded, compared to having to load hundreds of files through the Saucelabs tunnel. Also makes a couple of tests more robust with the emulators/and accounts for ES2015 test runner changes. The tests should be less reluctant to such build process changes. Note for reviewers: Some imports have been simplified here. This work came from Joey's original WIP for this. It's unclear to me whether this is still needed, but it sounded like this was necessary for the ESBuild bundling to work. I have robusted the module resolution plugin though, so I doubt it's still needed. At the same time though: Not worth reverting/trying as these changes are nice to have anyway! Co-Authored-By: Joey Perrott <josephperrott@gmail.com> Co-Authored-By: Paul Gschwendtner <paulgschwendtner@gmail.com> PR Close #44281 30 November 2021, 16:56:05 UTC
6d16255 Paul Gschwendtner 25 November 2021, 19:07:49 UTC ci: attempt to increase stability of saucelabs legacy job (#44281) This is an attempt to increase the stability of the Saucelabs legacy job by using an emulator recommended by the Saucelabs platform configurator, explicitly specifying the appium server version etc. PR Close #44281 30 November 2021, 16:56:05 UTC
cabc178 Andrew Scott 24 November 2021, 21:27:29 UTC fix(language-service): Correctly parse inputs and selectors with dollar signs (#44268) When we are going to the definition of an input, we find _both_ the definition of the input _and_ also look for any directives which have a selector that matches the input. For example: ``` @Directive({ selector: '[greeting]' }) export class MyDir { @Input() greeting!: string; } ``` With this commit, we now correctly handle the case where inputs and/or selectors have a dollar sign in them. The dollar sign has special meaning in CSS, but when we encounter the dollar in a template, we need to escape it when used as a selector so that it is taken as a dollar literal rather than a character with special meaning. Previously, we were not escaping the dollar sign and the CSS parsing logic would throw an error. The change in this commit prevents that error from happening, but a `try...catch` is still added in case there is another unhandled use-case. If this happens, we do not want the `goToDefinition` operation to completely fail. Fixes https://github.com/angular/vscode-ng-language-service/issues/1574 PR Close #44268 29 November 2021, 22:22:13 UTC
0b20ed6 dario-piotrowicz 25 November 2021, 11:21:50 UTC docs: fix instructions for debugging a karma test (#44244) PR Close #44244 29 November 2021, 22:21:42 UTC
efd329f George Kalpakas 25 November 2021, 19:18:58 UTC fix(docs-infra): fix the main content layout (#44282) Fix the layout of the main docs content on both small and large screens. On small screens, content could overlap with the floating ToC, while on large screens the content was not centered correctly (see screenshots below). (For reference, this was accidentally broken in #44236.) **Before:** - ![content on small screen before](https://user-images.githubusercontent.com/8604205/143491577-97255ee7-f79d-4c95-9287-ff2afeb5b29d.png) - ![content on large screen before](https://user-images.githubusercontent.com/8604205/143491582-2c19f7a2-d5ad-475a-a58b-e449efc492a9.png) **After:** - ![content on small screen after](https://user-images.githubusercontent.com/8604205/143491580-a405f650-cd4a-4804-8e65-422fc91f4c6e.png) - ![content on large screen after](https://user-images.githubusercontent.com/8604205/143491585-d0d2e914-a1a2-45ba-8e6b-b9546aa80354.png) PR Close #44282 29 November 2021, 22:21:14 UTC
1d0b54a George Kalpakas 26 November 2021, 17:46:30 UTC test(ngcc): use `main` property in test `package.json` files for UMD tests (#44245) Previously, the mock packages created for `UmdDependencyHost`'s tests, specified the entry-point as `esm2015`. This does not matter in tests, since the packages are explicitly passed to the `UmdDependencyHost` (while in reality the appropriate host would be determined based on the name of the entry-point property - in this case, detecting the entry-point as ES2015 and not UMD). However, in order to avoid confusion, this commit updates the test packages to use `main` (the default property used for the UMD format in `package.json` files). PR Close #44245 29 November 2021, 17:38:06 UTC
b68994d George Kalpakas 26 November 2021, 17:46:29 UTC fix(ngcc): correctly report error when collecting dependencies of UMD module (#44245) Previously, the ngcc `UmdReflectionHost` would throw a misleading error when trying to collect dependencies of an invalidly formatted UMD module. This happened because an error would be thrown while trying to construct the error message for the actual error, by calling `getText()` on certain TypeScript AST nodes. See https://github.com/angular/angular/issues/44019#issuecomment-959954121 for a more in-depth explanation. This commit ensures `getText()` can be safely called on TypeScript AST nodes when collecting dependencies of UMD modules. PR Close #44245 29 November 2021, 17:38:06 UTC
41562a5 George Kalpakas 26 November 2021, 17:46:28 UTC test(ngcc): run more tests against more supported UMD formats (#44245) This commit utilizes the infrastructure added in the previous commit to run more tests against more of the supported UMD formats. This shall give us more confidence that all aspects of UMD processing work correctly with the various formats. PR Close #44245 29 November 2021, 17:38:06 UTC
5daa34f George Kalpakas 26 November 2021, 17:46:28 UTC test(ngcc): use helper function for generating UMD modules for tests (#44245) Previously, several ngcc test suites used their own helper to generate test UMD modules. This commit switches to using the same helper for generating UMD modules across test suites. This improves DRYness (ensuring changes/fixes to the UMD format need only be applied once) and makes it easier to test different UMD formats in all test suites. PR Close #44245 29 November 2021, 17:38:06 UTC
bf5f734 George Kalpakas 26 November 2021, 17:46:27 UTC fix(ngcc): support the UMD wrapper function format emitted by Webpack (#44245) Previously, ngcc could only handle UMD modules whose wrapper function was implemented as a `ts.ConditionalExpression` (i.e. using a ternary operator). This is the format emitted by popular bundlers, such as Rollup. This commit adds support for a different format, that uses `if/else` statements, which is what is [emitted by Webpack][1]. [1]: https://webpack.js.org/configuration/output/#type-umd Fixes #44019 PR Close #44245 29 November 2021, 17:38:06 UTC
d1d7a80 George Kalpakas 26 November 2021, 17:46:27 UTC refactor(ngcc): make it easy to support more UMD wrapper function formats (#44245) Previously, ngcc could only handle UMD modules whose wrapper function was implemented as a `ts.ConditionalExpression` (i.e. using a ternary operator). This is the format emitted by popular bundlers, such as Rollup. However, this failed to account for a different format, using `if/else` statements, such as the one [emitted by Webpack][1]. This commit prepares ngcc for supporting different UMD wrapper function formats by decoupling the operation of parsing the wrapper function body to capture the various factory function calls and that of operating on the factory function calls (for example, to read or update their arguments). In a subsequent commit, this will be used to add support for the Webpack format. [1]: https://webpack.js.org/configuration/output/#type-umd PR Close #44245 29 November 2021, 17:38:06 UTC
90db2b0 dario-piotrowicz 24 November 2021, 20:48:43 UTC fix(docs-infra): add safari-only media query for aio footer flex (#44266) safari handles rem based media queries differently so in order to provide a similar user-experience to safari users, add a new safari-only media query for the footer's flex container resolves #44242 PR Close #44266 29 November 2021, 17:37:44 UTC
2a7e577 JoostK 24 November 2021, 21:01:26 UTC refactor(platform-browser-dynamic): remove private export of `ResourceLoaderImpl` (#44267) This type was exported for the ViewEngine compiler as it needed to reference the class in its DI codegen. This is no longer a requirement with Ivy, hence the private export can be removed. This change prevents an import of `@angular/compiler` to be referenced in the .d.ts file of `@angular/platform-browser-dynamic`, which is beneficial for application compilations as that prevents the `@angular/compiler` .d.ts files from being included in the `ts.Program` of an application. Closes #44157. PR Close #44267 29 November 2021, 17:37:00 UTC
101b2cc Pete Bacon Darwin 25 November 2021, 09:23:26 UTC fix(docs-infra): ensure deprecated styling is not overridden (#44275) The `.code-anchor` styling was overriding the `.deprecated-api-item` styling. The `text-decoration` is not needed on `.code-anchor` since it inherits this from the `a` rule in the typography.scss file. Fixes #44264 PR Close #44275 29 November 2021, 17:36:23 UTC
63d8cd7 Kristiyan Kostadinov 25 November 2021, 11:05:42 UTC test(core): clean up tests relying on entryComponents (#44276) Cleans up all the tests that had to declare a separate module in order to pass in `entryComponents` when creating components dynamically. This covers almost all of the `entryComponents` usages, except for a few which I've left for now, because they're testing some of the existing leftover `entryComponents` logic in core. PR Close #44276 29 November 2021, 17:36:05 UTC
b13be73 Christian-E 28 November 2021, 20:57:41 UTC docs: fix filename of the file containing the 'routes'-array in lazy loading guide (#44297) PR Close #44297 29 November 2021, 17:35:45 UTC
dcea04b Andrew Kushnir 09 November 2021, 02:20:56 UTC test: remove Ivy/ViewEngine switch helpers and obsolete tests (#44120) (#44262) This commit removes special functions that were used to run tests in ViewEngine or Ivy only. Since ViewEngine is deprecated and we no longer run ViewEngine tests on CI, we can cleanup those special helpers and ViewEngine-only tests. PR Close #44120 PR Close #44262 24 November 2021, 20:10:01 UTC
5119be4 JoostK 30 October 2021, 21:25:49 UTC refactor(ngcc): remove Ivy switch marker transform (#43891) ngcc used to rewrite `PRE_R3` markers to become `POST_R3` in order to switch the runtime implementation in `@angular/core` from View Engine to Ivy. Now that `@angular/core` is published as native Ivy package and the runtime switch code has been removed, there is no need for ngcc to perform this transform anymore. PR Close #43891 24 November 2021, 19:26:25 UTC
b281a03 JoostK 19 October 2021, 17:03:48 UTC refactor(compiler-cli): remove Ivy switch transform (#43891) Now that the core package has been cleaned up to no longer contain Ivy switch code, the transform to switch the `PRE_R3` markers to become `POST_R3` is deleted as well. PR Close #43891 24 November 2021, 19:26:25 UTC
0ca5c5b Rohan Pednekar 05 November 2021, 13:48:14 UTC fix(core): add missing info about a component in the "pipe could not be found" error message (#44081) Add error handling for pipe with component class name in which it has a problem. Add it in ngDevMode, so that it will be a tree-shake away from the production bundle. PR Close #44081 24 November 2021, 18:57:11 UTC
db5bcbb Doug Parker 10 November 2021, 23:50:55 UTC docs: document `ng update` support guarantees (#44142) PR Close #44142 24 November 2021, 18:56:32 UTC
b8dd936 Pei Wang 18 November 2021, 02:19:19 UTC ci: Upgrade tsec to 0.2.0. (#44205) tools/tsec.bzl is now part of tsec. Remove from Angular repo and update BUILD.bazel files. PR Close #44205 24 November 2021, 18:55:58 UTC
6afcc2f Joey Perrott 18 November 2021, 18:25:37 UTC build: update repository to node@16 locally (#44211) As node 16 is now active LTS, updating to node 16 is a better choice for our own development. Notably its support for M1 chips is an important value add for us. PR Close #44211 24 November 2021, 18:55:33 UTC
0ba7776 Joey Perrott 18 November 2021, 22:47:29 UTC test(common): change fallback default URL in MockPlatformLocation (#44211) In node@16 the URL constructor fails for for a malformed URL such as http://<empty>/. Instead http://_empty_ is used as this conveys the same information in tests but is correctly formed. PR Close #44211 24 November 2021, 18:55:33 UTC
92a6584 dario-piotrowicz 18 November 2021, 22:59:01 UTC docs(animations): remove incorrect information regarding animateChild (#44216) Remove incorrect information present in the angular.io animations documentation stating that animateChild does not work with route transition animations as that turned out not to be true This PR effectively reverts the changes make in PR: #44014 For more context see issue #30477 PR Close #44216 24 November 2021, 18:54:22 UTC
d0dcea1 dario-piotrowicz 10 November 2021, 21:38:52 UTC docs(core): improve viewEncapsulation documentation (#44151) Slighlty improve the `viewEncapsulation` documentation (both in code comments and content files) to make it more clear and understandable. See https://github.com/angular/angular/pull/44099#discussion_r745890903 PR Close #44151 24 November 2021, 18:53:45 UTC
b9362f0 dario-piotrowicz 19 November 2021, 22:26:57 UTC fix(docs-infra): move aio footer inside mat-sidenav-container (#44236) currently the aio footer sits outside the mat-sidenav-container, as a result when the mat-sidenav in over mode appears, the footer is not placed under the sidenav backdrop, move the footer inside the mat-sidenav-container so that it does PR Close #44236 24 November 2021, 17:04:01 UTC
4fb53b6 Artur 24 November 2021, 13:26:39 UTC docs: fix issue link in v13 release notes (#44258) See: #44181 PR Close #44258 24 November 2021, 17:02:57 UTC
62c97b4 Jessica Janiuk 24 November 2021, 00:38:00 UTC ci: add jessicajaniuk to pullapprove groups (#44255) This adds jessicajaniuk to fw-animations and fw-testing. PR Close #44255 24 November 2021, 17:02:30 UTC
84ef01d Alex Rickabaugh 09 November 2021, 19:02:39 UTC refactor: delete the View Engine runtime (#44218) This commit removes the View Engine runtime. Itself, this change is relatively straightforward, but it represents the final step in a multi-year journey. It's only possible due to the hard work of many current and former team members and collaborators, who are too numerous to list here. Co-authored-by: Alan Agius <alan.agius4@gmail.com> Co-authored-by: Andrew Kushnir <akushnir@google.com> Co-authored-by: Andrew Scott <atscott01@gmail.com> Co-authored-by: Andrew Seguin <andrewjs@google.com> Co-authored-by: Cédric Exbrayat <cedric@ninja-squad.com> Co-authored-by: Charles Lyding <19598772+clydin@users.noreply.github.com> Co-authored-by: Dave Shevitz <dshevitz@google.com> Co-authored-by: Doug Parker <dgp1130@users.noreply.github.com> Co-authored-by: Dylan Hunn <dylhunn@gmail.com> Co-authored-by: Emma Twersky <emmatwersky@google.com> Co-authored-by: George Kalpakas <kalpakas.g@gmail.com> Co-authored-by: Igor Minar <iminar@google.com> Co-authored-by: Jeremy Elbourn <jelbourn@google.com> Co-authored-by: Jessica Janiuk <jessicajaniuk@google.com> Co-authored-by: JiaLiPassion <JiaLi.Passion@gmail.com> Co-authored-by: Joey Perrott <josephperrott@gmail.com> Co-authored-by: Joost Koehoorn <joost.koehoorn@gmail.com> Co-authored-by: Kristiyan Kostadinov <crisbeto@abv.bg> Co-authored-by: Madleina Scheidegger <mscheid@google.com> Co-authored-by: Mark Thompson <2554588+MarkTechson@users.noreply.github.com> Co-authored-by: Minko Gechev <mgechev@gmail.com> Co-authored-by: Paul Gschwendtner <paulgschwendtner@gmail.com> Co-authored-by: Pawel Kozlowski <pkozlowski.opensource@gmail.com> Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com> Co-authored-by: Wagner Maciel <wagnermaciel@google.com> Co-authored-by: Zach Arend <zachzach@google.com> PR Close #44218 24 November 2021, 00:04:24 UTC
5445c2d Alex Rickabaugh 02 November 2021, 21:39:52 UTC build: remove view engine build infrastructure (#44218) This commit removes --config=viewengine and makes Ivy the default for building Angular. PR Close #44218 24 November 2021, 00:04:24 UTC
1f6fa26 Alex Rickabaugh 09 November 2021, 18:59:21 UTC test: remove view-engine-only tests (#44218) This commit removes most tests that were designated as only covering View Engine code. It also removes tag filters from CI and local commands to run tests. In a few cases (such as with the packages/compiler tests), this tag was improperly applied, and certain test cases have been added back running in Ivy mode. This commit also empties `@angular/compiler/testing` as it is no longer necessary (this is safe since compiler packages are not public API). It can be deleted in the future. PR Close #44218 24 November 2021, 00:04:24 UTC
d265d0d unknown 20 November 2021, 23:13:53 UTC fix(router): prevent componentless routes from being detached (#44240) Currently, when deactivating a route, the detach method of the RouteReuseStrategy is always called even when we are dealing with a componentless route. If when using a custom strategy we attempt to detach a componentless route, an exception is thrown causing the navigation to break. This change prevents this from happening, by not triggering the detach of the route reuse strategy. Fixes #44239 PR Close #44240 23 November 2021, 17:12:28 UTC
1beda66 Ramesh Thiruchelvam 18 November 2021, 17:21:09 UTC refactor(core): clean up isDevMode for tree-shaking (#44210) Removing the usage of isDevMode with ngDevMode flag. This will make the dev-mode code tree-shakable from the production builds. PR Close #44210 23 November 2021, 17:11:59 UTC
b8bee24 Renovate Bot 19 November 2021, 11:32:21 UTC build: update dependency source-map-support to v0.5.21 (#44225) PR Close #44225 23 November 2021, 17:10:59 UTC
0c1a142 Renovate Bot 21 November 2021, 00:25:38 UTC build: update angular (#44241) PR Close #44241 23 November 2021, 17:10:24 UTC
28d7e64 George Kalpakas 23 November 2021, 08:49:40 UTC build(docs-infra): upgrade cli command docs sources to 1390fc8c9 (#44251) Updating [angular#13.0.x](https://github.com/angular/angular/tree/13.0.x) from [cli-builds#13.0.x](https://github.com/angular/cli-builds/tree/13.0.x). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/afd86f0cd...1390fc8c9): **Modified** - help/new.json PR Close #44251 23 November 2021, 17:09:23 UTC
d9c99f7 Renovate Bot 22 November 2021, 17:50:48 UTC build: update dependency @angular-eslint/eslint-plugin-template to v13 (#44224) PR Close #44224 22 November 2021, 20:18:00 UTC
6f5c0c1 Pete Bacon Darwin 19 November 2021, 13:17:24 UTC fix(ngcc): ensure that ngcc does not write a lock-file into node_modules package directories (#44228) When executing, ngcc writes a lock-file that is used to coordinate multiple concurrent instances of ngcc. Previously, this file was written at `node_modules/@angular/compiler-cli/ngcc`, or similar depending upon the bundling of the package. But this causes problems for setups where `node_modules` package directories are expected to be read-only. Now, the lock-file is written as `.ngcc_lock_file` into the top of the `node_modules`, which is an acceptable place to store transient files. This change should help to unblock use of tools like pnpm and lerna, which can use symlinks to readonly package directories. PR Close #44228 22 November 2021, 17:55:13 UTC
67aa0c1 George Kalpakas 18 November 2021, 20:05:21 UTC refactor(elements): remove unneeded Custom Elements polyfill from docs examples (#44214) (#44233) In PR #43975, the `Angular Elements` guide was updated to remove mentions of the Custom Elements-related polyfills, since they are no longer necessary in v13+ (due to all CLI projects being ES2015+ and all supported browsers natively supporting Custom Elements). This commit updates the related docs example boilerplate to not include the unneeded `@webcomponents/custom-elements` polyfill. PR Close #44214 PR Close #44233 22 November 2021, 17:37:01 UTC
70cfbcc George Kalpakas 18 November 2021, 19:57:54 UTC docs(docs-infra): remove obsolete mention of skipping HTTPS-related audits (#44214) (#44233) Since commit 6e405513942f675c6c64ff4cb4a62e0df649e26a, the `audit-web-app` script no longer needs to skip HTTPS-related audits. Update the docs comment to reflect that. PR Close #44214 PR Close #44233 22 November 2021, 17:37:01 UTC
a643649 Renovate Bot 19 November 2021, 18:53:47 UTC build: update dependency @angular-eslint/eslint-plugin to v13 (#44223) PR Close #44223 22 November 2021, 17:36:00 UTC
76adfc0 David Shevitz 05 November 2021, 22:59:54 UTC docs: add two new overview pages: developer-guide-overview and understanding-angular-overview (#44091) PR Close #44091 20 November 2021, 00:12:10 UTC
3289aae Doug Parker 01 October 2021, 23:43:23 UTC refactor(bazel): always add `strictTemplates` option to `tsconfig.json` (#43674) `strictTemplates` was only conditionally added to the `tsconfig.json` file to avoid breaking the angular/components repo (see https://github.com/angular/angular/pull/43582#issuecomment-928567758). Components has been updated in https://github.com/angular/components/pull/23677, so this condition is no longer necessary and `strictTemplates` can always be included in `tsconfig.json` without breakage. PR Close #43674 19 November 2021, 22:28:03 UTC
d09857f Douglas Parker 15 November 2021, 19:43:24 UTC docs: add dynamic `import()` ES module change to v13 release notes (#44181) Closes angular/angular-cli#22159. See: https://github.com/angular/angular-cli/issues/22159#issuecomment-969251924 PR Close #44181 19 November 2021, 22:27:40 UTC
6e351ed Renovate Bot 19 November 2021, 09:01:29 UTC build: update angular (#44221) PR Close #44221 19 November 2021, 19:44:55 UTC
69f25bd dario-piotrowicz 09 November 2021, 23:52:22 UTC fix(docs-infra): remove negative margin (#44126) remove the top padding for the homepage article, instead of having that top padding and moving the element up via a negative bottom margin in the intro section note: the result is identical except for when the article's media query is applied, the difference is barely noticeable anyways PR Close #44126 19 November 2021, 19:32:29 UTC
541a87d dario-piotrowicz 09 November 2021, 22:34:34 UTC fix(docs-infra): fix aio homepage breaking on certain widths (#44126) the aio homepage has a fixed width for its hero content, that is not handling well certain window widths, fix that by removing the fixed width and tweaking related media queries PR Close #44126 19 November 2021, 19:32:29 UTC
305b76b Kristiyan Kostadinov 14 November 2021, 08:35:42 UTC fix(compiler-cli): interpret string concat calls (#44167) These changes add support for interpreting `String.prototype.concat` calls. We need to support it, because in TypeScript 4.5 string template expressions are transpiled to `concat` calls, rather than string concatenations. See https://github.com/microsoft/TypeScript/pull/45304. PR Close #44167 19 November 2021, 19:30:59 UTC
0abc006 Kristiyan Kostadinov 18 November 2021, 08:38:13 UTC refactor(core): clean up leftover isDevMode usages (#44208) Removes a couple of leftover calls to `isDevMode`. PR Close #44208 19 November 2021, 19:30:20 UTC
bcd3b49 JoostK 18 November 2021, 22:44:06 UTC fix(core): support cyclic metadata in TestBed overrides (#44215) The TestBed APIs to override metadata would crash when the metadata contained objects with cyclic references. Metadata overrides use the JSON serialized representation of a value to compare objects, which throws an error if the value has cyclic references. This commit avoids the error by replacing multiple occurrences of the same object using a unique string representation for the object. Fixes #43948 PR Close #44215 19 November 2021, 19:27:08 UTC
2c9940c Renovate Bot 19 November 2021, 09:06:18 UTC build: update dependency @angular-eslint/builder to v13 (#44222) PR Close #44222 19 November 2021, 18:43:59 UTC
dbe4a36 Renovate Bot 19 November 2021, 10:11:37 UTC build: update dependency @angular-eslint/template-parser to v13 (#44226) PR Close #44226 19 November 2021, 18:43:11 UTC
427822e dario-piotrowicz 06 November 2021, 17:54:32 UTC refactor(animations): improve some animations comments (#44203) Fix various typos and also improve sentences (by making them more clear or grammatically correct) present in comments inside the animations package PR Close #44203 18 November 2021, 21:12:54 UTC
16d026e Dylan Hunn 17 November 2021, 23:29:23 UTC ci: add dylhunn to review groups for forms. (#44204) This is needed so I can review forms PRs that affect public API. PR Close #44204 18 November 2021, 18:24:30 UTC
b61c2be Ravi Chandra 17 November 2021, 19:35:21 UTC docs: remove tslint references from file structure document (guide/file-structure) (#44202) remove tslint references from the file structure documentation as angular cli no more generates tslint configuration files by default Fixes #44163 PR Close #44202 18 November 2021, 18:21:32 UTC
eedb88b Renovate Bot 16 November 2021, 09:30:55 UTC build: update dependency lighthouse to v9 (#44184) PR Close #44184 18 November 2021, 18:20:39 UTC
210a646 Paul Gschwendtner 18 November 2021, 13:55:50 UTC build: update extract js module output target to reflect latest API changes (#44145) The API of the `extract_js_module_output` rule has changed with the latest build of the shared dev-infra package. This commit adds the missing attributes to the targets using this rule, avoiding the CI failures as these attributes are mandatory. Note: For NPM packages the linker mappings are not relevant, neither do we want to include sources from the external NPM packages inside those. PR Close #44145 18 November 2021, 18:17:16 UTC
76f390b Renovate Bot 18 November 2021, 01:52:52 UTC build: update angular (#44145) PR Close #44145 18 November 2021, 18:17:16 UTC
96fedd2 Andrew Kushnir 15 November 2021, 22:17:39 UTC fix(forms): make the `FormControlStatus` available as a public API (#44183) This commit makes the `FormControlStatus` symbol available as a public API. The symbol itself was intended to become a part of the public API, but due to the missing re-export, the symbol remains private. Fixes #44176. PR Close #44183 17 November 2021, 18:37:28 UTC
150a0b7 Andrew Kushnir 26 October 2021, 04:15:41 UTC refactor(forms): inherit `ngOnChanges` hooks from the base class (#43945) This commit updates the code of the min/max and minlength/maxlength validator directives to inherit `ngOnChanges` hooks from the base class (the `AbstractValidatorDirective` one), rather than implementing the hooks on the child classes. This was needed to avoid issues with hooks inheritance in ViewEngine, but since it's deprecated, the code can be cleaned up. PR Close #43945 17 November 2021, 18:36:40 UTC
9ab1975 Alan Agius 17 November 2021, 13:03:20 UTC ci: remove `cla/google` from required statues (#44197) The CLA tools no longer report statuses as it is being run as Github actions. PR Close #44197 17 November 2021, 18:35:11 UTC
516570c Marc Redemske 16 November 2021, 20:54:58 UTC docs: remove redudant word in goldens/README.md (#44192) PR Close #44192 17 November 2021, 18:34:09 UTC
fa46db8 profanis 11 November 2021, 10:24:53 UTC docs: add profanis to GDE resources (#44147) PR Close #44147 17 November 2021, 18:32:26 UTC
c25927d Andrew Kushnir 17 November 2021, 17:35:20 UTC release: cut the v13.0.2 release (#44199) 17 November 2021, 17:35:20 UTC
158ad09 fusho-takahashi 24 September 2021, 22:14:53 UTC docs: Adding type annotation to ngOnInit() to make it consistent with the class structure produced by the CLI (#43579) PR Close #43579 16 November 2021, 22:09:52 UTC
f218644 Armen Vardanyan 21 October 2021, 09:22:30 UTC docs: add armen vardanyan to GDE resources (#43919) PR Close #43919 16 November 2021, 22:09:01 UTC
89678d1 Joey Perrott 16 November 2021, 20:59:59 UTC build: update to latest commit for feature-request github action (#44191) Updating as this fixes a permissions error. PR Close #44191 16 November 2021, 22:08:24 UTC
dcf0352 Andrew Kushnir 16 November 2021, 20:37:31 UTC ci: update pullapprove.yml (#44193) This commit updates the PullApprove config, since Zach is currently focused on improving Components. PR Close #44193 16 November 2021, 22:07:19 UTC
00a16e4 Paul Gschwendtner 16 November 2021, 15:23:53 UTC refactor(elements): remove non-existent schematic collection breaking with `ng add` (#44187) Removes a non-existent schematic collection wired up for `@angular/elements` that has been removed with: https://github.com/angular/angular/commit/619b7cc3857b34598a0036f8ebf9bc2eb27f5507. Fixes #44160. PR Close #44187 16 November 2021, 20:03:42 UTC
fe4845b Dylan Hunn 16 November 2021, 18:10:13 UTC ci: add dylhunn to review groups for size, piblic api, minimum, and circular (#44190) This is needed so I can review forms PRs that affect public API. PR Close #44190 16 November 2021, 20:02:15 UTC
aa98cf1 dario-piotrowicz 14 November 2021, 10:38:28 UTC docs(animations): improve wording for animation example (#44168) improve the wording of the text explaining an animation code snippet as that can be misinterpreted resolves #43952 PR Close #44168 16 November 2021, 17:45:14 UTC
83d2284 Ramesh Thiruchelvam 14 November 2021, 14:40:56 UTC test: type spy objects in test example (#44170) Example for test doesn't use typing for Jasmine Spy objects. Updated them with `SpyObj<T>` typing as in the Angular Documentation. See https://angular.io/guide/testing-services PR Close #44170 16 November 2021, 17:38:43 UTC
1d14800 Martin von Gagern 08 November 2021, 09:23:15 UTC refactor(router): add type annotation for UrlSegment.parameterMap (#44175) Having the type specified explicitly makes the API reference more readable. PR Close #44175 16 November 2021, 17:36:18 UTC
7115e83 Joey Perrott 15 November 2021, 18:59:23 UTC ci: remove `cla: yes` from required labels (#44179) Remove `cla: yes` from the require labels for merging as the CLACheck tool no longer relies on labels. Enforcement of the CLA being signed is still enforced by the status check which is visible both in Github as well as checked by merge tooling. PR Close #44179 15 November 2021, 19:21:56 UTC
40a2dad Pete Bacon Darwin 12 November 2021, 14:15:08 UTC build: add instructions for getting Angular version for bug report (#44159) The template asked for the Angular version but did not say how to get it. Closes #44158 PR Close #44159 15 November 2021, 19:21:06 UTC
1f9ec1c Joey Perrott 11 November 2021, 18:04:31 UTC build: update to yarn v1.22.17 (#44150) Update to the latest version of yarn, 1.22.17. PR Close #44150 15 November 2021, 19:19:07 UTC
539d720 Andrew Scott 10 November 2021, 23:41:43 UTC release: cut the v13.0.1 release (#44139) 10 November 2021, 23:41:43 UTC
ca0873f Joey Perrott 10 November 2021, 22:53:31 UTC build: update to latest @angular/dev-infra-private to address issues related to verifying environment (#44138) Update to the latest package which properly checks if the running version of ng-dev is the version described in yarn lock. PR Close #44138 10 November 2021, 23:40:09 UTC
1ace7d4 Joey Perrott 10 November 2021, 23:01:06 UTC refactor: add space to satisfy formatting (#44134) Add return space to satisfy formatting for the file. PR Close #44134 10 November 2021, 23:33:11 UTC
9c47b77 Paul Gschwendtner 10 November 2021, 19:09:54 UTC build: sync all lock file and `package.json` updates from next with patch (#44134) With the goal of avoiding more conflicts with build changes that should go into both patch + next in general, this commit brings the lock files + `package.json` files from patch branch to the equivalent contents of the next branch, except for the actual `version` field. PR Close #44134 10 November 2021, 23:33:11 UTC
e4475e6 dario-piotrowicz 06 November 2021, 16:57:20 UTC refactor(core): move outdated comment to view.ts (#44099) remove the comment suggesting to use a const enum for ViewEncapsulation in the renderer3/definitions.ts file and add a similar comment in the view.ts file in which the enum is defined Note: the new comment does not contain the suggestion of changing `None` to `0` as it is unclear what benefits that would bring (for more info see: https://github.com/angular/angular/pull/44099#discussion_r744157686) PR Close #44099 10 November 2021, 20:42:20 UTC
back to top