Revision 258c8ad68769f8b1fa7e1bb760c8228169506dcd authored by Morten Stenshorne on 14 March 2018, 13:42:44 UTC, committed by Blink WPT Bot on 14 March 2018, 13:51:13 UTC
The LayoutBox associated with a block node will *normally* be the
containing block (on the legacy side) of its children (on the NG side),
but this isn't an invariant. Multicol and list item markers are
two examples.

Remove the kembo DCHECK, since it seems impossible to come up with a
complete list of exceptions to the rule (that the node's box should be
the containing block of the child nodes' boxes). Instead always get the
right containing block from legacy layout. Don't use that of the node.

With the DCHECK removed, a lot of tests stop crashing, and some just
start passing instead. One known effect of this change is that floats
that are direct children of multicol containers are painted correctly.
They used to be added to the float list of the multicol container,
rather than that of the flow thread, which caused two problems: paint
order (regular blocks got painted on top of them), and that they
appeared unfragmented (they just overflowed the multicol container
instead). Added a test for that.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I1ee926c39fbedfd52d87e9cf790996909914efb2
Reviewed-on: https://chromium-review.googlesource.com/960027
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543065}
1 parent 0d817ea
History
File Mode Size
.well-known
2dcontext
FileAPI
IndexedDB
WebCryptoAPI
WebIDL
accelerometer
accname
acid
ambient-light
annotation-model
annotation-protocol
annotation-vocab
apng
audio-output
background-fetch
battery-status
beacon
bluetooth
clear-site-data
client-hints
clipboard-apis
common
compat
conformance-checkers
console
content-security-policy
cookie-store
cookies
core-aam
cors
credential-management
css
custom-elements
device-memory
docs
dom
domparsing
domxpath
dpub-aam
dpub-aria
editing
encoding
encrypted-media
entries-api
eventsource
feature-policy
fetch
fonts
fullscreen
gamepad
geolocation-API
geolocation-sensor
graphics-aam
gyroscope
hr-time
html
html-imports
html-longdesc
html-media-capture
http
imagebitmap-renderingcontext
images
infrastructure
innerText
input-events
interfaces
intersection-observer
js
keyboard-lock
longtask-timing
magnetometer
mathml
media
media-capabilities
media-source
mediacapture-fromelement
mediacapture-image
mediacapture-record
mediacapture-streams
mediasession
mimesniff
mixed-content
navigation-timing
netinfo
notifications
offscreen-canvas
old-tests
orientation-event
orientation-sensor
page-visibility
paint-timing
payment-handler
payment-method-basic-card
payment-method-id
payment-request
performance-timeline
picture-in-picture
pointerevents
pointerlock
preload
presentation-api
proximity
quirks
referrer-policy
remote-playback
requestidlecallback
resize-observer
resource-timing
resources
screen-orientation
secure-contexts
selection
sensors
server-timing
service-workers
shadow-dom
speech-api
staticrange
storage
streams
subresource-integrity
svg
svg-aam
tools
touch-events
trusted-types
uievents
upgrade-insecure-requests
url
user-timing
vibration
visual-viewport
wai-aria
wake-lock
wasm
web-animations
web-nfc
web-share
webaudio
webauthn
webdriver
webgl
webmessaging
webrtc
websockets
webstorage
webusb
webvr
webvtt
webxr
workers
worklets
x-frame-options
xhr
.codecov.yml -rw-r--r-- 66 bytes
.gitignore -rw-r--r-- 334 bytes
.gitmodules -rw-r--r-- 519 bytes
.pyup.yml -rw-r--r-- 1.0 KB
.travis.yml -rw-r--r-- 3.7 KB
CONTRIBUTING.md -rw-r--r-- 1.6 KB
LICENSE.md -rw-r--r-- 5.1 KB
README.md -rw-r--r-- 15.2 KB
check_stability.ini -rw-r--r-- 524 bytes
config.default.json -rw-r--r-- 756 bytes
lint.whitelist -rw-r--r-- 54.1 KB
serve.py -rw-r--r-- 263 bytes
server-side.md -rw-r--r-- 8.1 KB
testharness_runner.html -rw-r--r-- 95 bytes
update-built-tests.sh -rwxr-xr-x 208 bytes
wpt -rwxr-xr-x 95 bytes
wpt.py -rw-r--r-- 15 bytes

README.md

back to top