Skip to main content

Browse the archive

Revision 2664bc2b3ef4ee5fd671f915828cfcc274a36c77 authored by Paul Gschwendtner on 20 November 2021, 16:23:07 UTC, committed by Alex Rickabaugh on 08 December 2021, 18:42:42 UTC 
test: switch integration tests from puppeteer/webdriver-manager to Bazel-managed chromium (#44238)
 
Switches the integration tests form Puppeteer/webdriver-manager to the
Bazel-managed Chromium/Chromedriver. This is now possible with the new
integration test rule for which we can consult the
`dev-infra/bazel/browsers` toolchain and setup environment variables.
This has been configured already in a previous commit.

This commit also includes some additional small cleanups necessary for
the new integration test rule:

* The `test.sh` scripts have been renamed as they would conflict with
  the `test.sh` scripts generated by the integration test rule.
  Previously this was not an issue because tests were declared at a
  higher-level. As mentioned though this has other downsides and it is
  trivial to rename the file.

* Related to the point above, since tests are now declared witin the
  actual test folder (for perf e.g.), `package.json` files setting
  `"type": "module"` will accidentally cause the `nodejs_test`-generated
  files to be considered ESM. This is not correct and likely needs to be
  fixed upstream in `rules_nodejs` where explicit `.cjs` extensions
  should be used. This is only happening **once** in the `injectable-def`
  test so it is acceptable doing that for now.

PR Close #44238
1 parent 5837fbd
Raw File
ngsw-config.template.json 
{
  "$schema": "./node_modules/@angular/service-worker/config/schema.json",
  "index": "/index.html",
  "assetGroups": [
    {
      "name": "app-shell",
      "installMode": "prefetch",
      "updateMode": "prefetch",
      "resources": {
        "files": [
          "/index.html",
          "/pwa-manifest.json",
          "/assets/images/favicons/favicon.ico",
          "/assets/js/*.js",
          "/*.css",
          "/*.js"
        ],
        "urls": [
          "https://fonts.googleapis.com/**",
          "https://fonts.gstatic.com/s/**"
        ]
      }
    },
    {
      "name": "assets-eager",
      "installMode": "prefetch",
      "updateMode": "prefetch",
      "resources": {
        "files": [
          "/assets/images/**",
          "/generated/images/marketing/**",
          "!/assets/images/favicons/**",
          "!/**/_unused/**"
        ]
      }
    },
    {
      "name": "assets-lazy",
      "installMode": "lazy",
      "updateMode": "prefetch",
      "resources": {
        "files": [
          "/assets/images/favicons/**",
          "!/**/_unused/**"
        ]
      }
    },
    {
      "name": "docs-index",
      "installMode": "prefetch",
      "updateMode": "prefetch",
      "resources": {
        "files": [
          "/generated/*.json",
          "/generated/docs/*.json",
          "/generated/docs/api/api-list.json",
          "/generated/docs/app/search-data.json"
        ]
      }
    },
    {
      "name": "docs-lazy",
      "installMode": "lazy",
      "updateMode": "lazy",
      "resources": {
        "files": [
          "/generated/docs/**/*.json",
          "/generated/images/**",
          "!/**/_unused/**"
        ]
      }
    }
  ],
  "navigationUrls": [
    "/**",
    "!/**/*.*",
    "!/**/*__*",
    "!/**/*__*/**",
    "!/**/stackblitz/{0,1}"
  ]
}
back to top