Revision 26d2b757fff02bbe971abc39071e263aa0cab924 authored by Janusz Krzysztofik on 22 February 2024, 11:32:40 UTC, committed by Joonas Lahtinen on 06 March 2024, 13:33:57 UTC
Third argument of i915_request_wait() accepts a timeout value in jiffies.
Most users pass either a simple HZ based expression, or a result of
msecs_to_jiffies(), or MAX_SCHEDULE_TIMEOUT, or a very small number not
exceeding 4 if applicable as that value.  However, there is one user --
intel_selftest_wait_for_rq() -- that passes a WAIT_FOR_RESET_TIME symbol,
defined as a large constant value that most probably represents a desired
timeout in ms.  While that usage results in the intended value of timeout
on usual x86_64 kernel configurations, it is not portable across different
architectures and custom kernel configs.

Rename the symbol to clearly indicate intended units and convert it to
jiffies before use.

Fixes: 3a4bfa091c46 ("drm/i915/selftest: Fix workarounds selftest for GuC submission")
Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Cc: Rahul Kumar Singh <rahul.kumar.singh@intel.com>
Cc: John Harrison <John.C.Harrison@Intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240222113347.648945-2-janusz.krzysztofik@linux.intel.com
(cherry picked from commit 6ee3f54b880c91ab2e244eb4ffd4bfed37832b25)
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
1 parent 0b385be
History
File Mode Size
Kconfig -rw-r--r-- 1.3 KB
Makefile -rw-r--r-- 222 bytes
vxfs.h -rw-r--r-- 8.3 KB
vxfs_bmap.c -rw-r--r-- 6.5 KB
vxfs_dir.h -rw-r--r-- 1.8 KB
vxfs_extern.h -rw-r--r-- 1.4 KB
vxfs_fshead.c -rw-r--r-- 3.9 KB
vxfs_fshead.h -rw-r--r-- 1.2 KB
vxfs_immed.c -rw-r--r-- 1.2 KB
vxfs_inode.c -rw-r--r-- 7.8 KB
vxfs_inode.h -rw-r--r-- 4.4 KB
vxfs_lookup.c -rw-r--r-- 5.9 KB
vxfs_olt.c -rw-r--r-- 2.5 KB
vxfs_olt.h -rw-r--r-- 3.0 KB
vxfs_subr.c -rw-r--r-- 3.2 KB
vxfs_super.c -rw-r--r-- 7.5 KB

back to top