Revision 26d2b757fff02bbe971abc39071e263aa0cab924 authored by Janusz Krzysztofik on 22 February 2024, 11:32:40 UTC, committed by Joonas Lahtinen on 06 March 2024, 13:33:57 UTC
Third argument of i915_request_wait() accepts a timeout value in jiffies.
Most users pass either a simple HZ based expression, or a result of
msecs_to_jiffies(), or MAX_SCHEDULE_TIMEOUT, or a very small number not
exceeding 4 if applicable as that value.  However, there is one user --
intel_selftest_wait_for_rq() -- that passes a WAIT_FOR_RESET_TIME symbol,
defined as a large constant value that most probably represents a desired
timeout in ms.  While that usage results in the intended value of timeout
on usual x86_64 kernel configurations, it is not portable across different
architectures and custom kernel configs.

Rename the symbol to clearly indicate intended units and convert it to
jiffies before use.

Fixes: 3a4bfa091c46 ("drm/i915/selftest: Fix workarounds selftest for GuC submission")
Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Cc: Rahul Kumar Singh <rahul.kumar.singh@intel.com>
Cc: John Harrison <John.C.Harrison@Intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240222113347.648945-2-janusz.krzysztofik@linux.intel.com
(cherry picked from commit 6ee3f54b880c91ab2e244eb4ffd4bfed37832b25)
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
1 parent 0b385be
History
File Mode Size
Kconfig -rw-r--r-- 1.4 KB
Makefile -rw-r--r-- 343 bytes
acl.c -rw-r--r-- 3.2 KB
acl.h -rw-r--r-- 610 bytes
aops.c -rw-r--r-- 19.4 KB
aops.h -rw-r--r-- 352 bytes
bmap.c -rw-r--r-- 64.5 KB
bmap.h -rw-r--r-- 2.2 KB
dentry.c -rw-r--r-- 2.3 KB
dir.c -rw-r--r-- 52.4 KB
dir.h -rw-r--r-- 2.4 KB
export.c -rw-r--r-- 4.6 KB
file.c -rw-r--r-- 40.5 KB
gfs2.h -rw-r--r-- 372 bytes
glock.c -rw-r--r-- 73.9 KB
glock.h -rw-r--r-- 8.1 KB
glops.c -rw-r--r-- 20.5 KB
glops.h -rw-r--r-- 1.0 KB
incore.h -rw-r--r-- 23.6 KB
inode.c -rw-r--r-- 52.1 KB
inode.h -rw-r--r-- 3.8 KB
lock_dlm.c -rw-r--r-- 40.6 KB
log.c -rw-r--r-- 37.1 KB
log.h -rw-r--r-- 2.9 KB
lops.c -rw-r--r-- 28.2 KB
lops.h -rw-r--r-- 2.4 KB
main.c -rw-r--r-- 6.1 KB
meta_io.c -rw-r--r-- 12.6 KB
meta_io.h -rw-r--r-- 2.4 KB
ops_fstype.c -rw-r--r-- 46.2 KB
quota.c -rw-r--r-- 43.2 KB
quota.h -rw-r--r-- 2.0 KB
recovery.c -rw-r--r-- 15.0 KB
recovery.h -rw-r--r-- 1.0 KB
rgrp.c -rw-r--r-- 73.3 KB
rgrp.h -rw-r--r-- 3.2 KB
super.c -rw-r--r-- 39.7 KB
super.h -rw-r--r-- 2.2 KB
sys.c -rw-r--r-- 20.5 KB
sys.h -rw-r--r-- 507 bytes
trace_gfs2.h -rw-r--r-- 17.7 KB
trans.c -rw-r--r-- 9.3 KB
trans.h -rw-r--r-- 1.5 KB
util.c -rw-r--r-- 15.6 KB
util.h -rw-r--r-- 6.5 KB
xattr.c -rw-r--r-- 32.9 KB
xattr.h -rw-r--r-- 1.9 KB

back to top