Revision 26d2b757fff02bbe971abc39071e263aa0cab924 authored by Janusz Krzysztofik on 22 February 2024, 11:32:40 UTC, committed by Joonas Lahtinen on 06 March 2024, 13:33:57 UTC
Third argument of i915_request_wait() accepts a timeout value in jiffies.
Most users pass either a simple HZ based expression, or a result of
msecs_to_jiffies(), or MAX_SCHEDULE_TIMEOUT, or a very small number not
exceeding 4 if applicable as that value.  However, there is one user --
intel_selftest_wait_for_rq() -- that passes a WAIT_FOR_RESET_TIME symbol,
defined as a large constant value that most probably represents a desired
timeout in ms.  While that usage results in the intended value of timeout
on usual x86_64 kernel configurations, it is not portable across different
architectures and custom kernel configs.

Rename the symbol to clearly indicate intended units and convert it to
jiffies before use.

Fixes: 3a4bfa091c46 ("drm/i915/selftest: Fix workarounds selftest for GuC submission")
Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Cc: Rahul Kumar Singh <rahul.kumar.singh@intel.com>
Cc: John Harrison <John.C.Harrison@Intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240222113347.648945-2-janusz.krzysztofik@linux.intel.com
(cherry picked from commit 6ee3f54b880c91ab2e244eb4ffd4bfed37832b25)
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
1 parent 0b385be
History
File Mode Size
Makefile -rw-r--r-- 440 bytes
clnt4xdr.c -rw-r--r-- 12.7 KB
clntlock.c -rw-r--r-- 7.4 KB
clntproc.c -rw-r--r-- 22.5 KB
clntxdr.c -rw-r--r-- 13.2 KB
host.c -rw-r--r-- 17.6 KB
mon.c -rw-r--r-- 14.4 KB
netns.h -rw-r--r-- 423 bytes
procfs.c -rw-r--r-- 1.9 KB
procfs.h -rw-r--r-- 474 bytes
svc.c -rw-r--r-- 17.4 KB
svc4proc.c -rw-r--r-- 20.1 KB
svclock.c -rw-r--r-- 28.3 KB
svcproc.c -rw-r--r-- 20.5 KB
svcshare.c -rw-r--r-- 2.4 KB
svcsubs.c -rw-r--r-- 11.5 KB
svcxdr.h -rw-r--r-- 2.8 KB
trace.c -rw-r--r-- 83 bytes
trace.h -rw-r--r-- 2.8 KB
xdr.c -rw-r--r-- 7.6 KB
xdr4.c -rw-r--r-- 7.6 KB

back to top