Skip to main content

Browse the archive

Revision 26e28fe7bbdf8b22ed096dfd76a9311e86ffb200 authored by Jeff King on 30 September 2020, 12:30:27 UTC, committed by Junio C Hamano on 30 September 2020, 19:53:48 UTC 
test-advise: check argument count with argc instead of argv
 
We complain if "test-tool advise" is not given an argument, but we
quietly ignore any additional arguments it receives. Let's instead check
that we got the expected number. As a bonus, this silences
-Wunused-parameter, which notes that we don't ever look at argc.

While we're here, we can also fix the indentation in the conditional.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 75d3bee
Raw File
PULL_REQUEST_TEMPLATE.md 
Thanks for taking the time to contribute to Git! Please be advised that the
Git community does not use github.com for their contributions. Instead, we use
a mailing list (git@vger.kernel.org) for code submissions, code reviews, and
bug reports. Nevertheless, you can use GitGitGadget (https://gitgitgadget.github.io/)
to conveniently send your Pull Requests commits to our mailing list.

Please read the "guidelines for contributing" linked above!
back to top