https://github.com/torvalds/linux
Revision 275e88b06a277ccf89d9c471a777e9b4f8c552b0 authored by Rob Herring on 18 December 2020, 14:39:05 UTC, committed by Bjorn Helgaas on 26 December 2020, 03:58:36 UTC
Commit b9ac0f9dc8ea ("PCI: dwc: Move dw_pcie_setup_rc() to DWC common code") broke enumeration of downstream devices on Tegra: In non-working case (next-20201211): 0001:00:00.0 PCI bridge: NVIDIA Corporation Device 1ad2 (rev a1) 0001:01:00.0 SATA controller: Marvell Technology Group Ltd. Device 9171 (rev 13) 0005:00:00.0 PCI bridge: NVIDIA Corporation Device 1ad0 (rev a1) In working case (v5.10-rc7): 0001:00:00.0 PCI bridge: Molex Incorporated Device 1ad2 (rev a1) 0001:01:00.0 SATA controller: Marvell Technology Group Ltd. Device 9171 (rev 13) 0005:00:00.0 PCI bridge: Molex Incorporated Device 1ad0 (rev a1) 0005:01:00.0 PCI bridge: PLX Technology, Inc. Device 3380 (rev ab) 0005:02:02.0 PCI bridge: PLX Technology, Inc. Device 3380 (rev ab) 0005:03:00.0 USB controller: PLX Technology, Inc. Device 3380 (rev ab) The problem seems to be dw_pcie_setup_rc() is now called twice before and after the link up handling. The fix is to move Tegra's link up handling to .start_link() function like other DWC drivers. Tegra is a bit more complicated than others as it re-inits the whole DWC controller to retry the link. With this, the initialization ordering is restored to match the prior sequence. Fixes: b9ac0f9dc8ea ("PCI: dwc: Move dw_pcie_setup_rc() to DWC common code") Link: https://lore.kernel.org/r/20201218143905.1614098-1-robh@kernel.org Reported-by: Mian Yousaf Kaukab <ykaukab@suse.de> Tested-by: Mian Yousaf Kaukab <ykaukab@suse.de> Signed-off-by: Rob Herring <robh@kernel.org> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: Jonathan Hunter <jonathanh@nvidia.com> Cc: Vidya Sagar <vidyas@nvidia.com>
1 parent 255b2d5
Tip revision: 275e88b06a277ccf89d9c471a777e9b4f8c552b0 authored by Rob Herring on 18 December 2020, 14:39:05 UTC
PCI: tegra: Fix host link initialization
PCI: tegra: Fix host link initialization
Tip revision: 275e88b
File | Mode | Size |
---|---|---|
acpica | ||
apei | ||
arm64 | ||
dptf | ||
nfit | ||
numa | ||
pmic | ||
x86 | ||
Kconfig | -rw-r--r-- | 17.1 KB |
Makefile | -rw-r--r-- | 3.3 KB |
ac.c | -rw-r--r-- | 8.9 KB |
acpi_adxl.c | -rw-r--r-- | 4.7 KB |
acpi_amba.c | -rw-r--r-- | 3.0 KB |
acpi_apd.c | -rw-r--r-- | 6.3 KB |
acpi_cmos_rtc.c | -rw-r--r-- | 2.0 KB |
acpi_configfs.c | -rw-r--r-- | 6.4 KB |
acpi_dbg.c | -rw-r--r-- | 17.9 KB |
acpi_extlog.c | -rw-r--r-- | 8.3 KB |
acpi_ipmi.c | -rw-r--r-- | 16.4 KB |
acpi_lpat.c | -rw-r--r-- | 4.0 KB |
acpi_lpit.c | -rw-r--r-- | 4.2 KB |
acpi_lpss.c | -rw-r--r-- | 35.3 KB |
acpi_memhotplug.c | -rw-r--r-- | 9.1 KB |
acpi_pad.c | -rw-r--r-- | 12.0 KB |
acpi_platform.c | -rw-r--r-- | 4.7 KB |
acpi_pnp.c | -rw-r--r-- | 13.6 KB |
acpi_processor.c | -rw-r--r-- | 23.5 KB |
acpi_tad.c | -rw-r--r-- | 15.6 KB |
acpi_video.c | -rw-r--r-- | 58.7 KB |
acpi_watchdog.c | -rw-r--r-- | 4.7 KB |
battery.c | -rw-r--r-- | 37.8 KB |
bgrt.c | -rw-r--r-- | 2.9 KB |
blacklist.c | -rw-r--r-- | 3.7 KB |
bus.c | -rw-r--r-- | 33.3 KB |
button.c | -rw-r--r-- | 17.2 KB |
container.c | -rw-r--r-- | 2.6 KB |
cppc_acpi.c | -rw-r--r-- | 40.7 KB |
custom_method.c | -rw-r--r-- | 2.1 KB |
debugfs.c | -rw-r--r-- | 391 bytes |
device_pm.c | -rw-r--r-- | 37.3 KB |
device_sysfs.c | -rw-r--r-- | 16.3 KB |
dock.c | -rw-r--r-- | 16.5 KB |
ec.c | -rw-r--r-- | 57.4 KB |
ec_sys.c | -rw-r--r-- | 3.1 KB |
event.c | -rw-r--r-- | 4.2 KB |
evged.c | -rw-r--r-- | 4.6 KB |
fan.c | -rw-r--r-- | 12.2 KB |
glue.c | -rw-r--r-- | 8.9 KB |
hed.c | -rw-r--r-- | 1.9 KB |
internal.h | -rw-r--r-- | 9.1 KB |
ioapic.c | -rw-r--r-- | 5.9 KB |
irq.c | -rw-r--r-- | 8.9 KB |
nvs.c | -rw-r--r-- | 4.6 KB |
osi.c | -rw-r--r-- | 13.1 KB |
osl.c | -rw-r--r-- | 43.4 KB |
pci_irq.c | -rw-r--r-- | 13.5 KB |
pci_link.c | -rw-r--r-- | 23.5 KB |
pci_mcfg.c | -rw-r--r-- | 8.7 KB |
pci_root.c | -rw-r--r-- | 25.8 KB |
pci_slot.c | -rw-r--r-- | 4.7 KB |
power.c | -rw-r--r-- | 25.9 KB |
pptt.c | -rw-r--r-- | 23.5 KB |
proc.c | -rw-r--r-- | 3.4 KB |
processor_core.c | -rw-r--r-- | 9.1 KB |
processor_driver.c | -rw-r--r-- | 8.9 KB |
processor_idle.c | -rw-r--r-- | 34.3 KB |
processor_pdc.c | -rw-r--r-- | 4.7 KB |
processor_perflib.c | -rw-r--r-- | 19.3 KB |
processor_thermal.c | -rw-r--r-- | 5.9 KB |
processor_throttling.c | -rw-r--r-- | 30.8 KB |
property.c | -rw-r--r-- | 37.1 KB |
reboot.c | -rw-r--r-- | 2.0 KB |
resource.c | -rw-r--r-- | 22.8 KB |
sbs.c | -rw-r--r-- | 19.4 KB |
sbshc.c | -rw-r--r-- | 7.1 KB |
sbshc.h | -rw-r--r-- | 964 bytes |
scan.c | -rw-r--r-- | 58.8 KB |
sleep.c | -rw-r--r-- | 33.0 KB |
sleep.h | -rw-r--r-- | 553 bytes |
spcr.c | -rw-r--r-- | 5.8 KB |
sysfs.c | -rw-r--r-- | 27.4 KB |
tables.c | -rw-r--r-- | 22.2 KB |
thermal.c | -rw-r--r-- | 30.6 KB |
tiny-power-button.c | -rw-r--r-- | 1.2 KB |
utils.c | -rw-r--r-- | 23.7 KB |
video_detect.c | -rw-r--r-- | 14.0 KB |
wakeup.c | -rw-r--r-- | 4.6 KB |
Computing file changes ...