https://github.com/torvalds/linux
Revision 275e88b06a277ccf89d9c471a777e9b4f8c552b0 authored by Rob Herring on 18 December 2020, 14:39:05 UTC, committed by Bjorn Helgaas on 26 December 2020, 03:58:36 UTC
Commit b9ac0f9dc8ea ("PCI: dwc: Move dw_pcie_setup_rc() to DWC common
code") broke enumeration of downstream devices on Tegra:
In non-working case (next-20201211):
0001:00:00.0 PCI bridge: NVIDIA Corporation Device 1ad2 (rev a1)
0001:01:00.0 SATA controller: Marvell Technology Group Ltd. Device 9171 (rev 13)
0005:00:00.0 PCI bridge: NVIDIA Corporation Device 1ad0 (rev a1)
In working case (v5.10-rc7):
0001:00:00.0 PCI bridge: Molex Incorporated Device 1ad2 (rev a1)
0001:01:00.0 SATA controller: Marvell Technology Group Ltd. Device 9171 (rev 13)
0005:00:00.0 PCI bridge: Molex Incorporated Device 1ad0 (rev a1)
0005:01:00.0 PCI bridge: PLX Technology, Inc. Device 3380 (rev ab)
0005:02:02.0 PCI bridge: PLX Technology, Inc. Device 3380 (rev ab)
0005:03:00.0 USB controller: PLX Technology, Inc. Device 3380 (rev ab)
The problem seems to be dw_pcie_setup_rc() is now called twice before and
after the link up handling. The fix is to move Tegra's link up handling to
.start_link() function like other DWC drivers. Tegra is a bit more
complicated than others as it re-inits the whole DWC controller to retry
the link. With this, the initialization ordering is restored to match the
prior sequence.
Fixes: b9ac0f9dc8ea ("PCI: dwc: Move dw_pcie_setup_rc() to DWC common code")
Link: https://lore.kernel.org/r/20201218143905.1614098-1-robh@kernel.org
Reported-by: Mian Yousaf Kaukab <ykaukab@suse.de>
Tested-by: Mian Yousaf Kaukab <ykaukab@suse.de>
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: Vidya Sagar <vidyas@nvidia.com>
1 parent 255b2d5
Tip revision: 275e88b06a277ccf89d9c471a777e9b4f8c552b0 authored by Rob Herring on 18 December 2020, 14:39:05 UTC
PCI: tegra: Fix host link initialization
PCI: tegra: Fix host link initialization
Tip revision: 275e88b
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 19.4 KB |
| Makefile | -rw-r--r-- | 4.3 KB |
| acpi_pm.c | -rw-r--r-- | 6.2 KB |
| arc_timer.c | -rw-r--r-- | 9.0 KB |
| arm_arch_timer.c | -rw-r--r-- | 42.6 KB |
| arm_global_timer.c | -rw-r--r-- | 8.6 KB |
| armv7m_systick.c | -rw-r--r-- | 1.7 KB |
| asm9260_timer.c | -rw-r--r-- | 6.7 KB |
| bcm2835_timer.c | -rw-r--r-- | 3.1 KB |
| bcm_kona_timer.c | -rw-r--r-- | 5.2 KB |
| clksrc-dbx500-prcmu.c | -rw-r--r-- | 2.1 KB |
| clksrc_st_lpc.c | -rw-r--r-- | 2.8 KB |
| clps711x-timer.c | -rw-r--r-- | 2.3 KB |
| dummy_timer.c | -rw-r--r-- | 931 bytes |
| dw_apb_timer.c | -rw-r--r-- | 11.7 KB |
| dw_apb_timer_of.c | -rw-r--r-- | 4.2 KB |
| em_sti.c | -rw-r--r-- | 8.4 KB |
| exynos_mct.c | -rw-r--r-- | 15.7 KB |
| h8300_timer16.c | -rw-r--r-- | 4.0 KB |
| h8300_timer8.c | -rw-r--r-- | 4.4 KB |
| h8300_tpu.c | -rw-r--r-- | 3.2 KB |
| hyperv_timer.c | -rw-r--r-- | 12.5 KB |
| i8253.c | -rw-r--r-- | 5.1 KB |
| ingenic-ost.c | -rw-r--r-- | 4.4 KB |
| ingenic-sysost.c | -rw-r--r-- | 13.2 KB |
| ingenic-timer.c | -rw-r--r-- | 10.4 KB |
| jcore-pit.c | -rw-r--r-- | 6.5 KB |
| mips-gic-timer.c | -rw-r--r-- | 6.3 KB |
| mmio.c | -rw-r--r-- | 1.7 KB |
| mps2-timer.c | -rw-r--r-- | 6.1 KB |
| mxs_timer.c | -rw-r--r-- | 7.4 KB |
| nomadik-mtu.c | -rw-r--r-- | 7.3 KB |
| numachip.c | -rw-r--r-- | 2.3 KB |
| renesas-ostm.c | -rw-r--r-- | 4.8 KB |
| samsung_pwm_timer.c | -rw-r--r-- | 12.4 KB |
| scx200_hrt.c | -rw-r--r-- | 2.5 KB |
| sh_cmt.c | -rw-r--r-- | 27.6 KB |
| sh_mtu2.c | -rw-r--r-- | 12.2 KB |
| sh_tmu.c | -rw-r--r-- | 14.8 KB |
| timer-armada-370-xp.c | -rw-r--r-- | 10.0 KB |
| timer-atcpit100.c | -rw-r--r-- | 6.0 KB |
| timer-atlas7.c | -rw-r--r-- | 8.2 KB |
| timer-atmel-pit.c | -rw-r--r-- | 6.9 KB |
| timer-atmel-st.c | -rw-r--r-- | 6.2 KB |
| timer-atmel-tcb.c | -rw-r--r-- | 13.4 KB |
| timer-cadence-ttc.c | -rw-r--r-- | 14.5 KB |
| timer-clint.c | -rw-r--r-- | 5.9 KB |
| timer-cs5535.c | -rw-r--r-- | 5.6 KB |
| timer-davinci.c | -rw-r--r-- | 9.6 KB |
| timer-digicolor.c | -rw-r--r-- | 5.1 KB |
| timer-efm32.c | -rw-r--r-- | 6.6 KB |
| timer-fsl-ftm.c | -rw-r--r-- | 7.7 KB |
| timer-fttmr010.c | -rw-r--r-- | 12.0 KB |
| timer-gx6605s.c | -rw-r--r-- | 4.0 KB |
| timer-imx-gpt.c | -rw-r--r-- | 13.4 KB |
| timer-imx-sysctr.c | -rw-r--r-- | 3.0 KB |
| timer-imx-tpm.c | -rw-r--r-- | 5.6 KB |
| timer-integrator-ap.c | -rw-r--r-- | 5.2 KB |
| timer-ixp4xx.c | -rw-r--r-- | 7.6 KB |
| timer-keystone.c | -rw-r--r-- | 5.3 KB |
| timer-lpc32xx.c | -rw-r--r-- | 8.1 KB |
| timer-mediatek.c | -rw-r--r-- | 8.2 KB |
| timer-meson6.c | -rw-r--r-- | 5.8 KB |
| timer-microchip-pit64b.c | -rw-r--r-- | 12.1 KB |
| timer-milbeaut.c | -rw-r--r-- | 5.1 KB |
| timer-mp-csky.c | -rw-r--r-- | 3.7 KB |
| timer-npcm7xx.c | -rw-r--r-- | 5.6 KB |
| timer-nps.c | -rw-r--r-- | 7.4 KB |
| timer-of.c | -rw-r--r-- | 5.2 KB |
| timer-of.h | -rw-r--r-- | 1.4 KB |
| timer-orion.c | -rw-r--r-- | 4.6 KB |
| timer-owl.c | -rw-r--r-- | 4.1 KB |
| timer-oxnas-rps.c | -rw-r--r-- | 6.6 KB |
| timer-pistachio.c | -rw-r--r-- | 5.6 KB |
| timer-prima2.c | -rw-r--r-- | 6.5 KB |
| timer-probe.c | -rw-r--r-- | 959 bytes |
| timer-pxa.c | -rw-r--r-- | 5.9 KB |
| timer-qcom.c | -rw-r--r-- | 6.0 KB |
| timer-rda.c | -rw-r--r-- | 4.6 KB |
| timer-riscv.c | -rw-r--r-- | 4.3 KB |
| timer-rockchip.c | -rw-r--r-- | 6.8 KB |
| timer-sp.h | -rw-r--r-- | 1.7 KB |
| timer-sp804.c | -rw-r--r-- | 9.0 KB |
| timer-sprd.c | -rw-r--r-- | 4.8 KB |
| timer-stm32-lp.c | -rw-r--r-- | 6.0 KB |
| timer-stm32.c | -rw-r--r-- | 8.4 KB |
| timer-sun4i.c | -rw-r--r-- | 6.2 KB |
| timer-sun5i.c | -rw-r--r-- | 9.4 KB |
| timer-tango-xtal.c | -rw-r--r-- | 1.3 KB |
| timer-tegra.c | -rw-r--r-- | 10.3 KB |
| timer-ti-32k.c | -rw-r--r-- | 4.2 KB |
| timer-ti-dm-systimer.c | -rw-r--r-- | 19.2 KB |
| timer-ti-dm.c | -rw-r--r-- | 22.9 KB |
| timer-u300.c | -rw-r--r-- | 16.4 KB |
| timer-versatile.c | -rw-r--r-- | 866 bytes |
| timer-vf-pit.c | -rw-r--r-- | 4.9 KB |
| timer-vt8500.c | -rw-r--r-- | 3.9 KB |
| timer-zevio.c | -rw-r--r-- | 5.5 KB |
Computing file changes ...
