https://github.com/torvalds/linux
Revision 275e88b06a277ccf89d9c471a777e9b4f8c552b0 authored by Rob Herring on 18 December 2020, 14:39:05 UTC, committed by Bjorn Helgaas on 26 December 2020, 03:58:36 UTC
Commit b9ac0f9dc8ea ("PCI: dwc: Move dw_pcie_setup_rc() to DWC common code") broke enumeration of downstream devices on Tegra: In non-working case (next-20201211): 0001:00:00.0 PCI bridge: NVIDIA Corporation Device 1ad2 (rev a1) 0001:01:00.0 SATA controller: Marvell Technology Group Ltd. Device 9171 (rev 13) 0005:00:00.0 PCI bridge: NVIDIA Corporation Device 1ad0 (rev a1) In working case (v5.10-rc7): 0001:00:00.0 PCI bridge: Molex Incorporated Device 1ad2 (rev a1) 0001:01:00.0 SATA controller: Marvell Technology Group Ltd. Device 9171 (rev 13) 0005:00:00.0 PCI bridge: Molex Incorporated Device 1ad0 (rev a1) 0005:01:00.0 PCI bridge: PLX Technology, Inc. Device 3380 (rev ab) 0005:02:02.0 PCI bridge: PLX Technology, Inc. Device 3380 (rev ab) 0005:03:00.0 USB controller: PLX Technology, Inc. Device 3380 (rev ab) The problem seems to be dw_pcie_setup_rc() is now called twice before and after the link up handling. The fix is to move Tegra's link up handling to .start_link() function like other DWC drivers. Tegra is a bit more complicated than others as it re-inits the whole DWC controller to retry the link. With this, the initialization ordering is restored to match the prior sequence. Fixes: b9ac0f9dc8ea ("PCI: dwc: Move dw_pcie_setup_rc() to DWC common code") Link: https://lore.kernel.org/r/20201218143905.1614098-1-robh@kernel.org Reported-by: Mian Yousaf Kaukab <ykaukab@suse.de> Tested-by: Mian Yousaf Kaukab <ykaukab@suse.de> Signed-off-by: Rob Herring <robh@kernel.org> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: Jonathan Hunter <jonathanh@nvidia.com> Cc: Vidya Sagar <vidyas@nvidia.com>
1 parent 255b2d5
Tip revision: 275e88b06a277ccf89d9c471a777e9b4f8c552b0 authored by Rob Herring on 18 December 2020, 14:39:05 UTC
PCI: tegra: Fix host link initialization
PCI: tegra: Fix host link initialization
Tip revision: 275e88b
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 716 bytes |
Makefile | -rw-r--r-- | 527 bytes |
api.c | -rw-r--r-- | 11.6 KB |
base.c | -rw-r--r-- | 2.4 KB |
context.c | -rw-r--r-- | 8.7 KB |
cxl.h | -rw-r--r-- | 41.8 KB |
cxllib.c | -rw-r--r-- | 6.3 KB |
debugfs.c | -rw-r--r-- | 4.2 KB |
fault.c | -rw-r--r-- | 8.2 KB |
file.c | -rw-r--r-- | 17.3 KB |
flash.c | -rw-r--r-- | 12.2 KB |
guest.c | -rw-r--r-- | 27.2 KB |
hcalls.c | -rw-r--r-- | 22.4 KB |
hcalls.h | -rw-r--r-- | 6.6 KB |
irq.c | -rw-r--r-- | 12.3 KB |
main.c | -rw-r--r-- | 8.7 KB |
native.c | -rw-r--r-- | 43.6 KB |
of.c | -rw-r--r-- | 12.0 KB |
pci.c | -rw-r--r-- | 58.6 KB |
sysfs.c | -rw-r--r-- | 18.7 KB |
trace.c | -rw-r--r-- | 155 bytes |
trace.h | -rw-r--r-- | 14.3 KB |
vphb.c | -rw-r--r-- | 7.1 KB |
Computing file changes ...