https://github.com/torvalds/linux
Revision 275e88b06a277ccf89d9c471a777e9b4f8c552b0 authored by Rob Herring on 18 December 2020, 14:39:05 UTC, committed by Bjorn Helgaas on 26 December 2020, 03:58:36 UTC
Commit b9ac0f9dc8ea ("PCI: dwc: Move dw_pcie_setup_rc() to DWC common code") broke enumeration of downstream devices on Tegra: In non-working case (next-20201211): 0001:00:00.0 PCI bridge: NVIDIA Corporation Device 1ad2 (rev a1) 0001:01:00.0 SATA controller: Marvell Technology Group Ltd. Device 9171 (rev 13) 0005:00:00.0 PCI bridge: NVIDIA Corporation Device 1ad0 (rev a1) In working case (v5.10-rc7): 0001:00:00.0 PCI bridge: Molex Incorporated Device 1ad2 (rev a1) 0001:01:00.0 SATA controller: Marvell Technology Group Ltd. Device 9171 (rev 13) 0005:00:00.0 PCI bridge: Molex Incorporated Device 1ad0 (rev a1) 0005:01:00.0 PCI bridge: PLX Technology, Inc. Device 3380 (rev ab) 0005:02:02.0 PCI bridge: PLX Technology, Inc. Device 3380 (rev ab) 0005:03:00.0 USB controller: PLX Technology, Inc. Device 3380 (rev ab) The problem seems to be dw_pcie_setup_rc() is now called twice before and after the link up handling. The fix is to move Tegra's link up handling to .start_link() function like other DWC drivers. Tegra is a bit more complicated than others as it re-inits the whole DWC controller to retry the link. With this, the initialization ordering is restored to match the prior sequence. Fixes: b9ac0f9dc8ea ("PCI: dwc: Move dw_pcie_setup_rc() to DWC common code") Link: https://lore.kernel.org/r/20201218143905.1614098-1-robh@kernel.org Reported-by: Mian Yousaf Kaukab <ykaukab@suse.de> Tested-by: Mian Yousaf Kaukab <ykaukab@suse.de> Signed-off-by: Rob Herring <robh@kernel.org> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: Jonathan Hunter <jonathanh@nvidia.com> Cc: Vidya Sagar <vidyas@nvidia.com>
1 parent 255b2d5
Tip revision: 275e88b06a277ccf89d9c471a777e9b4f8c552b0 authored by Rob Herring on 18 December 2020, 14:39:05 UTC
PCI: tegra: Fix host link initialization
PCI: tegra: Fix host link initialization
Tip revision: 275e88b
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 442 bytes |
Makefile | -rw-r--r-- | 266 bytes |
vmci_context.c | -rw-r--r-- | 30.7 KB |
vmci_context.h | -rw-r--r-- | 5.0 KB |
vmci_datagram.c | -rw-r--r-- | 13.5 KB |
vmci_datagram.h | -rw-r--r-- | 1.2 KB |
vmci_doorbell.c | -rw-r--r-- | 16.7 KB |
vmci_doorbell.h | -rw-r--r-- | 1.0 KB |
vmci_driver.c | -rw-r--r-- | 4.1 KB |
vmci_driver.h | -rw-r--r-- | 1.1 KB |
vmci_event.c | -rw-r--r-- | 5.0 KB |
vmci_event.h | -rw-r--r-- | 354 bytes |
vmci_guest.c | -rw-r--r-- | 20.1 KB |
vmci_handle_array.c | -rw-r--r-- | 3.2 KB |
vmci_handle_array.h | -rw-r--r-- | 1.6 KB |
vmci_host.c | -rw-r--r-- | 26.9 KB |
vmci_queue_pair.c | -rw-r--r-- | 92.4 KB |
vmci_queue_pair.h | -rw-r--r-- | 5.3 KB |
vmci_resource.c | -rw-r--r-- | 5.3 KB |
vmci_resource.h | -rw-r--r-- | 1.2 KB |
vmci_route.c | -rw-r--r-- | 5.9 KB |
vmci_route.h | -rw-r--r-- | 447 bytes |
Computing file changes ...