Revision 27d3bc184e2d7e27baa0658620a098f2b15b8360 authored by sdong on 18 April 2014, 01:00:58 UTC, committed by sdong on 18 April 2014, 21:09:21 UTC
Summary: A recent commit https://github.com/facebook/rocksdb/commit/e37dd216f9384bfdabc6760fa296e8ee28c79d30 makes sure hash index can be used when reading existing files. This patch uses another way to achieve the approach: (1) Currently, always writing kBinarySearch to files, despite of BlockBasedTableOptions.IndexType setting. (2) When reading a file, read out the field, and make sure it is kBinarySearch, while always use index type by users. The reason for doing it is, to reserve kHashSearch property on disk to future. If now we write out binary index for both of kHashSearch and kBinarySearch. We have to use a new flag in the future for hash index on disk, otherwise compatibility would break. Also, we want the real index type and type shown in properties block to be consistent. Test Plan: make all check Reviewers: haobo, kailiu Reviewed By: kailiu CC: igor, ljin, yhchiang, xjin, dhruba, leveldb Differential Revision: https://reviews.facebook.net/D18009
1 parent 35c968f
| File | Mode | Size |
|---|---|---|
| build_tools | ||
| coverage | ||
| db | ||
| doc | ||
| hdfs | ||
| helpers | ||
| include | ||
| java | ||
| linters | ||
| port | ||
| table | ||
| tools | ||
| util | ||
| utilities | ||
| .arcconfig | -rw-r--r-- | 246 bytes |
| .clang-format | -rw-r--r-- | 138 bytes |
| .gitignore | -rw-r--r-- | 311 bytes |
| CONTRIBUTING.md | -rw-r--r-- | 776 bytes |
| HISTORY.md | -rw-r--r-- | 5.0 KB |
| INSTALL.md | -rw-r--r-- | 3.3 KB |
| LICENSE | -rw-r--r-- | 1.6 KB |
| Makefile | -rw-r--r-- | 20.2 KB |
| PATENTS | -rw-r--r-- | 1.4 KB |
| README | -rw-r--r-- | 2.9 KB |
| README.fb | -rw-r--r-- | 96 bytes |
| ROCKSDB_LITE.md | -rw-r--r-- | 1020 bytes |
Computing file changes ...
