Revision 27ed6ccc12a331a1e6014f2fe101a2c551167e9e authored by Jeff King on 27 August 2020, 05:25:04 UTC, committed by Junio C Hamano on 27 August 2020, 15:30:17 UTC
We allocate a child_env strvec but never free its memory. Instead, let's just use the strvec that our child_process struct provides, which is cleaned up automatically when we run the command. And while we're moving the initialization of the child_process around, let's switch it to use the official init function (zero-initializing it works OK, since strvec is happy enough with that, but it sets a bad example). Signed-off-by: Jeff King <peff@peff.net> Reviewed-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 47ae905
alloc.h
#ifndef ALLOC_H
#define ALLOC_H
struct alloc_state;
struct tree;
struct commit;
struct tag;
struct repository;
void *alloc_blob_node(struct repository *r);
void *alloc_tree_node(struct repository *r);
void init_commit_node(struct commit *c);
void *alloc_commit_node(struct repository *r);
void *alloc_tag_node(struct repository *r);
void *alloc_object_node(struct repository *r);
void alloc_report(struct repository *r);
struct alloc_state *allocate_alloc_state(void);
void clear_alloc_state(struct alloc_state *s);
#endif
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...