Skip to main content

Browse the archive

https://github.com/torvalds/linux
17 May 2024, 11:00:25 UTC
Revision 281393894af9cc3f9483204475014e89d728987c authored by Steve French on 10 December 2019, 01:47:10 UTC, committed by Steve French on 10 December 2019, 01:47:10 UTC 
smb3: fix refcount underflow warning on unmount when no directory leases
 
Fix refcount underflow warning when unmounting to servers which didn't grant
directory leases.

[  301.680095] refcount_t: underflow; use-after-free.
[  301.680192] WARNING: CPU: 1 PID: 3569 at lib/refcount.c:28
refcount_warn_saturate+0xb4/0xf3
...
[  301.682139] Call Trace:
[  301.682240]  close_shroot+0x97/0xda [cifs]
[  301.682351]  SMB2_tdis+0x7c/0x176 [cifs]
[  301.682456]  ? _get_xid+0x58/0x91 [cifs]
[  301.682563]  cifs_put_tcon.part.0+0x99/0x202 [cifs]
[  301.682637]  ? ida_free+0x99/0x10a
[  301.682727]  ? cifs_umount+0x3d/0x9d [cifs]
[  301.682829]  cifs_put_tlink+0x3a/0x50 [cifs]
[  301.682929]  cifs_umount+0x44/0x9d [cifs]

Fixes: 72e73c78c446 ("cifs: close the shared root handle on tree disconnect")

Signed-off-by: Steve French <stfrench@microsoft.com>
Acked-by: Ronnie Sahlberg <lsahlber@redhat.com>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
Reported-and-tested-by: Arthur Marsh <arthur.marsh@internode.on.net>
1 parent e42617b
History
Tip revision: 281393894af9cc3f9483204475014e89d728987c authored by Steve French on 10 December 2019, 01:47:10 UTC
smb3: fix refcount underflow warning on unmount when no directory leases
Tip revision: 2813938
File Mode Size
Kconfig -rw-r--r-- 71.5 KB
Makefile -rw-r--r-- 1.2 KB
calibrate.c -rw-r--r-- 8.6 KB
do_mounts.c -rw-r--r-- 15.7 KB
do_mounts.h -rw-r--r-- 1.1 KB
do_mounts_initrd.c -rw-r--r-- 3.5 KB
do_mounts_md.c -rw-r--r-- 7.9 KB
do_mounts_rd.c -rw-r--r-- 8.1 KB
init_task.c -rw-r--r-- 5.3 KB
initramfs.c -rw-r--r-- 14.5 KB
main.c -rw-r--r-- 30.1 KB
noinitramfs.c -rw-r--r-- 873 bytes
version.c -rw-r--r-- 1.3 KB
back to top