Revision - 282e466 - spawn: permit using IOBuffer as stdout (#52461) - origin: https://github.com/JuliaLang/julia

visit type:

https://github.com/JuliaLang/julia

30 August 2024, 22:04:04 UTC

Revision 282e466923dedde4e25e53b8ec0e9e41c82cbf67 authored by Jameson Nash on 13 December 2023, 14:54:42 UTC, committed by GitHub on 13 December 2023, 14:54:42 UTC

spawn: permit using IOBuffer as stdout (#52461)

People expect to use this (the docs even almost even suggested it at
some point), so it is better to make it work as expected (and better
than they can emulate) than to criticize their choices.

Also fix a few regressions and handling mistakes in setup_stdios:
- #44500 tried to store a Redirectable into a SpawnIO, dropping
FileRedirect
- CmdRedirect did not allocate a ProcessChain, so it would call
setup_stdio then call setup_stdios on the result of that, which is
strongly discouraged as setup_stdio(s) should only be called once
- BufferStream was missing `check_open` calls before writing, and
ignored `Base.reseteof` as a possible means of resuming writing after
`closewrite` sends a shutdown message.
 - Add `closewrite` to more methods, and document it.

Fixes #39311
Fixes #49234
Fixes #49233
Fixes #46768

1 parent 1524466

Files
Changes

Permalinks

Tip revision: 282e466923dedde4e25e53b8ec0e9e41c82cbf67 authored by Jameson Nash on 13 December 2023, 14:54:42 UTC
spawn: permit using IOBuffer as stdout (#52461)

Tip revision: 282e466

File	Mode	Size
.devcontainer
.github
base
cli
contrib
deps
doc
etc
src
stdlib
test
.buildkite-external-version	-rw-r--r--	5 bytes
.clang-format	-rw-r--r--	3.3 KB
.clangd	-rw-r--r--	114 bytes
.codecov.yml	-rw-r--r--	52 bytes
.git-blame-ignore-revs	-rw-r--r--	371 bytes
.gitattributes	-rw-r--r--	65 bytes
.gitignore	-rw-r--r--	523 bytes
.mailmap	-rw-r--r--	12.7 KB
CITATION.bib	-rw-r--r--	513 bytes
CITATION.cff	-rw-r--r--	940 bytes
CONTRIBUTING.md	-rw-r--r--	23.4 KB
HISTORY.md	-rw-r--r--	372.8 KB
LICENSE.md	-rw-r--r--	1.3 KB
Make.inc	-rw-r--r--	55.9 KB
Makefile	-rw-r--r--	30.3 KB
NEWS.md	-rw-r--r--	7.4 KB
README.md	-rw-r--r--	7.4 KB
THIRDPARTY.md	-rw-r--r--	3.8 KB
VERSION	-rw-r--r--	11 bytes
julia.spdx.json	-rw-r--r--	35.8 KB
pkgimage.mk	-rw-r--r--	5.8 KB
sysimage.mk	-rw-r--r--	4.2 KB
typos.toml	-rw-r--r--	78 bytes

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/JuliaLang/julia

spawn: permit using IOBuffer as stdout (#52461)

README.md