https://github.com/torvalds/linux
Revision 29ec90660d68bbdd69507c1c8b4e33aa299278b1 authored by Andrea Arcangeli on 30 November 2018, 22:09:32 UTC, committed by Linus Torvalds on 30 November 2018, 22:56:14 UTC
After the VMA to register the uffd onto is found, check that it has
VM_MAYWRITE set before allowing registration. This way we inherit all
common code checks before allowing to fill file holes in shmem and
hugetlbfs with UFFDIO_COPY.
The userfaultfd memory model is not applicable for readonly files unless
it's a MAP_PRIVATE.
Link: http://lkml.kernel.org/r/20181126173452.26955-4-aarcange@redhat.com
Fixes: ff62a3421044 ("hugetlb: implement memfd sealing")
Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
Reviewed-by: Mike Rapoport <rppt@linux.ibm.com>
Reviewed-by: Hugh Dickins <hughd@google.com>
Reported-by: Jann Horn <jannh@google.com>
Fixes: 4c27fe4c4c84 ("userfaultfd: shmem: add shmem_mcopy_atomic_pte for userfaultfd support")
Cc: <stable@vger.kernel.org>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>
Cc: Peter Xu <peterx@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 5b51072
Tip revision: 29ec90660d68bbdd69507c1c8b4e33aa299278b1 authored by Andrea Arcangeli on 30 November 2018, 22:09:32 UTC
userfaultfd: shmem/hugetlbfs: only allow to register VM_MAYWRITE vmas
userfaultfd: shmem/hugetlbfs: only allow to register VM_MAYWRITE vmas
Tip revision: 29ec906
| File | Mode | Size |
|---|---|---|
| 9p | ||
| adfs | ||
| affs | ||
| afs | ||
| autofs | ||
| befs | ||
| bfs | ||
| btrfs | ||
| cachefiles | ||
| ceph | ||
| cifs | ||
| coda | ||
| configfs | ||
| cramfs | ||
| crypto | ||
| debugfs | ||
| devpts | ||
| dlm | ||
| ecryptfs | ||
| efivarfs | ||
| efs | ||
| exofs | ||
| exportfs | ||
| ext2 | ||
| ext4 | ||
| f2fs | ||
| fat | ||
| freevxfs | ||
| fscache | ||
| fuse | ||
| gfs2 | ||
| hfs | ||
| hfsplus | ||
| hostfs | ||
| hpfs | ||
| hugetlbfs | ||
| isofs | ||
| jbd2 | ||
| jffs2 | ||
| jfs | ||
| kernfs | ||
| lockd | ||
| minix | ||
| nfs | ||
| nfs_common | ||
| nfsd | ||
| nilfs2 | ||
| nls | ||
| notify | ||
| ntfs | ||
| ocfs2 | ||
| omfs | ||
| openpromfs | ||
| orangefs | ||
| overlayfs | ||
| proc | ||
| pstore | ||
| qnx4 | ||
| qnx6 | ||
| quota | ||
| ramfs | ||
| reiserfs | ||
| romfs | ||
| squashfs | ||
| sysfs | ||
| sysv | ||
| tracefs | ||
| ubifs | ||
| udf | ||
| ufs | ||
| xfs | ||
| Kconfig | -rw-r--r-- | 7.4 KB |
| Kconfig.binfmt | -rw-r--r-- | 7.2 KB |
| Makefile | -rw-r--r-- | 4.2 KB |
| aio.c | -rw-r--r-- | 54.4 KB |
| anon_inodes.c | -rw-r--r-- | 4.5 KB |
| attr.c | -rw-r--r-- | 9.7 KB |
| bad_inode.c | -rw-r--r-- | 5.3 KB |
| binfmt_aout.c | -rw-r--r-- | 10.8 KB |
| binfmt_elf.c | -rw-r--r-- | 63.8 KB |
| binfmt_elf_fdpic.c | -rw-r--r-- | 47.3 KB |
| binfmt_em86.c | -rw-r--r-- | 2.8 KB |
| binfmt_flat.c | -rw-r--r-- | 27.7 KB |
| binfmt_misc.c | -rw-r--r-- | 18.3 KB |
| binfmt_script.c | -rw-r--r-- | 3.0 KB |
| block_dev.c | -rw-r--r-- | 53.8 KB |
| buffer.c | -rw-r--r-- | 89.9 KB |
| char_dev.c | -rw-r--r-- | 16.6 KB |
| compat.c | -rw-r--r-- | 3.4 KB |
| compat_binfmt_elf.c | -rw-r--r-- | 3.4 KB |
| compat_ioctl.c | -rw-r--r-- | 31.0 KB |
| coredump.c | -rw-r--r-- | 21.2 KB |
| d_path.c | -rw-r--r-- | 11.2 KB |
| dax.c | -rw-r--r-- | 45.0 KB |
| dcache.c | -rw-r--r-- | 81.2 KB |
| dcookies.c | -rw-r--r-- | 7.0 KB |
| direct-io.c | -rw-r--r-- | 40.8 KB |
| drop_caches.c | -rw-r--r-- | 1.6 KB |
| eventfd.c | -rw-r--r-- | 10.8 KB |
| eventpoll.c | -rw-r--r-- | 62.8 KB |
| exec.c | -rw-r--r-- | 47.0 KB |
| fcntl.c | -rw-r--r-- | 23.3 KB |
| fhandle.c | -rw-r--r-- | 6.8 KB |
| file.c | -rw-r--r-- | 23.4 KB |
| file_table.c | -rw-r--r-- | 10.0 KB |
| filesystems.c | -rw-r--r-- | 6.2 KB |
| fs-writeback.c | -rw-r--r-- | 70.4 KB |
| fs_pin.c | -rw-r--r-- | 2.0 KB |
| fs_struct.c | -rw-r--r-- | 3.3 KB |
| inode.c | -rw-r--r-- | 56.6 KB |
| internal.h | -rw-r--r-- | 5.0 KB |
| ioctl.c | -rw-r--r-- | 17.7 KB |
| iomap.c | -rw-r--r-- | 53.2 KB |
| libfs.c | -rw-r--r-- | 31.8 KB |
| locks.c | -rw-r--r-- | 73.1 KB |
| mbcache.c | -rw-r--r-- | 12.0 KB |
| mount.h | -rw-r--r-- | 3.9 KB |
| mpage.c | -rw-r--r-- | 21.1 KB |
| namei.c | -rw-r--r-- | 123.0 KB |
| namespace.c | -rw-r--r-- | 84.6 KB |
| no-block.c | -rw-r--r-- | 688 bytes |
| nsfs.c | -rw-r--r-- | 6.2 KB |
| open.c | -rw-r--r-- | 28.4 KB |
| pipe.c | -rw-r--r-- | 26.9 KB |
| pnode.c | -rw-r--r-- | 15.3 KB |
| pnode.h | -rw-r--r-- | 1.9 KB |
| posix_acl.c | -rw-r--r-- | 21.4 KB |
| proc_namespace.c | -rw-r--r-- | 7.8 KB |
| read_write.c | -rw-r--r-- | 49.6 KB |
| readdir.c | -rw-r--r-- | 11.4 KB |
| select.c | -rw-r--r-- | 34.6 KB |
| seq_file.c | -rw-r--r-- | 24.4 KB |
| signalfd.c | -rw-r--r-- | 9.0 KB |
| splice.c | -rw-r--r-- | 39.5 KB |
| stack.c | -rw-r--r-- | 2.5 KB |
| stat.c | -rw-r--r-- | 19.4 KB |
| statfs.c | -rw-r--r-- | 9.7 KB |
| super.c | -rw-r--r-- | 40.4 KB |
| sync.c | -rw-r--r-- | 9.9 KB |
| timerfd.c | -rw-r--r-- | 13.4 KB |
| userfaultfd.c | -rw-r--r-- | 50.3 KB |
| utimes.c | -rw-r--r-- | 7.4 KB |
| xattr.c | -rw-r--r-- | 23.4 KB |
Computing file changes ...
