Skip to main content

Browse the archive

https://github.com/web-platform-tests/wpt
26 December 2018, 22:31:15 UTC
Revision 2ae9561e165d3feb219cd34ee5b0334e91170cfd authored by Hayato Ito on 22 March 2018, 09:56:30 UTC, committed by Chromium WPT Sync on 22 March 2018, 09:56:30 UTC 
Reject customized built-in elements in attachShadow
 
Element::CanAttachShadowRoot() needs to be updated because it returns wrongly true for
customized built-in elements.

The spec: https://dom.spec.whatwg.org/#dom-element-attachshadow

Bug: 823033
Change-Id: Ia9aeb47569414830f5435f37f85d96101b9fe432
Reviewed-on: https://chromium-review.googlesource.com/970142
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545026}
1 parent 74126cb
Raw File
Tip revision: 2ae9561e165d3feb219cd34ee5b0334e91170cfd authored by Hayato Ito on 22 March 2018, 09:56:30 UTC
Reject customized built-in elements in attachShadow
Tip revision: 2ae9561
eventhandlers.html 
<!DOCTYPE html>
<title>WebSocket event handlers</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="websocket.sub.js"></script>
<div id="log"></div>
<script>
function testEventHandler(name) {
  test(function() {
    var ws = new WebSocket("ws://" + __SERVER__NAME + ":" + __PORT + "/" + __PATH,
                           "echo")
    assert_equals(ws["on" + name], null);
    ws["on" + name] = function() {};
    ws["on" + name] = 2;
    assert_equals(ws["on" + name], null);
  }, "Event handler for " + name + " should have [TreatNonCallableAsNull]")
}
["open", "error", "close", "message"].forEach(testEventHandler);
</script>
back to top