Revision 2b684b7e5bd238265a3139f24699e5a5a7a48794 authored by Pete Bacon Darwin on 29 October 2020, 09:45:01 UTC, committed by Misko Hevery on 06 November 2020, 17:09:48 UTC
Tokenized text node may have leading whitespace skipped from their source-span. But the source-span is used to compute where there are interpolated blocks, resulting in placeholder nodes whose source-spans are offset by the amount of skipped characters. This fix uses the `fullStart` location of text source-spans for computing the source-span of placeholders, so that they are accurate. Fixes #39195 PR Close #39589
1 parent ff31b43
yarn.lock.readme.md
All of our npm dependencies are locked via the `yarn.lock` file for the following reasons:
- our project has lots of dependencies which update at unpredictable times, so it's important that
we update them explicitly once in a while rather than implicitly when any of us runs `yarn install`
- locked dependencies allow us to reuse yarn cache on CircleCI, significantly speeding up our builds
(by 5 minutes or more)
- locked dependencies allow us to detect when node_modules folder is out of date after a branch switch
which allows us to build the project with the correct dependencies every time
Before changing a dependency, do the following:
- make sure you are in sync with `upstream/master`: `git fetch upstream && git rebase upstream/master`
- ensure that your `node_modules` directory is not stale by running `yarn install`
To add a new dependency do the following: `yarn add <packagename> --dev`
To update an existing dependency do the following: run `yarn upgrade <packagename>@<version|latest> --dev`
or `yarn upgrade <packagename> --dev` to update to the latest version that matches version constraint
in `package.json`
To Remove an existing dependency do the following: run `yarn remove <packagename>`
Once you've changed the dependency, commit the changes to `package.json` & `yarn.lock`, and you are done.
Computing file changes ...