Revision 2cff98b99c469880ce830cbcde015b53b67e0a7b authored by Dean Nelson on 29 April 2015, 15:09:18 UTC, committed by Will Deacon on 29 April 2015, 16:39:39 UTC
__dma_alloc() does a PAGE_ALIGN() on the passed in size argument before
doing anything else. __dma_free() does not. And because it doesn't, it is
possible to leak memory should size not be an integer multiple of PAGE_SIZE.

The solution is to add a PAGE_ALIGN() to __dma_free() like is done in
__dma_alloc().

Additionally, this patch removes a redundant PAGE_ALIGN() from
__dma_alloc_coherent(), since __dma_alloc_coherent() can only be called
from __dma_alloc(), which already does a PAGE_ALIGN() before the call.

Cc: stable@vger.kernel.org
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Dean Nelson <dnelson@redhat.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
1 parent 6829e27
History
File Mode Size
Makefile -rw-r--r-- 192 bytes
sym53c8xx.h -rw-r--r-- 5.9 KB
sym_defs.h -rw-r--r-- 26.5 KB
sym_fw.c -rw-r--r-- 13.0 KB
sym_fw.h -rw-r--r-- 6.5 KB
sym_fw1.h -rw-r--r-- 44.2 KB
sym_fw2.h -rw-r--r-- 47.9 KB
sym_glue.c -rw-r--r-- 52.7 KB
sym_glue.h -rw-r--r-- 7.2 KB
sym_hipd.c -rw-r--r-- 144.0 KB
sym_hipd.h -rw-r--r-- 33.5 KB
sym_malloc.c -rw-r--r-- 8.6 KB
sym_misc.h -rw-r--r-- 5.0 KB
sym_nvram.c -rw-r--r-- 19.8 KB
sym_nvram.h -rw-r--r-- 6.2 KB

back to top