| 2d14724 | alkavats1 | 05 January 2022, 20:36:10 UTC | docs(common): url link format updated (#44638) fix the url link format from http to https in i18-common-locale-id.md file PR Close #44638 | 05 January 2022, 23:21:10 UTC |
| e39f804 | Kristiyan Kostadinov | 04 January 2022, 20:52:14 UTC | test(upgrade): fix flaky tests (#44597) Fixes a couple of tests that have been flaking our test runs. The two tests actually failed consistently when run in isolation, but they passed if at least one test ran before them. My understanding was that they failed, because they were running outside of the `NgZone` which meant that the errors being thrown inside of a `Promise` weren't being flushed. PR Close #44597 | 05 January 2022, 23:20:43 UTC |
| 12e0424 | Paul Gschwendtner | 17 December 2021, 18:26:47 UTC | ci: temporarily disable components-repo-unit-tests job (#44505) Temporarily disables the components repo unit tests job that breaks due to us changing the devmode output to ES2015 in Angular Bazel. This is a trivial thing to solve in the COMP repo but the job needs to be disabled first, so that the changes can be released. PR Close #44505 | 05 January 2022, 23:20:21 UTC |
| d60ebaa | Paul Gschwendtner | 17 December 2021, 18:26:09 UTC | test: update example di tests to work with es2015 (#44505) * `forwardRef` does not work with ES2015 and TypeScript's decorator downlevel emit. This is a known limitation we work around in Angular applications by either compiling tests with the Angular compiler, or by running a custom decorator downlevel transform (like in the CLI). PR Close #44505 | 05 January 2022, 23:20:21 UTC |
| 807c6a4 | Paul Gschwendtner | 17 December 2021, 18:25:48 UTC | test: update acceptance core tests to work with es2015 (#44505) Updates the acceptance core tests to work with ES2015 devmode output. There were two issues surfacing: * The NodeJS test execution failed because Domino does not handle destructuring syntax properly. This is because `Node.children` is not an iterable. * `forwardRef` does not work with ES2015 and TypeScript's decorator downlevel emit. This is a known limitation we work around in Angular applications by either compiling tests with the Angular compiler, or by running a custom decorator downlevel transform (like in the CLI). PR Close #44505 | 05 January 2022, 23:20:21 UTC |
| 92806ff | Paul Gschwendtner | 16 December 2021, 20:23:55 UTC | test: update router tests to work with es2015 temporal dead zone (#44505) Update router tests to work with the the es2015 temporal dead zone. Somewhat similar to: https://github.com/angular/angular/issues/30106. PR Close #44505 | 05 January 2022, 23:20:20 UTC |
| 890d069 | Paul Gschwendtner | 16 December 2021, 15:32:32 UTC | test: update ngtsc specs to work with es2015 output (#44505) Updates the ngtsc specs to work with ES2015 output. PR Close #44505 | 05 January 2022, 23:20:20 UTC |
| c46d533 | Paul Gschwendtner | 16 December 2021, 13:11:53 UTC | build: switch devmode output to es2015 (#44505) To make our test output i.e. devmode output more aligned with what we produce in the NPM packages, or to be more aligned with what Angular applications will usually consume, the devmode output is switched from ES5 to ES2015. Additionally various tsconfigs (outside of Bazel) have been updated to match with the other parts of the build. The rules are: ES2015 for test configurations, ES2020 for actual code that will end up being shipped (this includes the IDE-only tsconfigs). PR Close #44505 | 05 January 2022, 23:20:20 UTC |
| 8388151 | Andrew Kushnir | 15 December 2021, 23:10:33 UTC | refactor(forms): make validators code compatible with property renaming (#44500) This commit refactors the code of the base validators class to make it compatible with the property renaming optimization. Currently the code makes an assumption that the field with a specified name (defined as a string) can be found on an object, but with property renaming optimization this is not correct. PR Close #44500 | 05 January 2022, 18:43:36 UTC |
| 6a55aff | Chris Mancini | 05 January 2022, 16:42:24 UTC | docs(router): fix code block for IsActiveMatchOptions (#44635) PR Close #44635 | 05 January 2022, 17:47:08 UTC |
| 7278a9c | Dario Piotrowicz | 21 December 2021, 21:24:18 UTC | docs(animations): fix filter-animations docregion (#44544) the filter animation example in the complex-animation-sequences guide talks about entering and leaving elements, but the presented html snipped exluded the *ngFor which actually adds and removes the elements, so add the *ngFor section to make the example complete and understandable PR Close #44544 | 05 January 2022, 17:46:10 UTC |
| d5ced77 | Dario Piotrowicz | 19 December 2021, 18:43:44 UTC | refactor(docs-infra): fix eslint issues for aio ugrade-* examples (#44534) fix the eslint issues in the aio/content/examples/upgrade-* folders and remove their ignorePattern in the examples eslintrc file PR Close #44534 | 05 January 2022, 00:34:06 UTC |
| c7ac2df | JoostK | 08 December 2021, 21:49:43 UTC | refactor(compiler): remove output AST functions (#44411) These functions are not used anymore so they are removed. PR Close #44411 | 04 January 2022, 23:54:10 UTC |
| d196cbc | JoostK | 08 December 2021, 21:47:36 UTC | refactor(compiler): remove class related output AST types (#44411) The Ivy compiler no longer generates classes so this commit removes the supporting output nodes. PR Close #44411 | 04 January 2022, 23:54:10 UTC |
| 8cadfe1 | JoostK | 08 December 2021, 21:42:12 UTC | refactor(compiler): remove type-casting related output AST types (#44411) The Ivy compiler no longer generates code for type-checking purposes using the output AST types. Instead, it uses TypeScript AST nodes and its printer for type-checking. This commit removes the type-related output nodes. PR Close #44411 | 04 January 2022, 23:54:10 UTC |
| f352c2b | JoostK | 08 December 2021, 21:33:57 UTC | refactor(compiler): remove some unused output AST types (#44411) This kind of output is no longer emitted into generated code, so the supporting output AST is removed. PR Close #44411 | 04 January 2022, 23:54:10 UTC |
| e0458a6 | JoostK | 08 December 2021, 21:18:31 UTC | refactor(compiler): remove unused method from binding parser (#44411) This method is no longer called so is being removed. PR Close #44411 | 04 January 2022, 23:54:10 UTC |
| b5ad12b | JoostK | 08 December 2021, 21:17:42 UTC | refactor(compiler): make template preparser null-safe (#44411) This commit removes some non-null assertion operations to improve null-safety. PR Close #44411 | 04 January 2022, 23:54:10 UTC |
| f40802f | JoostK | 08 December 2021, 21:14:32 UTC | refactor(compiler): remove unused `unsupported` function (#44411) This function is no longer used so is being removed. PR Close #44411 | 04 January 2022, 23:54:10 UTC |
| d9befd2 | JoostK | 08 December 2021, 21:07:52 UTC | refactor(compiler): make `keySpan` required in binding parser (#44411) Now that ViewEngine has been removed the `keySpan` property can be made required, as it is always provided in the Ivy compiler PR Close #44411 | 04 January 2022, 23:54:10 UTC |
| f86e02e | JoostK | 08 December 2021, 20:55:14 UTC | refactor(compiler): cleanup distinction in parse logic (#44411) This removes the special casing of parse-validation logic that was only used by Ivy. PR Close #44411 | 04 January 2022, 23:54:10 UTC |
| a758b88 | JoostK | 08 December 2021, 20:47:58 UTC | refactor(compiler): remove `BindingForm` enum (#44411) The Ivy compiler only uses `BindingForm.Expression`, so all other variants are removed. PR Close #44411 | 04 January 2022, 23:54:10 UTC |
| da159a5 | JoostK | 08 December 2021, 20:44:56 UTC | refactor(compiler): cleanup AST fixup of listener instructions (#44411) This commit refactors the generation of listener instructions to no longer fixup the output AST that was designed for ViewEngine. PR Close #44411 | 04 January 2022, 23:54:09 UTC |
| 7862f56 | JoostK | 08 December 2021, 18:48:00 UTC | refactor(compiler): remove unused assertion function (#44411) This code is no longer used now that ViewEngine has been removed. PR Close #44411 | 04 January 2022, 23:54:09 UTC |
| e8812bc | JoostK | 08 December 2021, 18:45:59 UTC | refactor(compiler): cleanup unsafe usage of `null` value for ng-content selector (#44411) This commit improves the null-safety of the ng-content selector and updates a comment that turned out to be slightly inaccurate. Closes #38407 PR Close #44411 | 04 January 2022, 23:54:09 UTC |
| 722d8ef | JoostK | 08 December 2021, 18:35:18 UTC | refactor(compiler): remove unused code from output logic (#44411) This code is no longer used now that ViewEngine has been removed. PR Close #44411 | 04 January 2022, 23:54:09 UTC |
| 26eee35 | JoostK | 08 December 2021, 18:26:36 UTC | refactor(compiler): remove unused `AstPath` (#44411) This code is no longer used now that ViewEngine has been removed. PR Close #44411 | 04 January 2022, 23:54:09 UTC |
| a0c36ac | JoostK | 01 December 2021, 23:35:54 UTC | refactor(compiler): remove unused logic from `ConstantPool` (#44411) The `ConstantPool.getDefinition` method is not being used anymore, so this commit removes anything that is related to this method. PR Close #44411 | 04 January 2022, 23:54:09 UTC |
| f3de922 | JoostK | 08 December 2021, 18:24:36 UTC | refactor(compiler): remove unused type declarations (#44411) This code is no longer used now that ViewEngine has been removed. PR Close #44411 | 04 January 2022, 23:54:09 UTC |
| 1d39a5e | JoostK | 08 December 2021, 18:17:57 UTC | refactor(compiler): remove syntax error logic (#44411) This code is no longer used now that ViewEngine has been removed. PR Close #44411 | 04 January 2022, 23:54:09 UTC |
| f2b858d | dario-piotrowicz | 15 December 2021, 13:39:15 UTC | refactor(animations): add unit test for leaving animated child (#44489) add a new unit test to make sure that leaving elements queried via a parent queried via animateChild are correctly removed note: this tests the fix introduced in PR #44357 PR Close #44489 | 04 January 2022, 23:53:36 UTC |
| d4015f7 | Andrew Kushnir | 04 January 2022, 19:03:43 UTC | test: remove newlines to make a test more stable (#44616) One of the tests was not taking into account newlines in the text content of an element, thus failing in some browsers. This commit makes the test more stable by removing newlines and comparing the output after that. PR Close #44616 | 04 January 2022, 23:53:00 UTC |
| a864d1c | dario-piotrowicz | 13 December 2021, 22:46:40 UTC | fix(docs-infra): adjust code link styling height (#44376) the height of code links (anchors inside code tags or code tags inside anchors) is inconsistent, fix such issue by also making sure that code links to external resources do not get wrongly styled PR Close #44376 | 04 January 2022, 20:19:08 UTC |
| 7663dd0 | dario-piotrowicz | 04 December 2021, 13:48:11 UTC | docs(animations): add links to `state()` references (#44376) the keyword 'state' is included in the `ignoredWords` set that prevents certain words to be autolinked, this causes the animations' state function not to be automatically linked, so manually link those references to the state api docs PR Close #44376 | 04 January 2022, 20:19:08 UTC |
| 5ae1030 | Dylan Hunn | 13 December 2021, 19:52:08 UTC | feat(forms): Add an unused symbol `AnyForUntypedForms`. (#44467) This symbol will support the typed forms migration in google3. The docs will be updated once the migration begins. Pertains to #13721. PR Close #44467 | 04 January 2022, 20:18:26 UTC |
| f0b4c70 | Abdurrahman Abu-Hijleh | 16 December 2021, 21:56:42 UTC | docs: fix code sample indentation (#44517) PR Close #44517 | 04 January 2022, 20:15:55 UTC |
| ed6e2d2 | AlirezaEbrahimkhani | 30 December 2021, 14:25:41 UTC | docs: fix ngOnChange description issue (#44582) ngOnChange respond when Angular sets or resets data-bound @input properties and description of the ngOnChanges should be `When an [input](#input) binding value changes` instead of `When an [input](#input)/[output](#output) binding value changes` resolves angular#44559 PR Close #44582 | 04 January 2022, 20:15:18 UTC |
| bfd94b3 | huangqing | 15 December 2021, 07:16:45 UTC | docs: Replace OnInit with AfterViewInit (#44485) `this.adHost` is undefined if loadComponent is called in OnInit. So replace OnInit with AfterViewInit! PR Close #44485 | 04 January 2022, 20:14:44 UTC |
| 3a29c57 | Paul Gschwendtner | 15 December 2021, 18:31:20 UTC | test: update size goldens to reflect latest CLI devkit update (#44490) Updates the size goldens to the reflect the latest CLI devkit updates. PR Close #44490 | 04 January 2022, 20:14:14 UTC |
| 7974564 | Paul Gschwendtner | 15 December 2021, 15:34:07 UTC | build: update release config to reflect latest ng-dev config changes (#44490) The ng-dev release config changed its release configuration in order to support experimental packages. This commit updates the FW release config to work with the new config signature of ng-dev. All of our peackages are non-experimental, so we do not specify an explicit `experimental` property. PR Close #44490 | 04 January 2022, 20:14:14 UTC |
| c8cd5d5 | Paul Gschwendtner | 15 December 2021, 15:22:01 UTC | build: switch all instances from `ng_rollup_bundle` to `app_bundle` (#44490) The `ng_rollup_bundle` rule has been replaced with a new rule called `app_bundle`. This rule replicates the Angular v13 optimization pipeline in the CLI, so that we can get better benchmarking results. Also the rule is much simpler to maintain as it relies on ESbuild. The old `ng_rollup_bundle` rule did rely on e.g. build-optimizer that no longer has an effect on v13 Angular packages, so technically size tests/symbol tests were no longer as correct as they were before. This commit fixes that. A couple of different changes and their explanation: * Language-service will no longer use the benchmark rule for creating its NPM bundles! It will use plain `rollup_bundle`. ESBuild would have been nice but the language-service relies on AMD that ESBuild cannot generate (yet?) * Service-worker ngsw-worker.js file was generated using the benchmark bundle rule. This is wrong. We will use a simple ESbuild rule in the future. The output is more predictable that way, and we can have a clear use of the benchmark bundle rule.. * A couple of benchmarks in `modules/` had to be updated to use e.g. `initTableUtils` calls. This is done because with the new rule, all files except for the entry-point are considered side-effect free. The utilities for benchmarks relied on side-effects in some transitively-loaded file (bad practice anyway IMO). We are now initializing the utilities using a proper init function that is exported... PR Close #44490 | 04 January 2022, 20:14:14 UTC |
| 4e58a50 | Paul Gschwendtner | 15 December 2021, 15:18:06 UTC | build: update postinstall script to account for local target references in dev-infra (#44490) We are in an inconvenient situation where the ng-dev package might rely on packages from the Angular framework repository. Given that we install this package in the framework repository, we need to update some references through a postinstall. This commit updates the patches to account for the latest changes in the dev-infra package/repository. PR Close #44490 | 04 January 2022, 20:14:14 UTC |
| d73c716 | Paul Gschwendtner | 15 December 2021, 15:16:29 UTC | build: add postinstall script as runfile for `yarn_install` repository rule (#44490) Adds the postinstall script as runfile for the `yarn_install` repository rule, so that the dependencies are re-fetched when the script changes. PR Close #44490 | 04 January 2022, 20:14:14 UTC |
| c3a5568 | Paul Gschwendtner | 15 December 2021, 15:14:31 UTC | build: update symbol extractor to support IIFE bundles using arrow-functions (#44490) Updates the symbol extractor to support IIFE bundles using arrow-functions instead of function declarations. This is in preparation for running symbol extraction tests with the overhauled optimization pipeline for Angular v13, relying on ESBuild internally. Also removes rollup-specific code that does not seem to be relevant anymore / rollup will be replaced anyway. PR Close #44490 | 04 January 2022, 20:14:14 UTC |
| 02bc458 | Paul Gschwendtner | 13 December 2021, 17:48:47 UTC | build: update angular (#44490) Updates Angular and the dev-infra package to the latest version/build. PR Close #44490 | 04 January 2022, 20:14:14 UTC |
| 9d2401d | Borja Paz RodrÃguez | 16 December 2021, 15:58:17 UTC | docs: fix several typos (#44508) PR Close #44508 | 04 January 2022, 20:13:46 UTC |
| 67c81cc | Dario Piotrowicz | 19 December 2021, 11:45:22 UTC | refactor(docs-infra): improve aio-footer's layout (#44532) improve aio-footer's layout by using grid instead of flexbox, such change makes it so that we have four columns on wide window sizes (desktop), two columns on medium window sizes (desktop/tablet) and a single column on small window sizes (mobile), compared to the flex implementation which could only have either 4 columns or 1 this makes the footer look generally nicer for various window sizes (especially in the middle range in which one column was too little and four were too much) note: also a scroll of auto has been added so we that we can be sure that overflowing footer content never creates a global layout issue PR Close #44532 | 04 January 2022, 20:13:22 UTC |
| f7aa937 | Dylan Hunn | 20 December 2021, 22:37:52 UTC | fix(forms): Make some minor fixups for forward-compatibility with typed forms. (#44540) Make the following fixes: * When submitting the entire migration in a disabled state, I commented out more code than strictly required * Responding to some final review comments caused two conditions to become flipped * Always use explicit checks instead of boolean corecion * Fix one missed any cast in a test case PR Close #44540 | 04 January 2022, 20:10:56 UTC |
| 7cb2999 | Yousaf Nawaz | 29 December 2021, 13:38:41 UTC | docs: add missing npm install instruction (#44574) add missing npm install instruction to start->deploying an application Fixes #44542 PR Close #44574 | 04 January 2022, 20:07:37 UTC |
| 756761d | ivanwonder | 18 December 2021, 01:25:01 UTC | fix(language-service): revert the test files for Ivy (#44528) The `completions_spec` and `definitions_spec` is removed by accident in [bb9ff60](https://github.com/angular/angular/commit/bb9ff6003c620b3cf00232189d60097395382802) PR Close #44528 | 04 January 2022, 20:06:49 UTC |
| 4f7a838 | Andrew Scott | 16 December 2021, 23:10:26 UTC | docs: Add breaking changes note to 13.0 release (#44518) A breaking change in v13 was identified post-release and needs to be noted in the breaking changes section to ensure developers are aware of it when upgrading. Resolves #44383 PR Close #44518 | 04 January 2022, 20:06:27 UTC |
| a8f153c | Yousaf Nawaz | 29 December 2021, 14:06:42 UTC | docs(docs-infra): fix numbering of 'running your application locally' steps (#44575) fix numbering of 'running your application locally' steps and corrected step 1 statement. PR Close #44575 | 04 January 2022, 20:06:07 UTC |
| 62a5027 | Serhey Dolgushev | 30 December 2021, 15:32:48 UTC | docs: fixed meetup URL (#44585) PR Close #44585 | 04 January 2022, 20:05:45 UTC |
| 79d1afa | Adam Plumer | 01 January 2022, 06:22:12 UTC | build: bump license year (#44590) The year has advanced by one cycle. In accordance with this practice, we increment the value of the bounding set of our license year by one. PR Close #44590 | 04 January 2022, 20:05:25 UTC |
| ca042be | George Kalpakas | 03 January 2022, 16:30:28 UTC | docs: update instructions for running `ng-dev misc build-and-link` command (#44604) Fixes #44571 PR Close #44604 | 04 January 2022, 20:05:04 UTC |
| 6cdd66d | zuckjet | 03 January 2022, 03:23:48 UTC | docs(compiler): fix typo in `getHtmlTagDefinition()` function (#44601) PR Close #44601 | 04 January 2022, 20:04:04 UTC |
| a01c077 | JoostK | 04 January 2022, 11:45:41 UTC | docs: remove Angular 10 from support table (#44611) PR Close #44611 | 04 January 2022, 20:03:37 UTC |
| af512de | Yousaf Nawaz | 04 January 2022, 12:12:00 UTC | docs: fix invalid link of library support for npm packages guide (#44612) change link of library support to point to guide->creating-libraries fixes #44583 PR Close #44612 | 04 January 2022, 20:03:15 UTC |
| c6c75c9 | Chihab Otmani | 01 January 2022, 12:02:45 UTC | docs: fix typo (#44592) PR Close #44592 | 04 January 2022, 18:59:58 UTC |
| 58e8f5e | Andrew Scott | 20 December 2021, 16:32:48 UTC | ci: remove atscott for unavailable users (#44539) I am back from vacation so I can now be assigend PRs to review PR Close #44539 | 04 January 2022, 18:38:42 UTC |
| 8ebc946 | Joey Perrott | 16 December 2021, 18:12:33 UTC | docs: remove recent departures from contributors page (#44514) PR Close #44514 | 16 December 2021, 19:29:29 UTC |
| 28eecf5 | Alex Rickabaugh | 15 December 2021, 20:15:45 UTC | release: cut the v13.2.0-next.1 release (#44497) PR Close #44497 | 15 December 2021, 20:21:51 UTC |
| 5370c20 | Alex Rickabaugh | 15 December 2021, 19:44:08 UTC | docs: release notes for the v13.1.1 release (#44496) PR Close #44496 | 15 December 2021, 20:00:04 UTC |
| 7c246d5 | Kristiyan Kostadinov | 15 December 2021, 11:39:51 UTC | fix(docs-infra): update examples to Angular 13.1 (#44487) Updates AIO and the live examples to 13.1.0 in order to resolve a build error when opened on Stackblitz. They were using TS 4.5 with Angular ~13.0.0 which doesn't support 4.5. Fixes #44480. PR Close #44487 | 15 December 2021, 18:22:14 UTC |
| 9921b2c | Dylan Hunn | 11 December 2021, 23:26:19 UTC | feat(core): Add a migration for typed forms. (#44449) This migration will insert `<AnyForUntypedForms>` or `<AnyForUntypedForms[]>` at existing uses of `AbstractControl` classes, as well as calls to `FormBuilder` methods. We need to submit this ahead of time in order to get started with the migration in google3. PR Close #44449 | 15 December 2021, 18:20:33 UTC |
| 835987b | dario-piotrowicz | 05 December 2021, 10:36:03 UTC | refactor(docs-infra): use eslint in aio's example-lint script (#43218) Instead of the deprecated tslint use eslint in the aio's example-lint script PR Close #43218 | 15 December 2021, 17:28:46 UTC |
| 6a0dadf | Dylan Hunn | 14 December 2021, 23:54:48 UTC | fix(forms): `_reduceValue` arrow function now has correct types. (#44483) I previously strengthened some weak types in #44370. One of these fixes exposed an incorrect call into `_reduceChildren` from `_reduceValue`. This was caught in google3 by a caller who was extending `FormGroup` and overriding these methods. Special thanks to Bart G for catching this issue and suggesting a fix. PR Close #44483 | 15 December 2021, 17:27:06 UTC |
| 72092eb | Dylan Hunn | 10 December 2021, 21:56:17 UTC | feat(forms): Allow a FormControl to use initial value as default. (#44434) Allow a FormControl to be reset to its initial value. Provide this feature via a new option in a FormControlOptions interface, based on AbstractControlOptions. Also, expose the default value as part of the public API. This is part of a feature that has been requested elsewhere (e.g. in #19747). This was originally proposed as part of typed forms. As discussed in the GDE session (and after with akushnir/alxhub), it is likely better to just reuse the initial value rather than accepting an additional default. It is desirable to land this separately in order to reduce the scope of the typed forms PR, and make it a types-only change. Pertains to issue #13721. PR Close #44434 | 15 December 2021, 15:36:13 UTC |
| 4aa6965 | Dylan Hunn | 14 December 2021, 18:07:02 UTC | test(docs-infra): Correct an invalid assumption in aio tests. (#44479) The aio application expects `FormControl` to have no properties for the purposes of its own internal tests, but this is no longer true after #44434. PR Close #44479 | 14 December 2021, 21:14:47 UTC |
| 093fd39 | Kristiyan Kostadinov | 14 December 2021, 13:35:40 UTC | refactor(compiler): clean up workarounds for TypeScript 4.5 (#44477) Cleans up some of the temporary workarounds that were necessary in order to land support for TypeScript 4.5 since they're no longer necessary. PR Close #44477 | 14 December 2021, 21:14:02 UTC |
| d640fa7 | Spej | 13 December 2021, 12:15:48 UTC | docs: Fixed typo 'test' => 'text' (#44464) PR Close #44464 | 14 December 2021, 21:12:57 UTC |
| f394831 | dario-piotrowicz | 12 December 2021, 22:22:23 UTC | refactor(animations): remove the unused enter and leave selectors (#44460) remove the no longer used ENTER_SELECTOR and LEAVE_SELECTOR constants note: their uses have been removed in PR #19455 PR Close #44460 | 14 December 2021, 21:12:35 UTC |
| f56ac0f | dario-piotrowicz | 12 December 2021, 18:31:50 UTC | refactor(animations): improve _finalKeyframe non-null assertion (#44458) instead of declaring the WebAnimationsPlayer's _finalKeyframe field with a non-null assertion, declare it as optional field and use a non-null assertion only when it is being used in the beforeDestroy function relates to #24571 PR Close #44458 | 14 December 2021, 21:12:11 UTC |
| 5da31d6 | Dylan Hunn | 12 December 2021, 01:46:49 UTC | test(forms): Add more tests for `FormBuilder` method argument shapes. (#44452) It is possible to pass arguments to `FormBuilder` using four different formats: value-only, boxed value, control config, and value-array. Currently, these different methods are not well-tested, especially as they interact. This PR will add tests for the variety of different argument shapes. This was originally inspired by typed forms: when `FormBuilder` becomes typed, all these argument shapes should just work, with correct inferred types. PR Close #44452 | 14 December 2021, 21:11:29 UTC |
| 6571799 | Dylan Hunn | 12 December 2021, 01:36:31 UTC | refactor(forms): Make the minimum changes to the forms unit tests in order to support the typed forms PR (#43834). (#44451) Currently, many of our unit tests are written to use heterogenous groups and arrays, and controls that accept heterogenous values. This PR will make the minimum possible alterations to prepare those usages, mainly by annotating them as untyped controls, etc. This PR is *not* intended to test typed forms, merely to minimize the size of the upcoming PR. This will allow that PR to be focused on the actual features and tests, rather than boilerplate fixes. PR Close #44451 | 14 December 2021, 21:10:08 UTC |
| 815d4ce | Dylan Hunn | 12 December 2021, 01:07:45 UTC | fix(forms): I indroduced a minor error in a previous PR: pendingValue is a value not a boolean flag. (#44450) The bug should have no effect since it's a typings-only, internal-only bug, but it's good to fix nonetheless. PR Close #44450 | 14 December 2021, 21:09:42 UTC |
| e483993 | JoostK | 11 December 2021, 22:55:48 UTC | test(ngcc): don't use the workspace typescript version to generate integration test fixtures (#44448) Now that ViewEngine libraries can no longer be created, the latest TypeScript version that ngcc should be able to process is TypeScript 4.3, i.e. the version of TypeScript that was supported in Angular 12. However, ngcc's integration tests used the TypeScript version of the workspace to create the JavaScript files from TypeScript sources on demand. This introduces friction when upgrading the TypeScript version within the workspace, as changes to TypeScript's emit format may affect ngcc's ability to process it correctly. The on demand creation of JavaScript files was convenient for authoring tests, but it also helped to detect incompatibilities with newer versions of TypeScript. Now that ngcc no longer has to process newer versions of TypeScript, we want to pin the integration suite to use JavaScript code as if it were compiled using TypeScript 4.3, i.e. a version of TypeScript that is actually supported by ngcc. This commit updates the integration test to inline all the generated files directly in the tests, instead of compiling them on demand. This was done by temporarily installing TypeScript 4.3 and using it to create the `loadTestFiles` statement from the original TypeScript inputs. An alternative could have been to install TypeScript 4.3 as an actual dependency in the workspace and using that to continue compiling the integration suite on demand, but this brings some overhead in package installations (TypeScript is ~60MB) and the authoring aspect of ngcc integration test is expected to diminish, now that ngcc's support is no longer a moving target. PR Close #44448 | 14 December 2021, 21:08:28 UTC |
| ab2248e | Yousaf Nawaz | 11 December 2021, 15:59:30 UTC | docs(docs-infra): change variable names in route guards examples (#44444) change variable name 'next' to 'route' in route guards examples on developer guides "Routing and Navigation Tutorial: Adding routing to Tour of Heroes" to make it consistent with api docs and subsequent examples. Fixes #44291 PR Close #44444 | 14 December 2021, 21:08:05 UTC |
| 12f7c85 | faso-dev | 10 December 2021, 13:39:13 UTC | docs: fix typo (#44427) `name` instead of `id` PR Close #44427 | 14 December 2021, 21:07:22 UTC |
| c68385a | jaybell | 09 December 2021, 20:37:56 UTC | docs: add jaybell to gde list (#44423) PR Close #44423 | 14 December 2021, 21:06:32 UTC |
| 030747a | Aristeidis Bampakos | 08 December 2021, 20:40:04 UTC | docs: update Aristeidis Bampakos bio (#44410) PR Close #44410 | 14 December 2021, 21:06:06 UTC |
| 38ddae1 | dario-piotrowicz | 02 December 2021, 23:01:16 UTC | fix(animations): don't consume instructions for animateChild (#44357) TODO: Fill body commit if PR gets accepted resolves #41483 resolves #30693 PR Close #44357 | 14 December 2021, 21:05:35 UTC |
| bab7ed3 | zuckjet | 25 June 2020, 04:23:58 UTC | fix(animations): should not invoke disabled child animations (#37724) Currently child animation will be triggered by `animateChild()` despite it has been disabled. These changes add some logic to prevent that unexpected behavior. PR Close #37724 PR Close #37724 | 14 December 2021, 21:05:00 UTC |
| 6c05c3f | Renovate Bot | 13 December 2021, 19:29:48 UTC | build: update all non-major dependencies (#44152) PR Close #44152 | 14 December 2021, 21:04:34 UTC |
| 7df9127 | Dylan Hunn | 03 December 2021, 18:33:53 UTC | refactor(forms): Fix weak helper types in the Forms package, mostly `Function` types that can be strengthened to specific callbacks. This was originally proposed as part of Typed Forms, but it may be possible to submit at least some of these changes separately and unconditionally (i.e. without relying on `TypedOrUntyped`.) (#44370) It is desirable to land this separately to reduce the scope of the Typed Forms PR, by focusing it only on the new type parameters (rather than incidental strictness fixes). PR Close #44370 | 10 December 2021, 22:13:24 UTC |
| 78bdb1f | Renovate Bot | 07 December 2021, 08:47:59 UTC | build: update dependency google-closure-compiler to v20211201 (#44392) PR Close #44392 | 10 December 2021, 21:39:42 UTC |
| 7b6ca4c | Renovate Bot | 03 December 2021, 11:11:26 UTC | build: update angular (#44273) PR Close #44273 | 10 December 2021, 21:39:05 UTC |
| 9249506 | dario-piotrowicz | 07 December 2021, 22:48:33 UTC | docs(animations): improve animation transition api docs (#44396) improve the transition api docs by removing unnecessary examplanations and examples also provide helpful information regarding entering and leaving elements (as part of #44253) PR Close #44396 | 10 December 2021, 21:34:00 UTC |
| 944b670 | Paul Gschwendtner | 10 December 2021, 17:22:07 UTC | build: remove unused starlark file that is no longer used (#44430) Cleans up an unused Starlark file used by the old integration test setup. PR Close #44430 | 10 December 2021, 21:31:04 UTC |
| f51b009 | Paul Gschwendtner | 09 December 2021, 21:45:07 UTC | build: fix integration test size trackings not running after recent refactoring (#44430) Fixes that the integration test size trackings stopped working due to the recent refactorings (switch to the rule from `@angular/dev-infra-private`). The size-tracking does not integrate very-well into Bazel and needs a better solution in the future, allowing for RBE and Windows support, but currently with the new rule/setup/structure the tracking does not validate sizes because: * The `dist/*.js` argument to the tracking script got expanded and messed up the indices. It should be passed as a literal. This now surfaced because the new rule runs commands in a shell. * The name for the size goldens were not computed properly because they were based on `ctx.attr.name`, but given the new structure, the test targets are always named `test`. PR Close #44430 | 10 December 2021, 21:31:04 UTC |
| a7c117a | Alex Rickabaugh | 09 December 2021, 18:24:28 UTC | release: cut the v13.2.0-next.0 release (#44422) PR Close #44422 | 09 December 2021, 18:25:28 UTC |
| 79baf7a | Alex Rickabaugh | 09 December 2021, 18:12:56 UTC | Revert "release: cut the v13.2.0-next.0 release (#44421)" This reverts commit e3f4360ebf48baf0d9cc60b46f7f9b5162b44ac4. More issues with transient yarn errors during the release. | 09 December 2021, 18:12:56 UTC |
| e3f4360 | Alex Rickabaugh | 09 December 2021, 18:09:55 UTC | release: cut the v13.2.0-next.0 release (#44421) PR Close #44421 | 09 December 2021, 18:11:13 UTC |
| 532d7d4 | Alex Rickabaugh | 09 December 2021, 17:12:14 UTC | docs: release notes for the v13.1.0 release (#44419) PR Close #44419 | 09 December 2021, 17:14:39 UTC |
| cab7a84 | Alex Rickabaugh | 09 December 2021, 16:21:55 UTC | release: bump the next branch to v13.2.0-next.0 | 09 December 2021, 16:21:55 UTC |
| 2664bc2 | Paul Gschwendtner | 20 November 2021, 16:23:07 UTC | test: switch integration tests from puppeteer/webdriver-manager to Bazel-managed chromium (#44238) Switches the integration tests form Puppeteer/webdriver-manager to the Bazel-managed Chromium/Chromedriver. This is now possible with the new integration test rule for which we can consult the `dev-infra/bazel/browsers` toolchain and setup environment variables. This has been configured already in a previous commit. This commit also includes some additional small cleanups necessary for the new integration test rule: * The `test.sh` scripts have been renamed as they would conflict with the `test.sh` scripts generated by the integration test rule. Previously this was not an issue because tests were declared at a higher-level. As mentioned though this has other downsides and it is trivial to rename the file. * Related to the point above, since tests are now declared witin the actual test folder (for perf e.g.), `package.json` files setting `"type": "module"` will accidentally cause the `nodejs_test`-generated files to be considered ESM. This is not correct and likely needs to be fixed upstream in `rules_nodejs` where explicit `.cjs` extensions should be used. This is only happening **once** in the `injectable-def` test so it is acceptable doing that for now. PR Close #44238 | 08 December 2021, 18:42:42 UTC |
| 5837fbd | Paul Gschwendtner | 20 November 2021, 16:17:23 UTC | refactor: setup bazel integration test with new integration rule (#44238) Sets up the Bazel integration test with the new integration rule. This commit is separate from the other changes because it required some additional work. i.e. The test has moved from `integration/bazel` to `integration/<..>/bazel` where `<..>` is a new Bazel package defining the integration test. This is necessary because we could not declare the integration test within the `BUILD.bazel` file actually being part of the nested bazel workspace. In those cases we can just define it at a higher-level and use integration test `working_dir` attribute. PR Close #44238 | 08 December 2021, 18:42:41 UTC |
| 64fd824 | Paul Gschwendtner | 20 November 2021, 16:15:22 UTC | build: setup test targets for integration tests with new rule (#44238) Sets up the test targets for integration tests with the new rule. The targets will match the configuration of the previous integration test setup (through the dictionary in a `bzl` file). Note: We already add `setup_chromium` based on whether Chromium tests run as part of this integration test. In a follow-up commit we can then remove puppeteer and rely on the Bazel-managed version of Chromium. PR Close #44238 | 08 December 2021, 18:42:41 UTC |
| 98c5063 | Paul Gschwendtner | 20 November 2021, 16:09:10 UTC | build: update visibility for npm package targets to work with new integration test structure (#44238) As mentioned in the previous commit, integration tests will be declared in subpackages of `//integration`. For these tests to still rely on the NPM packages from `HEAD`, we need to update the visibility. PR Close #44238 | 08 December 2021, 18:42:41 UTC |
| 6c0905d | Paul Gschwendtner | 20 November 2021, 16:06:21 UTC | build: wire up integration test rule from shared dev-infra package (#44238) Wires up the integration test rule from the shared dev-infra package, while also deleting the old integration test rule. The readme is updated to reflect the changes that are being made to run with the new integration rule. Overall one major difference is that we will declare the integration test targets within each test directory, making those actual bazel packages. This is more idiomatic within Bazel and also reduces the computation within Skyframe as less globs need to be evaluated for example. PR Close #44238 | 08 December 2021, 18:42:41 UTC |
