https://github.com/torvalds/linux
Revision 2d5ba0e2de24ec87636244a01d4e78d095cc1b20 authored by Ming Lei on 02 August 2018, 17:49:37 UTC, committed by Jens Axboe on 02 August 2018, 20:47:20 UTC
Commit d250bf4e776ff09d5("blk-mq: only iterate over inflight requests
in blk_mq_tagset_busy_iter") uses 'blk_mq_rq_state(rq) == MQ_RQ_IN_FLIGHT'
to replace 'blk_mq_request_started(req)', this way is wrong, and causes
lots of test system hang during booting.

Fix the issue by using blk_mq_request_started(req) inside bt_tags_iter().

Fixes: d250bf4e776ff09d5 ("blk-mq: only iterate over inflight requests in blk_mq_tagset_busy_iter")
Cc: Josef Bacik <josef@toxicpanda.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Mark Brown <broonie@kernel.org>
Cc: Matt Hart <matthew.hart@linaro.org>
Cc: Johannes Thumshirn <jthumshirn@suse.de>
Cc: John Garry <john.garry@huawei.com>
Cc: Hannes Reinecke <hare@suse.com>,
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Cc: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: linux-scsi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Reported-by: Mark Brown <broonie@kernel.org>
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent 5151842
History
Tip revision: 2d5ba0e2de24ec87636244a01d4e78d095cc1b20 authored by Ming Lei on 02 August 2018, 17:49:37 UTC
blk-mq: fix blk_mq_tagset_busy_iter
Tip revision: 2d5ba0e
File Mode Size
Kconfig -rw-r--r-- 892 bytes
Makefile -rw-r--r-- 458 bytes
aaci.c -rw-r--r-- 24.8 KB
aaci.h -rw-r--r-- 6.9 KB
pxa2xx-ac97-lib.c -rw-r--r-- 8.7 KB
pxa2xx-ac97.c -rw-r--r-- 6.8 KB
pxa2xx-pcm-lib.c -rw-r--r-- 4.9 KB
pxa2xx-pcm.c -rw-r--r-- 2.9 KB
pxa2xx-pcm.h -rw-r--r-- 828 bytes

back to top