https://github.com/torvalds/linux
Revision 2df485a774ba59c3f43bfe84107672c1d9b731a0 authored by Trond Myklebust on 08 December 2010, 03:39:17 UTC, committed by Trond Myklebust on 08 December 2010, 04:02:44 UTC
When a nfs_page is freed, nfs_free_request is called which also calls nfs_clear_request to clean out the lock and open contexts and free the pagecache page. However, a couple of places in the nfs code call nfs_clear_request themselves. What happens here if the refcount on the request is still high? We'll be releasing contexts and freeing pointers while the request is possibly still in use. Remove those bare calls to nfs_clear_context. That should only be done when the request is being freed. Note that when doing this, we need to watch out for tests of req->wb_page. Previously, nfs_set_page_tag_locked() and nfs_clear_page_tag_locked() would check the value of req->wb_page to figure out if the page is mapped into the nfsi->nfs_page_tree. We now indicate the page is mapped using the new bit PG_MAPPED in req->wb_flags . Reported-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
1 parent 0de1b7e
Tip revision: 2df485a774ba59c3f43bfe84107672c1d9b731a0 authored by Trond Myklebust on 08 December 2010, 03:39:17 UTC
nfs: remove extraneous and problematic calls to nfs_clear_request
nfs: remove extraneous and problematic calls to nfs_clear_request
Tip revision: 2df485a
| File | Mode | Size |
|---|---|---|
| Documentation | ||
| arch | ||
| block | ||
| crypto | ||
| drivers | ||
| firmware | ||
| fs | ||
| include | ||
| init | ||
| ipc | ||
| kernel | ||
| lib | ||
| mm | ||
| net | ||
| samples | ||
| scripts | ||
| security | ||
| sound | ||
| tools | ||
| usr | ||
| virt | ||
| .gitignore | -rw-r--r-- | 936 bytes |
| .mailmap | -rw-r--r-- | 3.9 KB |
| COPYING | -rw-r--r-- | 18.3 KB |
| CREDITS | -rw-r--r-- | 91.8 KB |
| Kbuild | -rw-r--r-- | 2.4 KB |
| Kconfig | -rw-r--r-- | 252 bytes |
| MAINTAINERS | -rw-r--r-- | 178.4 KB |
| Makefile | -rw-r--r-- | 50.9 KB |
| README | -rw-r--r-- | 17.1 KB |
| REPORTING-BUGS | -rw-r--r-- | 3.3 KB |
Computing file changes ...
