Revision 2df8f8a6a897ebf4c5613b5be6103d33b2a21520 authored by Steven Rostedt on 11 January 2013, 21:14:10 UTC, committed by Steven Rostedt on 11 January 2013, 21:14:10 UTC
Commit 02404baf1b47 "tracing: Remove deprecated tracing_enabled file"
removed the tracing_enabled file as it never worked properly and
the tracing_on file should be used instead. But the tracing_on file
didn't call into the tracers start/stop routines like the
tracing_enabled file did. This caused trace-cmd to break when it
enabled the irqsoff tracer.

If you just did "echo irqsoff > current_tracer" then it would work
properly. But the tool trace-cmd disables tracing first by writing
"0" into the tracing_on file. Then it writes "irqsoff" into
current_tracer and then writes "1" into tracing_on. Unfortunately,
the above commit changed the irqsoff tracer to check the tracing_on
status instead of the tracing_enabled status. If it's disabled then
it does not start the tracer internals.

The problem is that writing "1" into tracing_on does not call the
tracers "start" routine like writing "1" into tracing_enabled did.
This makes the irqsoff tracer not start when using the trace-cmd
tool, and is a regression for userspace.

Simple fix is to have the tracing_on file call the tracers start()
method when being enabled (and the stop() method when disabled).

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
1 parent a8dd217
History
File Mode Size
lxdialog
.gitignore -rw-r--r-- 167 bytes
Makefile -rw-r--r-- 10.9 KB
POTFILES.in -rw-r--r-- 361 bytes
check.sh -rwxr-xr-x 215 bytes
conf.c -rw-r--r-- 15.2 KB
confdata.c -rw-r--r-- 23.6 KB
expr.c -rw-r--r-- 26.5 KB
expr.h -rw-r--r-- 7.1 KB
gconf.c -rw-r--r-- 38.8 KB
gconf.glade -rw-r--r-- 25.0 KB
images.c -rw-r--r-- 6.4 KB
kxgettext.c -rw-r--r-- 4.1 KB
list.h -rw-r--r-- 2.3 KB
lkc.h -rw-r--r-- 4.6 KB
lkc_proto.h -rw-r--r-- 2.4 KB
mconf.c -rw-r--r-- 25.7 KB
menu.c -rw-r--r-- 15.8 KB
merge_config.sh -rwxr-xr-x 3.3 KB
nconf.c -rw-r--r-- 38.3 KB
nconf.gui.c -rw-r--r-- 14.4 KB
nconf.h -rw-r--r-- 1.9 KB
qconf.cc -rw-r--r-- 43.3 KB
qconf.h -rw-r--r-- 7.7 KB
streamline_config.pl -rw-r--r-- 14.5 KB
symbol.c -rw-r--r-- 27.2 KB
util.c -rw-r--r-- 2.8 KB
zconf.gperf -rw-r--r-- 1.4 KB
zconf.hash.c_shipped -rw-r--r-- 11.8 KB
zconf.l -rw-r--r-- 6.5 KB
zconf.lex.c_shipped -rw-r--r-- 56.9 KB
zconf.tab.c_shipped -rw-r--r-- 70.6 KB
zconf.y -rw-r--r-- 15.2 KB

back to top