Revision 2df8f8a6a897ebf4c5613b5be6103d33b2a21520 authored by Steven Rostedt on 11 January 2013, 21:14:10 UTC, committed by Steven Rostedt on 11 January 2013, 21:14:10 UTC
Commit 02404baf1b47 "tracing: Remove deprecated tracing_enabled file" removed the tracing_enabled file as it never worked properly and the tracing_on file should be used instead. But the tracing_on file didn't call into the tracers start/stop routines like the tracing_enabled file did. This caused trace-cmd to break when it enabled the irqsoff tracer. If you just did "echo irqsoff > current_tracer" then it would work properly. But the tool trace-cmd disables tracing first by writing "0" into the tracing_on file. Then it writes "irqsoff" into current_tracer and then writes "1" into tracing_on. Unfortunately, the above commit changed the irqsoff tracer to check the tracing_on status instead of the tracing_enabled status. If it's disabled then it does not start the tracer internals. The problem is that writing "1" into tracing_on does not call the tracers "start" routine like writing "1" into tracing_enabled did. This makes the irqsoff tracer not start when using the trace-cmd tool, and is a regression for userspace. Simple fix is to have the tracing_on file call the tracers start() method when being enabled (and the stop() method when disabled). Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
1 parent a8dd217
File | Mode | Size |
---|---|---|
.gitignore | -rw-r--r-- | 34 bytes |
Makefile | -rw-r--r-- | 467 bytes |
empty.c | -rw-r--r-- | 54 bytes |
file2alias.c | -rw-r--r-- | 34.5 KB |
mk_elfconfig.c | -rw-r--r-- | 1.2 KB |
modpost.c | -rw-r--r-- | 56.6 KB |
modpost.h | -rw-r--r-- | 4.7 KB |
sumversion.c | -rw-r--r-- | 11.9 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...