Revision 2df8f8a6a897ebf4c5613b5be6103d33b2a21520 authored by Steven Rostedt on 11 January 2013, 21:14:10 UTC, committed by Steven Rostedt on 11 January 2013, 21:14:10 UTC
Commit 02404baf1b47 "tracing: Remove deprecated tracing_enabled file"
removed the tracing_enabled file as it never worked properly and
the tracing_on file should be used instead. But the tracing_on file
didn't call into the tracers start/stop routines like the
tracing_enabled file did. This caused trace-cmd to break when it
enabled the irqsoff tracer.

If you just did "echo irqsoff > current_tracer" then it would work
properly. But the tool trace-cmd disables tracing first by writing
"0" into the tracing_on file. Then it writes "irqsoff" into
current_tracer and then writes "1" into tracing_on. Unfortunately,
the above commit changed the irqsoff tracer to check the tracing_on
status instead of the tracing_enabled status. If it's disabled then
it does not start the tracer internals.

The problem is that writing "1" into tracing_on does not call the
tracers "start" routine like writing "1" into tracing_enabled did.
This makes the irqsoff tracer not start when using the trace-cmd
tool, and is a regression for userspace.

Simple fix is to have the tracing_on file call the tracers start()
method when being enabled (and the stop() method when disabled).

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
1 parent a8dd217
History
File Mode Size
ac97
ali5451
asihpi
au88x0
aw2
ca0106
cs46xx
cs5535audio
ctxfi
echoaudio
emu10k1
hda
ice1712
korg1212
lola
lx6464es
mixart
nm256
oxygen
pcxhr
riptide
rme9652
trident
vx222
ymfpci
Kconfig -rw-r--r-- 24.5 KB
Makefile -rw-r--r-- 2.1 KB
ad1889.c -rw-r--r-- 26.1 KB
ad1889.h -rw-r--r-- 7.9 KB
ak4531_codec.c -rw-r--r-- 17.1 KB
als300.c -rw-r--r-- 23.5 KB
als4000.c -rw-r--r-- 31.4 KB
atiixp.c -rw-r--r-- 45.6 KB
atiixp_modem.c -rw-r--r-- 35.8 KB
azt3328.c -rw-r--r-- 85.2 KB
azt3328.h -rw-r--r-- 15.5 KB
bt87x.c -rw-r--r-- 29.3 KB
cmipci.c -rw-r--r-- 101.8 KB
cs4281.c -rw-r--r-- 64.5 KB
cs5530.c -rw-r--r-- 7.1 KB
ens1370.c -rw-r--r-- 79.1 KB
ens1371.c -rw-r--r-- 38 bytes
es1938.c -rw-r--r-- 55.4 KB
es1968.c -rw-r--r-- 78.6 KB
fm801.c -rw-r--r-- 41.6 KB
intel8x0.c -rw-r--r-- 92.7 KB
intel8x0m.c -rw-r--r-- 37.5 KB
maestro3.c -rw-r--r-- 81.6 KB
rme32.c -rw-r--r-- 57.6 KB
rme96.c -rw-r--r-- 66.4 KB
sis7019.c -rw-r--r-- 40.0 KB
sis7019.h -rw-r--r-- 13.3 KB
sonicvibes.c -rw-r--r-- 51.4 KB
via82xx.c -rw-r--r-- 77.6 KB
via82xx_modem.c -rw-r--r-- 34.4 KB

back to top