Revision 2df8f8a6a897ebf4c5613b5be6103d33b2a21520 authored by Steven Rostedt on 11 January 2013, 21:14:10 UTC, committed by Steven Rostedt on 11 January 2013, 21:14:10 UTC
Commit 02404baf1b47 "tracing: Remove deprecated tracing_enabled file" removed the tracing_enabled file as it never worked properly and the tracing_on file should be used instead. But the tracing_on file didn't call into the tracers start/stop routines like the tracing_enabled file did. This caused trace-cmd to break when it enabled the irqsoff tracer. If you just did "echo irqsoff > current_tracer" then it would work properly. But the tool trace-cmd disables tracing first by writing "0" into the tracing_on file. Then it writes "irqsoff" into current_tracer and then writes "1" into tracing_on. Unfortunately, the above commit changed the irqsoff tracer to check the tracing_on status instead of the tracing_enabled status. If it's disabled then it does not start the tracer internals. The problem is that writing "1" into tracing_on does not call the tracers "start" routine like writing "1" into tracing_enabled did. This makes the irqsoff tracer not start when using the trace-cmd tool, and is a regression for userspace. Simple fix is to have the tracing_on file call the tracers start() method when being enabled (and the stop() method when disabled). Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
1 parent a8dd217
File | Mode | Size |
---|---|---|
Makefile | -rw-r--r-- | 1.1 KB |
darla20.c | -rw-r--r-- | 2.8 KB |
darla20_dsp.c | -rw-r--r-- | 3.4 KB |
darla24.c | -rw-r--r-- | 3.1 KB |
darla24_dsp.c | -rw-r--r-- | 3.8 KB |
echo3g.c | -rw-r--r-- | 3.4 KB |
echo3g_dsp.c | -rw-r--r-- | 4.1 KB |
echoaudio.c | -rw-r--r-- | 62.7 KB |
echoaudio.h | -rw-r--r-- | 17.7 KB |
echoaudio_3g.c | -rw-r--r-- | 11.0 KB |
echoaudio_dsp.c | -rw-r--r-- | 29.9 KB |
echoaudio_dsp.h | -rw-r--r-- | 20.4 KB |
echoaudio_gml.c | -rw-r--r-- | 5.8 KB |
gina20.c | -rw-r--r-- | 2.9 KB |
gina20_dsp.c | -rw-r--r-- | 5.5 KB |
gina24.c | -rw-r--r-- | 3.9 KB |
gina24_dsp.c | -rw-r--r-- | 9.1 KB |
indigo.c | -rw-r--r-- | 2.8 KB |
indigo_dsp.c | -rw-r--r-- | 3.9 KB |
indigo_express_dsp.c | -rw-r--r-- | 3.2 KB |
indigodj.c | -rw-r--r-- | 2.8 KB |
indigodj_dsp.c | -rw-r--r-- | 4.0 KB |
indigodjx.c | -rw-r--r-- | 2.9 KB |
indigodjx_dsp.c | -rw-r--r-- | 2.1 KB |
indigoio.c | -rw-r--r-- | 2.9 KB |
indigoio_dsp.c | -rw-r--r-- | 3.4 KB |
indigoiox.c | -rw-r--r-- | 2.9 KB |
indigoiox_dsp.c | -rw-r--r-- | 2.1 KB |
layla20.c | -rw-r--r-- | 3.3 KB |
layla20_dsp.c | -rw-r--r-- | 7.3 KB |
layla24.c | -rw-r--r-- | 3.6 KB |
layla24_dsp.c | -rw-r--r-- | 10.2 KB |
mia.c | -rw-r--r-- | 3.4 KB |
mia_dsp.c | -rw-r--r-- | 5.5 KB |
midi.c | -rw-r--r-- | 9.1 KB |
mona.c | -rw-r--r-- | 4.2 KB |
mona_dsp.c | -rw-r--r-- | 10.8 KB |
Computing file changes ...