https://github.com/web-platform-tests/wpt
Revision 2eafc77a24f2d1b635a2c1c442056455e4b273e4 authored by Morten Stenshorne on 14 March 2018, 06:40:47 UTC, committed by Chromium WPT Sync on 14 March 2018, 06:40:47 UTC
We cannot use the content size (intrinsic block size) as min-height or
max-height (min-width or max-width, if writing mode is vertical).
Doing so would cause min-height to incorrectly override any specified
height or max-height that is less than the intrinsic block size, and
max-height to override any specified height that's greater than the
intrinsic block size. Do what the spec says [1] instead: max-height
to become 'none', and min-height to become 0.

This fixes the final rendering problem with Acid2 (this was about the
min-height issue). It now renders correctly with LayoutNG!

Since no other tests than Acid2 started to pass with this change, I wrote
a couple.

[1] https://www.w3.org/TR/CSS22/visudet.html#min-max-heights

     XXXXXX
   XX      XX
  X          X
 X   O    O   X
 X            X
X      /\      X
X      \/      X
X              X
 X X        X X
 X  XXXXXXXX  X
  X          X
   XX      XX
     XXXXXX

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ic4f2c3c1dbc2bd66956ed4b270b08058999bc351
Reviewed-on: https://chromium-review.googlesource.com/960085
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543018}
1 parent 07b4a27
Raw File
Tip revision: 2eafc77a24f2d1b635a2c1c442056455e4b273e4 authored by Morten Stenshorne on 14 March 2018, 06:40:47 UTC
[LayoutNG] Don't resolve unresolvable percentage min-height and max-height.
Tip revision: 2eafc77
persisted.https.html
<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <title>StorageManager: persisted()</title>
    <meta name="help" href="https://storage.spec.whatwg.org/#dom-storagemanager-persisted">
    <meta name="author" title="Mozilla" href="https://www.mozilla.org">
    <script src="/resources/testharness.js"></script>
    <script src="/resources/testharnessreport.js"></script>
  </head>
  <body>
    <script src="storage-persisted.js"></script>
  </body>
</html>
back to top