Revision 2f162e51fd06b14eaa3ba9a542229bae26f30d71 authored by Ruifeng Zheng on 23 August 2023, 00:01:06 UTC, committed by Ruifeng Zheng on 23 August 2023, 00:01:29 UTC
### What changes were proposed in this pull request? `DataFrame.join` should throw IllegalArgumentException for invalid join types ### Why are the changes needed? all valid join types have already been supported, for an unknown one, should throw `IllegalArgumentException` now ### Does this PR introduce _any_ user-facing change? yes ### How was this patch tested? enabled UT ### Was this patch authored or co-authored using generative AI tooling? NO Closes #42603 from zhengruifeng/test_df_join_type. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org> (cherry picked from commit 7e5250a797e385dea65bdc3315e9bcfd827afbfb) Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
1 parent 99c9e63
CONTRIBUTING.md
## Contributing to Spark
*Before opening a pull request*, review the
[Contributing to Spark guide](https://spark.apache.org/contributing.html).
It lists steps that are required before creating a PR. In particular, consider:
- Is the change important and ready enough to ask the community to spend time reviewing?
- Have you searched for existing, related JIRAs and pull requests?
- Is this a new feature that can stand alone as a [third party project](https://spark.apache.org/third-party-projects.html) ?
- Is the change being proposed clearly explained and motivated?
When you contribute code, you affirm that the contribution is your original work and that you
license the work to the project under the project's open source license. Whether or not you
state this explicitly, by submitting any copyrighted material via pull request, email, or
other means you agree to license the material under the project's open source license and
warrant that you have the legal authority to do so.
Computing file changes ...
