Skip to main content

Browse the archive

https://github.com/torvalds/linux
13 June 2022, 11:31:42 UTC
Revision 2fb1e3086df9b454538491fba8121298da37cd23 authored by Al Viro on 19 August 2005, 21:42:16 UTC, committed by Linus Torvalds on 20 August 2005, 00:57:19 UTC 
[PATCH] jffs2: fix symlink error handling
 
The current calling conventions for ->follow_link() are already fairly
complex.

What we have is
	1) you can return -error; then you must release nameidata yourself
	   and ->put_link() will _not_ be called.
	2) you can do nd_set_link(nd, ERR_PTR(-error)) and return 0
	3) you can do nd_set_link(nd, path) and return 0
	4) you can return 0 (after having moved nameidata yourself)

jffs2 follow_link() is broken - it has an exit where it returns
-EIO and leaks nameidata.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
1 parent 91aa9fb
History
Tip revision: 2fb1e3086df9b454538491fba8121298da37cd23 authored by Al Viro on 19 August 2005, 21:42:16 UTC
[PATCH] jffs2: fix symlink error handling
Tip revision: 2fb1e30
File Mode Size
Documentation
arch
crypto
drivers
fs
include
init
ipc
kernel
lib
mm
net
scripts
security
sound
usr
COPYING -rw-r--r-- 18.3 KB
CREDITS -rw-r--r-- 87.2 KB
MAINTAINERS -rw-r--r-- 57.5 KB
Makefile -rw-r--r-- 43.4 KB
README -rw-r--r-- 14.2 KB
REPORTING-BUGS -rw-r--r-- 3.0 KB

README

back to top