Revision - 307da62 - build(docs-infra): ensure `ngsw.json` generation is correct and [...] - origin: https://github.com/angular/angular

visit type:

https://github.com/angular/angular

07 August 2024, 03:31:07 UTC

Revision 307da62cd96aca593b907f9ac879b903b0746f9f authored by George Kalpakas on 03 October 2021, 09:05:46 UTC, committed by Dylan Hunn on 05 October 2021, 16:49:15 UTC

build(docs-infra): ensure `ngsw.json` generation is correct and deterministic (#43687)

As explained in #43679, currently the generation of the `ngsw.json` SW
manifest is non-deterministic and often incorrect. Until we can update
to an `@angular/service-worker` version that includes the fix from
PR #43679, we temporarily work-around the issue by re-generating the
`ngsw.json` manifest after `ng build` using the `ngsw-config` binary
exposed by `@angular/service-worker`.

NOTE:
This works around the issue, because the [FileSystem][1] class used by
the `ngsw-config` binary happens to be synchronous (unlike the
implementation provided by the Angular CLI), thus avoiding the race
conditions described in #43679.

[1]: https://github.com/angular/angular/blob/c721135e370b34c840756bcfb22c8119b4c8c452/packages/service-worker/cli/filesystem.ts#L15

PR Close #43687

1 parent fb29da2

Files
Changes

Permalinks

Tip revision: 307da62cd96aca593b907f9ac879b903b0746f9f authored by George Kalpakas on 03 October 2021, 09:05:46 UTC
build(docs-infra): ensure `ngsw.json` generation is correct and deterministic (#43687)

Tip revision: 307da62

File	Mode	Size
.circleci
.devcontainer
.github
.husky
.ng-dev
.vscode
.yarn
aio
docs
goldens
integration
modules
packages
scripts
third_party
tools
.bazelignore	-rw-r--r--	4.2 KB
.bazelrc	-rw-r--r--	6.5 KB
.bazelversion	-rw-r--r--	6 bytes
.clang-format	-rw-r--r--	73 bytes
.editorconfig	-rw-r--r--	245 bytes
.gitattributes	-rw-r--r--	240 bytes
.gitignore	-rw-r--r--	797 bytes
.gitmessage	-rw-r--r--	7.2 KB
.mailmap	-rw-r--r--	51 bytes
.npmrc	-rw-r--r--	21 bytes
.nvmrc	-rw-r--r--	8 bytes
.prettierrc	-rw-r--r--	157 bytes
.pullapprove.yml	-rw-r--r--	46.6 KB
.yarnrc	-rw-r--r--	130 bytes
BUILD.bazel	-rw-r--r--	2.0 KB
CHANGELOG.md	-rw-r--r--	924.4 KB
CODE_OF_CONDUCT.md	-rw-r--r--	1.1 KB
CONTRIBUTING.md	-rw-r--r--	15.8 KB
LICENSE	-rw-r--r--	1.1 KB
README.md	-rw-r--r--	4.7 KB
WORKSPACE	-rw-r--r--	2.4 KB
browser-providers.conf.js	-rw-r--r--	8.4 KB
gulpfile.js	-rw-r--r--	631 bytes
karma-js.conf.js	-rw-r--r--	8.1 KB
package.json	-rw-r--r--	8.6 KB
renovate.json	-rw-r--r--	2.6 KB
test-events.js	-rw-r--r--	259 bytes
test-main.js	-rw-r--r--	9.4 KB
tsconfig-tslint.json	-rw-r--r--	149 bytes
tslint.json	-rw-r--r--	3.2 KB
yarn.lock	-rw-r--r--	622.5 KB
yarn.lock.readme.md	-rw-r--r--	1.3 KB

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/angular/angular

build(docs-infra): ensure `ngsw.json` generation is correct and deterministic (#43687)

README.md