https://github.com/torvalds/linux
Revision 31a3ddda166cda86d2b5111e09ba4bda5239fae6 authored by Amit Shah on 14 March 2011, 12:15:02 UTC, committed by Rusty Russell on 21 April 2011, 13:27:00 UTC
In the case where a virtio-console port is in use (opened by a program)
and a virtio-console device is removed, the port is kept around but all
the virtio-related state is assumed to be gone.
When the port is finally released (close() called), we call
device_destroy() on the port's device. This results in the parent
device's structures to be freed as well. This includes the PCI regions
for the virtio-console PCI device.
Once this is done, however, virtio_pci_release_dev() kicks in, as the
last ref to the virtio device is now gone, and attempts to do
pci_iounmap(pci_dev, vp_dev->ioaddr);
pci_release_regions(pci_dev);
pci_disable_device(pci_dev);
which results in a double-free warning.
Move the code that releases regions, etc., to the virtio_pci_remove()
function, and all that's now left in release_dev is the final freeing of
the vp_dev.
Signed-off-by: Amit Shah <amit.shah@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
1 parent b3258ff
Tip revision: 31a3ddda166cda86d2b5111e09ba4bda5239fae6 authored by Amit Shah on 14 March 2011, 12:15:02 UTC
virtio_pci: Prevent double-free of pci regions after device hot-unplug
virtio_pci: Prevent double-free of pci regions after device hot-unplug
Tip revision: 31a3ddd
| File | Mode | Size |
|---|---|---|
| Documentation | ||
| arch | ||
| block | ||
| crypto | ||
| drivers | ||
| firmware | ||
| fs | ||
| include | ||
| init | ||
| ipc | ||
| kernel | ||
| lib | ||
| mm | ||
| net | ||
| samples | ||
| scripts | ||
| security | ||
| sound | ||
| tools | ||
| usr | ||
| virt | ||
| .gitignore | -rw-r--r-- | 941 bytes |
| .mailmap | -rw-r--r-- | 4.1 KB |
| COPYING | -rw-r--r-- | 18.3 KB |
| CREDITS | -rw-r--r-- | 91.7 KB |
| Kbuild | -rw-r--r-- | 2.4 KB |
| Kconfig | -rw-r--r-- | 252 bytes |
| MAINTAINERS | -rw-r--r-- | 188.3 KB |
| Makefile | -rw-r--r-- | 51.1 KB |
| README | -rw-r--r-- | 17.1 KB |
| REPORTING-BUGS | -rw-r--r-- | 3.3 KB |
Computing file changes ...
