Revision 31a51c70f74e23dc52f2033e552990a03f3166a9 authored by Mike Pennisi on 29 June 2018, 15:27:58 UTC, committed by Ms2ger on 02 July 2018, 14:31:05 UTC
Today, the return value of functions provided to the global `add_cleanup` function has no effect on the behavior of the test runner. An upcoming feature addition to testharness.js will cause the return value to influence test results [1]. Despite this, some existing tests have already been authored to return a value: the result of `document.exitFullScreen`. Although this is expected to be a Promise in conforming implementations, some browsers do not yet implement this functionality. To allow the new test harness feature to land without introducing harness errors, refactor existing tests to omit a return value. Additionally, use `Promise.prototype.catch` to avoid race conditions resulting from unhandled Promise rejections (which trigger a harness error in testharness.js today). [1] https://github.com/web-platform-tests/wpt/issues/6075
1 parent 21369c1
File | Mode | Size |
---|---|---|
2d.scrollPathIntoView.basic.html | -rw-r--r-- | 1.2 KB |
2d.scrollPathIntoView.path.html | -rw-r--r-- | 1.2 KB |
2d.scrollPathIntoView.verticalLR.html | -rw-r--r-- | 1.3 KB |
2d.scrollPathIntoView.verticalRL.html | -rw-r--r-- | 1.5 KB |
Computing file changes ...